crash during svn blame on windows 64-bit version

2011-02-23 Thread Marc Haesen
Hi, I saw a crash when running svn blame with a svn.exe compiled for win64 on trunk. After some investigation I found the reason for the crash. The reason is because apr.h is using the define WIN64 for defining the APR_SIZEOF_VOIDP define. (I am using the apr.h/apr.hw delivered with httpd

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-23 Thread Lieven Govaerts
On Mon, Feb 21, 2011 at 11:32 AM, Noorul Islam K M wrote: > Noorul Islam K M writes: > > > Stefan Sperling writes: > > > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > >> > >>> > >>> This patch reduces checkout by around 23 times. > >> > >> On my system the difference is

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-23 Thread Noorul Islam K M
"C. Michael Pilato" writes: > On 02/21/2011 09:30 PM, Noorul Islam K M wrote: > >> Branko Čibej writes: >> >>> On 22.02.2011 02:50, Noorul Islam K M wrote: >>> danie...@apache.org writes: > Author: danielsh > Date: Mon Feb 21 18:14:02 2011 > New Revision: 1073102 > >>>

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-23 Thread Noorul Islam K M
Johan Corveleyn writes: > On Mon, Feb 21, 2011 at 1:50 PM, Noorul Islam K M wrote: > >> "Bert Huijben" writes: >> -Original Message- From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej Sent: maandag 21 februari 2011 13:19 To: Philip Martin Cc: dev

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-23 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 12:19:34PM +, Philip Martin wrote: > >> Stefan Sperling writes: >> >> > Fair enough, but why not write a specific test for this instead of testing >> > it as a side effect of making the code of other tests harder to read? >> >> The assumpti

Re: [PATCH] Re: svn commit: r1071809 - in /subversion/trunk: build/run_tests.py subversion/tests/cmdline/svntest/main.py win-tests.py

2011-02-23 Thread Noorul Islam K M
Noorul Islam K M writes: > Paul Burba writes: > >> If someone with the requisite linux skills/hardware could tweak >> makefile.in so it can take advantage of the --milestone-filter option, >> well that would be fabulous. >> >> Paul >> >> On Thu, Feb 17, 2011 at 5:09 PM, wrote: >>> Author: pbur

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-23 Thread Noorul Islam K M
Noorul Islam K M writes: > Julian Foad writes: > >> On Fri, 2011-02-18 at 15:54 +0530, Noorul Islam K M wrote: >> >>> Noorul Islam K M writes: >>> >>> > Julian Foad writes: >>> > >>> >> On Thu, 2011-02-17 at 21:04 +0530, Noorul Islam K M wrote: >>> >> >>> >>> Julian Foad writes: >>> >>> >>>

Re: [PATCH] - Fix for issue #3792

2011-02-23 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> Daniel Shahaf writes: >> >>> Noorul Islam K M wrote on Wed, Feb 09, 2011 at 14:28:49 +0530: >>> Daniel Shahaf writes: > Noorul Islam K M wrote on Sat, Feb 05, 2011 at 12:55:55 +0530: >> Daniel Shahaf writes: >> > Noo

Re: svn commit: r1069963 - in /subversion/trunk: notes/client-configuration subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db_pdh.c subversion/libsvn_wc/wc_db_private.h

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 1:58 PM, Greg Stein wrote: > On Fri, Feb 11, 2011 at 16:57,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Fri Feb 11 21:57:29 2011 >>... >> @@ -7265,17 +7270,22 @@ svn_wc__db_temp_set_access(svn_wc__db_t >>                            svn_wc_adm_access_

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 08:52:18PM +0100, Bert Huijben wrote: > I think just seeing every node below a workingcopy as a node in the parent > working copy will make things harder instead of simpler. So I would suggest > moving the redefining of normal externals to 1.8. (But I still think we have > t

Re: svn commit: r1073870 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

2011-02-23 Thread Greg Stein
This log message doesn't match. On Wed, Feb 23, 2011 at 13:24, wrote: > Author: hwright > Date: Wed Feb 23 18:24:53 2011 > New Revision: 1073870 > > URL: http://svn.apache.org/viewvc?rev=1073870&view=rev > Log: > Reduce the scope of a helper function. > > * subversion/libsvn_wc/wc_db_pdh.c >  (s

Re: svn commit: r1069963 - in /subversion/trunk: notes/client-configuration subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db_pdh.c subversion/libsvn_wc/wc_db_private.h

2011-02-23 Thread Greg Stein
On Fri, Feb 11, 2011 at 16:57, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Fri Feb 11 21:57:29 2011 >... > @@ -7265,17 +7270,22 @@ svn_wc__db_temp_set_access(svn_wc__db_t >                            svn_wc_adm_access_t *adm_access, >                            apr_pool_t *scr

RE: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: woensdag 23 februari 2011 19:47 > To: Julian Foad; b...@ted.stsp.name; Hyrum K Wright; > dev@subversion.apache.org > Cc: Stefan Sperling > Subject: Re: initial thoughts on issue #3818: fix handling of exter

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 12:46:44PM -0600, Hyrum K Wright wrote: > On Wed, Feb 23, 2011 at 12:26 PM, Stefan Sperling wrote: > > We need to preserve 1.6 semantics of how operations affect externals. > > Why? People have been wanting to commit across externals and working > copies for a *long* time

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 04:13:21PM +, Julian Foad wrote: > We need a handle that we can pass around that references the whole > nesting of WCs (where "WC" is defined as the scope of a single wcroot). > That could be a new thing that we can invent, but I wonder if instead it > would be reasonabl

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 12:26 PM, Stefan Sperling wrote: > On Wed, Feb 23, 2011 at 04:26:52PM +, Julian Foad wrote: >> Hyrum K Wright wrote: >> > On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad >> > wrote: >> > > Stefan Sperling wrote: >> > >>  So, ideally, we should decouple the >> > >> concep

Re: initial thoughts on issue #3818

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 05:50:57PM +, Philip Martin wrote: > Stefan Sperling writes: > > > Given a local_abspath, there's an ambiguity about which wcroots > > are associated with it when externals are involved. > > E.g. given the path was foo/bar/baz, where bar has an svn:externals > > proper

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 04:26:52PM +, Julian Foad wrote: > Hyrum K Wright wrote: > > On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad > > wrote: > > > Stefan Sperling wrote: > > >> So, ideally, we should decouple the > > >> concept of a wcroot from the path. We could tie it to a wc_id instead. >

Re: initial thoughts on issue #3818

2011-02-23 Thread Philip Martin
Stefan Sperling writes: > Given a local_abspath, there's an ambiguity about which wcroots > are associated with it when externals are involved. > E.g. given the path was foo/bar/baz, where bar has an svn:externals > property that configures an external to be downloaded into the > folder 'baz'. Wh

Re: replace and changelists

2011-02-23 Thread Philip Martin
Philip Martin writes: > Changelists only contain files in 1.6, but in 1.7 files can be replaced > with directories: > > $ svn changelist qq wc/foo > $ svn rm wc/foo > $ svn mkdir wc/foo > > Does the changelist qq refer to the replacing dir foo or only to the > replaced file foo? When a recursive

Re: svn commit: r1071795 - /subversion/trunk/notes/wc-ng/pristine-store

2011-02-23 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Feb 23, 2011 at 16:02:49 +0200: > julianf...@apache.org wrote on Thu, Feb 17, 2011 at 21:20:33 -: > > Author: julianfoad > > Date: Thu Feb 17 21:20:33 2011 > > New Revision: 1071795 > > > > URL: http://svn.apache.org/viewvc?rev=1071795&view=rev > > Log: > > * notes/

Re: svn commit: r1073366 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db_pristine.c

2011-02-23 Thread Daniel Shahaf
julianf...@apache.org wrote on Tue, Feb 22, 2011 at 15:38:35 -: > Modified: subversion/trunk/subversion/libsvn_wc/wc_db_pristine.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db_pristine.c?rev=1073366&r1=1073365&r2=1073366&view=diff >

replace and changelists

2011-02-23 Thread Philip Martin
Changelists only contain files in 1.6, but in 1.7 files can be replaced with directories: $ svn changelist qq wc/foo $ svn rm wc/foo $ svn mkdir wc/foo Does the changelist qq refer to the replacing dir foo or only to the replaced file foo? -- Philip

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Julian Foad
Hyrum K Wright wrote: > On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad wrote: > > Stefan Sperling wrote: > >> So, ideally, we should decouple the > >> concept of a wcroot from the path. We could tie it to a wc_id instead. > >> This would allow us to use a single wc.db to manage several wcroots, > >

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Julian Foad
On Wed, 2011-02-23, Julian Foad wrote: > Stefan Sperling wrote: > > (svn:externals ^/branches/foo baz) > > | > > .../foo/bar/baz > > owcroot1 > > owcroot2 > > > > The ambiguity arises because the local_abspath of wcroot2 is also > > a local relpath

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad wrote: > (I've appended the issue subject to the subject line.) > > Stefan Sperling wrote: >> I filed a new issue today (issue #3818, "fix handling of externals in >> wc-ng" http://subversion.tigris.org/issues/show_bug.cgi?id=3818). >> >> I had a brief

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Julian Foad
(I've appended the issue subject to the subject line.) Stefan Sperling wrote: > I filed a new issue today (issue #3818, "fix handling of externals in > wc-ng" http://subversion.tigris.org/issues/show_bug.cgi?id=3818). > > I had a brief chat with sbutler at the elego office before filing > this is

initial thoughts on issue #3818

2011-02-23 Thread Stefan Sperling
I filed a new issue today (issue #3818, "fix handling of externals in wc-ng" http://subversion.tigris.org/issues/show_bug.cgi?id=3818). I had a brief chat with sbutler at the elego office before filing this issue. Below are basic ideas we've had for approaching the problem. Feedback appreciated!

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-23 Thread Neels Hofmeyr
On Sat, 2011-02-19 at 04:53 +0100, Stefan Sperling wrote: > On Fri, Feb 18, 2011 at 09:19:56PM -0500, Greg Stein wrote: > > Can somebody provide a pointer to some of the latest speed analysis? > > Neels is on vacation this week. When he returns, I'll prod him > about running his performance tests

Re: [Issue 3818] fix handling of externals in wc-ng

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 07:16:24AM -0600, Hyrum K Wright wrote: > On Wed, Feb 23, 2011 at 7:10 AM, wrote: > > http://subversion.tigris.org/issues/show_bug.cgi?id=3818 > > > > > > > > User stsp changed the following: > > > >                What    |Old value                 |New value > >

Re: svn commit: r1071795 - /subversion/trunk/notes/wc-ng/pristine-store

2011-02-23 Thread Daniel Shahaf
julianf...@apache.org wrote on Thu, Feb 17, 2011 at 21:20:33 -: > Author: julianfoad > Date: Thu Feb 17 21:20:33 2011 > New Revision: 1071795 > > URL: http://svn.apache.org/viewvc?rev=1071795&view=rev > Log: > * notes/wc-ng/pristine-store > Update with initial feedback from danielsh. > > Mo

Re: [PATCH] #3807: 'svn up' of a nonexistent child in a copied dir triggers an assertion

2011-02-23 Thread Philip Martin
Daniel Shahaf writes: > ###: what *should* the 'svn up' do? Should it always succeed > silently, or should > ### 'svn cp A A2; svn mkdir ^/A/foo; svn up A2/foo' pull the new > directory? I don't think it should pull the new foo. At present "svn cp" fixes the copyfrom revision and a subsequent

Re: [Issue 3818] fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 7:10 AM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3818 > > > > User stsp changed the following: > >                What    |Old value                 |New value > >     Iss

[PATCH] #3807: 'svn up' of a nonexistent child in a copied dir triggers an assertion

2011-02-23 Thread Daniel Shahaf
http://subversion.tigris.org/issues/show_bug.cgi?id=3807 I've had a look at the above, and I'm attaching a patch. I'd like to get review of this patch --- I have not worked enough on wc internals to feel confident about it, and I wrote at least part of it by an "Add an if() until the tests stop s

Re: Why does import fail with autoprops ("inconsistent eol style")?

2011-02-23 Thread John Szakmeister
On Wed, Feb 23, 2011 at 6:20 AM, Stefan Sperling wrote: [snip] > Hmmm, I'm not following. Maybe there's a misunderstanding. Looks like I'm the one that's not following. :-) > The code does already override any inconsistent line endings for > svn:eol-style values CR, CRLF, and LF. It just doesn't

Re: Why does import fail with autoprops ("inconsistent eol style")?

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 05:56:13AM -0500, John Szakmeister wrote: > On Wed, Feb 23, 2011 at 5:47 AM, Stefan Sperling wrote: > > On Wed, Feb 23, 2011 at 04:56:03AM -0500, John Szakmeister wrote: > >> On Tue, Feb 22, 2011 at 1:35 PM, Stefan Sperling wrote: > >> > When trying to 'svn import' files t

Re: [PATCH] Remove dead code - was - Re: svn commit: r1067669

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 09:05:16AM +0100, Stefan Fuhrmann wrote: > On 23.02.2011 06:47, Dongsheng Song wrote: > > Hi Donsheng, > > Thanks for your review. You are right that these two > functions are not being used right now, but the > integration-partial-getter and integration-is-cachable > bran

Re: Why does import fail with autoprops ("inconsistent eol style")?

2011-02-23 Thread John Szakmeister
On Wed, Feb 23, 2011 at 5:47 AM, Stefan Sperling wrote: > On Wed, Feb 23, 2011 at 04:56:03AM -0500, John Szakmeister wrote: >> On Tue, Feb 22, 2011 at 1:35 PM, Stefan Sperling wrote: >> > When trying to 'svn import' files that have a mixed eol style, >> > and at the same time using autoprops to s

Re: Last batch of performance improvements for 1.7

2011-02-23 Thread John Szakmeister
On Wed, Feb 23, 2011 at 3:43 AM, Stefan Fuhrmann wrote: [snip] > List of integration branches: > - > > integrate-is-cachable > - replace the fixed 1MB limit to the cachable full-text >  size in FSFS with a cache-specific implementation Took a look at this one. The cha

Re: Why does import fail with autoprops ("inconsistent eol style")?

2011-02-23 Thread Stefan Sperling
On Wed, Feb 23, 2011 at 04:56:03AM -0500, John Szakmeister wrote: > On Tue, Feb 22, 2011 at 1:35 PM, Stefan Sperling wrote: > > When trying to 'svn import' files that have a mixed eol style, > > and at the same time using autoprops to set an svn:eol-style property > > with value 'native' on this f

Re: Why does import fail with autoprops ("inconsistent eol style")?

2011-02-23 Thread John Szakmeister
On Tue, Feb 22, 2011 at 1:35 PM, Stefan Sperling wrote: > When trying to 'svn import' files that have a mixed eol style, > and at the same time using autoprops to set an svn:eol-style property > with value 'native' on this file, svn import aborts with an "Inconsistent > line ending style" error. I

Last batch of performance improvements for 1.7

2011-02-23 Thread Stefan Fuhrmann
Hi all, You may have noticed that I prepared yet another bunch of changes for integration into /trunk (details below). All other remaining changes on the performance branch are 1.8 material. You know the drill: The integration branches can be merged independent of each other and a branch will be

Re: [PATCH] Remove dead code - was - Re: svn commit: r1067669

2011-02-23 Thread Stefan Fuhrmann
On 23.02.2011 06:47, Dongsheng Song wrote: Hi Donsheng, Thanks for your review. You are right that these two functions are not being used right now, but the integration-partial-getter and integration-is-cachable branches will add them to the svn_cache_t interface. I didn't temporarily remove th