Re: [PATCH] Fix for Issue #3781 repo prefix rules in authz section is checked case sensitively for commit

2011-01-19 Thread Arwin Arni
On Wednesday 19 January 2011 09:46 PM, C. Michael Pilato wrote: On 01/19/2011 10:52 AM, Arwin Arni wrote: Hi All, Authz section names(and paths too) are parsed/loaded in a case insensitive way. So they need to be compared in a case-insensitive way. Following functions do authz, 1. libsvn_rep

Re: svn commit: r1060937 - in /subversion/branches/uris-as-urls/subversion: libsvn_fs_base/bdb/changes-table.c libsvn_fs_base/bdb/locks-table.c libsvn_fs_fs/lock.c

2011-01-19 Thread C. Michael Pilato
On 01/19/2011 04:21 PM, Ivan Zhakov wrote: > On Wed, Jan 19, 2011 at 22:52, wrote: [...] >> Modified: >> subversion/branches/uris-as-urls/subversion/libsvn_fs_base/bdb/locks-table.c >> URL: >> http://svn.apache.org/viewvc/subversion/branches/uris-as-urls/subversion/libsvn_fs_base/bdb/locks-ta

Re: svn commit: r1060937 - in /subversion/branches/uris-as-urls/subversion: libsvn_fs_base/bdb/changes-table.c libsvn_fs_base/bdb/locks-table.c libsvn_fs_fs/lock.c

2011-01-19 Thread C. Michael Pilato
On 01/19/2011 04:21 PM, Ivan Zhakov wrote: > On Wed, Jan 19, 2011 at 22:52, wrote: [...] >> Modified: >> subversion/branches/uris-as-urls/subversion/libsvn_fs_base/bdb/locks-table.c >> URL: >> http://svn.apache.org/viewvc/subversion/branches/uris-as-urls/subversion/libsvn_fs_base/bdb/locks-ta

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-19 Thread Daniel Shahaf
Daniel Becroft wrote on Wed, Jan 19, 2011 at 21:17:23 +1000: > Thanks, Daniel. I've attached a new version of the patch, with amended log > message below. > Thanks, Daniel. I added a missing article to the log message, wrapped to 80 characters, added another pair of "is executable" checks (per m

Re: svn commit: r1060937 - in /subversion/branches/uris-as-urls/subversion: libsvn_fs_base/bdb/changes-table.c libsvn_fs_base/bdb/locks-table.c libsvn_fs_fs/lock.c

2011-01-19 Thread Ivan Zhakov
On Wed, Jan 19, 2011 at 22:52, wrote: > Author: cmpilato > Date: Wed Jan 19 19:52:24 2011 > New Revision: 1060937 > > URL: http://svn.apache.org/viewvc?rev=1060937&view=rev > Log: > On the 'uris-as-urls' branch, review and correct some use of the > svn_uri_* APIs.  (One step of many similar ones.

Re: NFS and fsfs: slow commit performance

2011-01-19 Thread Blair Zajac
On 01/19/2011 05:27 AM, C. Michael Pilato wrote: On 01/17/2011 11:42 PM, Blair Zajac wrote: 3) I understand some of the large svn hosting providers host on NetApp, don't they see this issue? Do they use a master/standby deployment so it doesn't matter? CollabNet's hosted offerings are designe

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-19 Thread Blair Zajac
On 01/19/2011 03:17 AM, Daniel Becroft wrote: On Wed, Jan 19, 2011 at 7:36 AM, Daniel Shahaf mailto:d...@daniel.shahaf.name>> wrote: Daniel Becroft wrote on Wed, Jan 19, 2011 at 07:27:15 +1000: > On Wed, Jan 19, 2011 at 3:08 AM, Daniel Shahaf mailto:d...@daniel.shahaf.name>>wrote:

Re: [PATCH] Fix for Issue #3781 repo prefix rules in authz section is checked case sensitively for commit

2011-01-19 Thread C. Michael Pilato
On 01/19/2011 10:52 AM, Arwin Arni wrote: > Hi All, > > Authz section names(and paths too) are parsed/loaded in a case insensitive > way. > > So they need to be compared in a case-insensitive way. > > Following functions do authz, > > 1. libsvn_repos/authz.c:authz_get_path_access() > 2. libsvn

[PATCH] Fix for Issue #3781 repo prefix rules in authz section is checked case sensitively for commit

2011-01-19 Thread Arwin Arni
Hi All, Authz section names(and paths too) are parsed/loaded in a case insensitive way. So they need to be compared in a case-insensitive way. Following functions do authz, 1. libsvn_repos/authz.c:authz_get_path_access() 2. libsvn_repos/authz.c:authz_get_any_access() is called when the "path

Re: [PATCH] Renames functions in libsvn_repos/authz.c with better meaning

2011-01-19 Thread Arwin Arni
On Wednesday 19 January 2011 08:58 PM, C. Michael Pilato wrote: On 01/19/2011 08:48 AM, Arwin Arni wrote: Hi All, There are a couple of functions (authz_get_global_access, authz_global_parse_section) inside libsvn_repos/authz.c which completely threw me off track by virtue of their names. The n

Re: [PATCH] Renames functions in libsvn_repos/authz.c with better meaning

2011-01-19 Thread C. Michael Pilato
On 01/19/2011 10:28 AM, C. Michael Pilato wrote: > On 01/19/2011 08:48 AM, Arwin Arni wrote: > [...] >> This patch renames these functions to convey a better meaning, and also >> inserts a comment that explains the function better. I have attached the >> patch and log message. >> >> Regards, >> Arw

Re: [PATCH] Renames functions in libsvn_repos/authz.c with better meaning

2011-01-19 Thread C. Michael Pilato
On 01/19/2011 08:48 AM, Arwin Arni wrote: > Hi All, > > There are a couple of functions (authz_get_global_access, > authz_global_parse_section) inside libsvn_repos/authz.c which completely > threw me off track by virtue of their names. The names seem to suggest that > they check for global access

Re: [PATCH] Server fix for issue #3657 - Any mod_dav_svn experts out there? (was Re: svn commit: r966822)

2011-01-19 Thread C. Michael Pilato
Hey, Paul. Overall, I think the change makes sense. I've given some inline review below. (This is based mostly on a reading of the patch itself, not a reading of the patched source files.) On 01/18/2011 04:44 PM, Paul Burba wrote: > Index: subversion/mod_dav_svn/reports/update.c > =

[PATCH] Renames functions in libsvn_repos/authz.c with better meaning

2011-01-19 Thread Arwin Arni
Hi All, There are a couple of functions (authz_get_global_access, authz_global_parse_section) inside libsvn_repos/authz.c which completely threw me off track by virtue of their names. The names seem to suggest that they check for global access to the repository, which is very misleading. What

Re: NFS and fsfs: slow commit performance

2011-01-19 Thread C. Michael Pilato
On 01/17/2011 11:42 PM, Blair Zajac wrote: > 3) I understand some of the large svn hosting providers host on NetApp, > don't they see this issue? Do they use a master/standby deployment so it > doesn't matter? CollabNet's hosted offerings are designed in such a way that there is never more than o

Incorporate svn 1.7 changes to vc-svn.el

2011-01-19 Thread Noorul Islam K M
After migrating working copy to 1.7, vc-svn.el is not functioning properly. This is because .svn/entries file does not exist. I think we no longer need to check existence of this file. Since .svn exists at the root of the working copy we no longer be able to assume that .svn will be available in a

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-19 Thread Daniel Becroft
On Wed, Jan 19, 2011 at 7:36 AM, Daniel Shahaf wrote: > Daniel Becroft wrote on Wed, Jan 19, 2011 at 07:27:15 +1000: > > On Wed, Jan 19, 2011 at 3:08 AM, Daniel Shahaf >wrote: > > > Daniel Becroft wrote on Tue, Jan 18, 2011 at 07:13:12 +1000: > > > > 2) The problem also exists under the '--reinte

[PATCH] svn command - cat - Multiple targets

2011-01-19 Thread Noorul Islam K M
This patch is a followup of the following thread. All tests pass with this patch. http://svn.haxx.se/dev/archive-2011-01/0210.shtml Log [[[ Make svn 'cat' command to return 1 when one or more targets fails. Also print error message at the end. This also fixes issue #3713. * subversion/svn/cat