Re: [oss-security] CVE request for subversion

2011-01-08 Thread Hyrum K Wright
On Wed, Jan 5, 2011 at 10:09 AM, Josh Bressers wrote: > > OK, let's split the CVE id then. > > So for > A, "* prevent crash in mod_dav_svn when using SVNParentPath (r1033166)" >  Upstream changeset: >  http://svn.apache.org/viewvc?view=revision&revision=1033166 > > Let's use CVE-2010-4539. > > For

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-08 Thread Hyrum K Wright
On Fri, Jan 7, 2011 at 10:06 AM, Julian Foad wrote: > On Fri, 2011-01-07 at 15:19 +, Philip Martin wrote: >> Julian Foad writes: >> >> > The only case that SQLite doesn't handle automatically is the >> > replacement part of "INSERT OR REPLACE INTO ...": it doesn't fire the >> > "delete" trigg

Re: Force Subversion to grab information from Mac OS X keychain

2011-01-08 Thread Hyrum K Wright
Your question is about the usage of Subversion, not it's development. Hence, us...@subversion.apache.org is the appropriate forum for your post. Best, -Hyrum On Fri, Jan 7, 2011 at 2:43 PM, Kevin Lindeman wrote: > Hi, > > I am running Subversion on Mac OS X. I noticed that once I login correctly

Re: [PATCH] fsfs: flush proto rev files (issue #3705)

2011-01-08 Thread Stefan Sperling
On Sun, Jan 09, 2011 at 09:34:01AM +1100, Gavin Beau Baumanis wrote: > Hi Daniel, > Being a non SVN dev I am certainly not in a position to review your patch.. > But being a developer, none the less, that prescribes to Test Driven > Development I have to say, > Why Fight it? > > Occam's razor?

Re: [PATCH] fsfs: flush proto rev files (issue #3705)

2011-01-08 Thread Gavin Beau Baumanis
Hi Daniel, Being a non SVN dev I am certainly not in a position to review your patch.. But being a developer, none the less, that prescribes to Test Driven Development I have to say, Why Fight it? Occam's razor? Beau. On 09/01/2011, at 2:42 AM, Daniel Shahaf wrote: > [ issue #3705 is the "co

[PATCH] fsfs: flush proto rev files (issue #3705)

2011-01-08 Thread Daniel Shahaf
[ issue #3705 is the "corruption that fsfsverify fixes" issue. ] One of my old todo notes from issue #3705 is to flush proto rev files. Looking into the code, I came up with the following. Does that look right? It seems too short to be the real fix. [[[ Index: ../libsvn_fs_fs/fs_fs.c =

Re: [PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Stefan Sperling
On Sat, Jan 08, 2011 at 05:50:52PM +0530, Ramkumar Ramachandra wrote: > I had an issue with my stock SVN picking up the APR libraries I'd just > compiled, because LD_LIBRARY_PATH is set in Makefile.svn in several > places. Stock SVN (Debian) was compiled with threading support, and > the compiled A

Re: [PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > On Sat, Jan 08, 2011 at 02:33:46PM +0530, Ramkumar Ramachandra wrote: > > [[[ > > Makefile.svn: Make stock SVN binary configurable > > > > * tools/dev/unix-build/Makefile.svn: Introduce a new variable > > $STOCK_SVN that defaults to `env LD_LIBRARY_PATH= svn

Re: [PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Stefan Sperling
On Sat, Jan 08, 2011 at 02:33:46PM +0530, Ramkumar Ramachandra wrote: > [[[ > Makefile.svn: Make stock SVN binary configurable > > * tools/dev/unix-build/Makefile.svn: Introduce a new variable > $STOCK_SVN that defaults to `env LD_LIBRARY_PATH= svn`. Change > references to `svn export` and `sv

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-08 Thread Daniel Shahaf
Another bug in the baton usage: Daniel Shahaf wrote on Sat, Jan 08, 2011 at 14:00:04 +0200: > Ramkumar Ramachandra wrote on Sat, Jan 08, 2011 at 16:06:01 +0530: > > +/* the default permissions as read from the temp folder */ > > +static volatile apr_fileperms_t default_perms = 0; > > +static volat

Re: [PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > What problem does this fix? I had an issue with my stock SVN picking up the APR libraries I'd just compiled, because LD_LIBRARY_PATH is set in Makefile.svn in several places. Stock SVN (Debian) was compiled with threading support, and the compiled APR was compil

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-08 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sat, Jan 08, 2011 at 16:06:01 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Ping, this doesn't seem to have been fixed yet? > > Thanks for the ping, and sorry about the delay. I think this should > work -- I'll write a commit message if you think this is okay. >

Re: [PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Daniel Shahaf
[ moving stsp to bcc ] What problem does this fix? Ramkumar Ramachandra wrote on Sat, Jan 08, 2011 at 14:33:46 +0530: > [[[ > Makefile.svn: Make stock SVN binary configurable > > * tools/dev/unix-build/Makefile.svn: Introduce a new variable > $STOCK_SVN that defaults to `env LD_LIBRARY_PATH= s

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-08 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ping, this doesn't seem to have been fixed yet? Thanks for the ping, and sorry about the delay. I think this should work -- I'll write a commit message if you think this is okay. Index: subversion/libsvn_subr/io.c ===

[PATCH] Makefile.svn: Make stock SVN executable configurable

2011-01-08 Thread Ramkumar Ramachandra
[[[ Makefile.svn: Make stock SVN binary configurable * tools/dev/unix-build/Makefile.svn: Introduce a new variable $STOCK_SVN that defaults to `env LD_LIBRARY_PATH= svn`. Change references to `svn export` and `svn co` to use $STOCK_SVN. ]]] Index: tools/dev/unix-build/Makefile.svn ===