Re: My take on the diff-optimizations-bytes branch

2011-01-07 Thread Stefan Fuhrmann
On 03.01.2011 02:14, Johan Corveleyn wrote: On Mon, Jan 3, 2011 at 12:13 AM, Johan Corveleyn wrote: On Sun, Jan 2, 2011 at 10:04 PM, Johan Corveleyn wrote: On Sat, Jan 1, 2011 at 11:25 PM, Stefan Fuhrmann wrote: Hi Johan, Thursday night I did something stupid and had a look at how svn bl

Re: My take on the diff-optimizations-bytes branch

2011-01-07 Thread Stefan Fuhrmann
On 03.01.2011 13:16, Johan Corveleyn wrote: On Mon, Jan 3, 2011 at 12:03 PM, Stefan Fuhrmann wrote: On 03.01.2011 02:14, Johan Corveleyn wrote: On Mon, Jan 3, 2011 at 12:13 AM, Johan Corveleyn wrote: [... snip ...] And it's fast too! It's taking only 58 seconds in "diff", vs. 72 for the

Re: svn commit: r966822 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/merge_tests.py

2011-01-07 Thread Paul Burba
On Thu, Aug 12, 2010 at 6:01 PM, Paul Burba wrote: > On Tue, Aug 3, 2010 at 12:40 PM, Paul Burba wrote: >> Ok, I am waving the white flag as far as implementing a fix for issue >> #3657 in the RA layer.  I simply don't see how it can be done outside >> of this:  Put the DAV update report handler

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-07 Thread Danny Trebbien
> Seems to me it would be good for the name of the command-line option to > include "property", e.g. "--prop-source-encoding".  I note that this > option is not intended to be used frequently so I don't imagine it's a > problem to have a long name. How about "--source-prop-encoding"? >> > Index:

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-07 Thread Danny Trebbien
Hi Daniel and Julian, My apologies for the delay in responding. > Refresh my memory please: did we decide in some thread that the > recodings should be counted too? At one point Stefan asked me if I was interested: http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540 >>  

Force Subversion to grab information from Mac OS X keychain

2011-01-07 Thread Kevin Lindeman
Hi, I am running Subversion on Mac OS X. I noticed that once I login correctly for an https subversion URL, it will create a file in ~/.subversion/auth/ that seems to point Subversion to where it stores the authentication - in this case, it has the realmstring, username, "passtype", which is set t

Re: svn commit: r1056468 - in /subversion/trunk: contrib/hook-scripts/remove-zombie-locks.py subversion/include/svn_fs.h subversion/libsvn_fs_base/lock.c

2011-01-07 Thread C. Michael Pilato
On 01/07/2011 02:55 PM, Blair Zajac wrote: > On 01/07/2011 11:33 AM, cmpil...@apache.org wrote: >> Author: cmpilato >> Date: Fri Jan 7 19:33:28 2011 >> New Revision: 1056468 [...] >> + svn_io_file_seek(args.spool_file, APR_SET,&offset, pool); > > Need to handle the error here? [...] >> +

Re: svn commit: r1056468 - in /subversion/trunk: contrib/hook-scripts/remove-zombie-locks.py subversion/include/svn_fs.h subversion/libsvn_fs_base/lock.c

2011-01-07 Thread Blair Zajac
On 01/07/2011 11:33 AM, cmpil...@apache.org wrote: Author: cmpilato Date: Fri Jan 7 19:33:28 2011 New Revision: 1056468 URL: http://svn.apache.org/viewvc?rev=1056468&view=rev Log: Clean up an old bit of API nastiness which prevented implementations of the svn_fs_get_locks_callback_t callback fr

Re: What stands between us and branching 1.7?

2011-01-07 Thread Stefan Sperling
On Fri, Jan 07, 2011 at 10:11:29AM -0500, C. Michael Pilato wrote: > On 01/06/2011 06:32 PM, Stefan Sperling wrote: > > On Thu, Jan 06, 2011 at 03:41:42PM -0500, C. Michael Pilato wrote: > >> WC-NG conflict storage? No... last I heard, we were going to ship with > >> what > >> we have today. > >

Re: [PATCH] support printing changed properties in svnlook

2011-01-07 Thread Daniel Shahaf
I'll add it to my list, but as I'll have to read the whole thing before answering it might take a while until I'll answer. If anyone else wants to beat me to it... Erik Johansson wrote on Thu, Jan 06, 2011 at 22:43:43 +0100: > On Thu, Jan 6, 2011 at 19:15, Daniel Shahaf wrote: > > I can't find

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Prabhu Gnana Sundar
Hi Julian, On Fri, 2011-01-07 at 12:17 +, Julian Foad wrote: > I can't look into this in detail, but I have two thoughts: > > 1. Ideally, I would expect the structure of the diff code to be > something like: > > libsvn_client: > call libsvn_wc to get the WC file; > call libsvn_ra t

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-07 Thread Julian Foad
On Fri, 2011-01-07 at 15:19 +, Philip Martin wrote: > Julian Foad writes: > > > The only case that SQLite doesn't handle automatically is the > > replacement part of "INSERT OR REPLACE INTO ...": it doesn't fire the > > "delete" trigger in that case. > > http://www.sqlite.org/lang_conflict.h

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-07 Thread Philip Martin
Julian Foad writes: > The only case that SQLite doesn't handle automatically is the > replacement part of "INSERT OR REPLACE INTO ...": it doesn't fire the > "delete" trigger in that case. http://www.sqlite.org/lang_conflict.html suggests that you need to enable recursive triggers. I suspect t

Re: What stands between us and branching 1.7?

2011-01-07 Thread C. Michael Pilato
On 01/06/2011 06:32 PM, Stefan Sperling wrote: > On Thu, Jan 06, 2011 at 03:41:42PM -0500, C. Michael Pilato wrote: >> WC-NG conflict storage? No... last I heard, we were going to ship with what >> we have today. > > I think we decided what we have today is fair enough to be released > and then b

[PATCH in progress] Ref-counting for pristine texts

2011-01-07 Thread Julian Foad
I'm implementing ref-counting for pristine texts, with the aim of deleting any text whose ref-count reaches zero. The current situation without this work is that many pristine texts are not deleted when they become unreferenced, and they accumulate in the pristine store until the user runs "svn cl

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Julian Foad
On Fri, 2011-01-07, Prabhu Gnana Sundar wrote: > On Thu, 2011-01-06 at 14:22 +, Julian Foad wrote: > > The tabular format is good but it would be easier to follow if instead > > of "A" or "B" or "C" etc. you write "Shown as diff against source" or > > "Shown as all lines added". > > Thank you

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Julian Foad
On Fri, 2011-01-07 at 15:45 +0530, Prabhu Gnana Sundar wrote: > Hi Julian, > > On Thu, 2011-01-06 at 16:25 +0530, Prabhu Gnana Sundar wrote: > > > > Isn't it a layering violation for libsvn_wc to know about libsvn_ra? > > > Maybe this needs to use callbacks or something, so that all the RA > > >

RE: Windows svnsync test suite failures and a clue

2011-01-07 Thread Bolstridge, Andrew
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: 21 December 2010 22:56 > To: Subversion Development > Subject: Re: Windows svnsync test suite failures and a clue > [snip] > > Being somewhat incredulous that this was the problem, I reinstalled > WLE2011 and sure

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Prabhu Gnana Sundar
Hi Julian, On Thu, 2011-01-06 at 16:25 +0530, Prabhu Gnana Sundar wrote: > > Isn't it a layering violation for libsvn_wc to know about libsvn_ra? > > Maybe this needs to use callbacks or something, so that all the RA > > knowledge remains in libsvn_client. > > > > What you say is correct. :) >

Re: What stands between us and branching 1.7?

2011-01-07 Thread Philip Martin
Stefan Sperling writes: > On Thu, Jan 06, 2011 at 11:20:40PM +, Philip Martin wrote: >> "C. Michael Pilato" writes: >> >> > What, exactly, stands in the way of us branching for 1.7 stabilization? >> >> Performance, particulary on network disks, is still a concern. If this >> requires us