Re: Trouble building trunk: Undefined references to svn_repos_load_fs3() and svn_repos_get_fs_build_parser3()

2010-11-08 Thread Peter Samuelson
[Daniel Trebbien] > I tried your suggestion of removing the subversion and libsvn1 > packages (I'm running Debian Sid) FWIW, the only package you actually had to remove in order to prevent linker interference is libsvn-dev. That has the *.la files, *.so symlinks, etc. that are used at link time.

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-08 Thread Greg Stein
On Thu, Nov 4, 2010 at 08:45, Hyrum K. Wright wrote: > On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: >... >> Having said all that, +1 on removing the gratuitous inconsistency by >> applying this patch. >> >> Committed r1030909. > > Gah.  Can we please wait a little bit longer on this kind of

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 9:09 PM, Chris Tashjian wrote: > > On 11/8/2010 8:54 PM, Paul Burba wrote: >> >> On Mon, Nov 8, 2010 at 8:28 PM, Chris Tashjian  wrote: >>> >>> Paul - 1 more question.  What happens when you run additional blame -g >>> commands?  Does the memory usage keep growing until it r

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 8:17 PM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 1:23 PM, Paul Burba wrote: >> On Mon, Nov 8, 2010 at 10:35 AM, Paul Burba wrote: >>> On Mon, Nov 8, 2010 at 9:13 AM, Paul Burba wrote: On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: > I posted this on th

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Chris Tashjian
On 11/8/2010 8:54 PM, Paul Burba wrote: On Mon, Nov 8, 2010 at 8:28 PM, Chris Tashjian wrote: Paul - 1 more question. What happens when you run additional blame -g commands? Does the memory usage keep growing until it runs out of memory or will it cap itself at some point? In my tests it se

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 8:17 PM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 1:23 PM, Paul Burba wrote: >> On Mon, Nov 8, 2010 at 10:35 AM, Paul Burba wrote: >>> On Mon, Nov 8, 2010 at 9:13 AM, Paul Burba wrote: On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: > I posted this on th

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 1:23 PM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 10:35 AM, Paul Burba wrote: >> On Mon, Nov 8, 2010 at 9:13 AM, Paul Burba wrote: >>> On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: I posted this on the users list, but I'm confident that this is a bug.

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 12:05 PM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 11:20 AM, Julian Foad wrote: >> Here's a patch to fix the Windows buildbot failures that started at my >> r1031610.  The problem is our _quote_arg() function doesn't do the right >> thing with a trailing backslash.  For a

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 10:35 AM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 9:13 AM, Paul Burba wrote: >> On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: >>> I posted this on the users list, but I'm confident that this is a bug. >>> >>> Background: >>> For a while now (off and on for over

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 11:20 AM, Julian Foad wrote: > Here's a patch to fix the Windows buildbot failures that started at my > r1031610.  The problem is our _quote_arg() function doesn't do the right > thing with a trailing backslash.  For a solution it seems better to > simply pass the args separ

Re: [PATCH] error leak on performance branch

2010-11-08 Thread Stefan Sperling
On Mon, Nov 08, 2010 at 06:56:16AM -0600, Hyrum K. Wright wrote: > On Sun, Nov 7, 2010 at 11:58 AM, Stefan Sperling wrote: > > [[[ > > * subversion/libsvn_fs_util/caching.c > >  (svn_fs__get_global_membuffer_cache): Fix a possible error leak. > > ]]] > > > > Index: subversion/libsvn_fs_util/cachin

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-08 Thread Julian Foad
Now with the patch attached. And here's the email thread about the original change r875257 (aka r35183): . On Mon, 2010-11-08 at 16:20 +, Julian Foad wrote: > Here's a patch to fix the Windows buildbot failures that started at my > r1031610.

[PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-08 Thread Julian Foad
Here's a patch to fix the Windows buildbot failures that started at my r1031610. The problem is our _quote_arg() function doesn't do the right thing with a trailing backslash. For a solution it seems better to simply pass the args separately to subprocess.Popen() and let it do the quoting, than t

Re: [PATCH] To improve the documentation of svn_path.h

2010-11-08 Thread Kamesh Jayachandran
[[[ Improved the documentation of deprecated functions by providing links to the deprecating functions. * subversion/include/svn_path.h (svn_path_internal_style, svn_path_local_style, svn_path_join, svn_path_join_many, svn_path_basename, svn_path_dirname, svn_path_split, svn_path_can

RE: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-08 Thread Bolstridge, Andrew
> -Original Message- > From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of Hyrum K. Wright > Sent: 07 November 2010 02:34 > To: Subversion Development > Subject: How to get the message out (or: why there were only 6 people at the ApacheCon meetup) [snip] > My question

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Mon, Nov 8, 2010 at 9:13 AM, Paul Burba wrote: > On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: >> I posted this on the users list, but I'm confident that this is a bug. >> >> Background: >> For a while now (off and on for over a year, but more frequently in the last >> 6+ months) we've

Re: [PATCH] To improve the documentation of svn_path.h

2010-11-08 Thread Arwin Arni
On Monday 08 November 2010 07:57 PM, Arwin Arni wrote: Hi All, I am a new-comer to the Subversion code-base. I was looking at some of the header files (svn_path.h) and wanted to use some of the functions (svn_path_join()) and noticed that they were deprecated. I thought it would be nice to have

[PATCH] To improve the documentation of svn_path.h

2010-11-08 Thread Arwin Arni
Hi All, I am a new-comer to the Subversion code-base. I was looking at some of the header files (svn_path.h) and wanted to use some of the functions (svn_path_join()) and noticed that they were deprecated. I thought it would be nice to have a link to the deprecating functions as a part of the doc

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-08 Thread Paul Burba
On Thu, Nov 4, 2010 at 8:59 PM, Chris Tashjian wrote: > I posted this on the users list, but I'm confident that this is a bug. > > Background: > For a while now (off and on for over a year, but more frequently in the last > 6+ months) we've been having problems with svn "crashing", yet there's no

Re: [PATCH] mailer.py : Use python difflib.unified_diff instead of *nix diff command

2010-11-08 Thread Kamesh Jayachandran
On 11/05/2010 09:45 PM, Noorul Islam K M wrote: [[[ If diff command does not exist on the system then use difflib.unified_diff() to generate diff contents. * tools/hook-scripts/mailer/mailer.py: Fall back to difflib.unified_diff() if the script fails to execute native 'diff' command. Pat

Re: [PATCH] error leak on performance branch

2010-11-08 Thread Hyrum K. Wright
On Sun, Nov 7, 2010 at 11:58 AM, Stefan Sperling wrote: > [[[ > * subversion/libsvn_fs_util/caching.c >  (svn_fs__get_global_membuffer_cache): Fix a possible error leak. > ]]] > > Index: subversion/libsvn_fs_util/caching.c > === > ---

[PATCH] svn-dev.el - Update paths and links

2010-11-08 Thread Noorul Islam K M
Log [[[ Update paths and links * tools/dev/svn-dev.el (svn-site-source-tree-top): Rename svn-source-tree-top as svn-site-source-tree-top as now the web site code resides in a separate location. Update doc string. (svn-faq-file, svn-faq-file, svn-url-base, svn-hacking-url): Update loc

Re: Issue triage: issues 3429 and 3474

2010-11-08 Thread Philip Martin
Johan Corveleyn writes: > Or, maybe the best approach: I could add a regression test for these > issues, so we can all be sure that they are fixed (and remain fixed), > after which they can be marked as fixed. Yes, please. Are there any existing XFAIL tests that apply? They sometimes don't XPA

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-08 Thread Julian Foad
On Sun, 2010-11-07, Stefan Fuhrmann wrote: [...] > Thanks all for the replies. Here is how I see it plus > a couple of things I discovered in the meantime. > > * general consensus: overlapping definitions with >inconsistent meaning are bad. > * enums are always compatible with ints, so we can'

Issue triage: issues 3429 and 3474

2010-11-08 Thread Johan Corveleyn
Hi, I recently verified that the following two issues are fixed on trunk: - #3429: "svn mv A B; svn mv B A" generates replace without history - #3474: making a new subdir, moving files into it and then renaming the subdir, breaks history of the moved files Should I mark these as fixed in the is