Re: [WIP PATCH] Make svn_diff_diff skip identical prefix and suffix to make diff and blame faster

2010-10-08 Thread Julian Foad
On Sat, 2010-10-09, Johan Corveleyn wrote: > Ok, third iteration of the patch in attachment. It passes make check. > > As discussed in [1], this version keeps 50 lines of the identical > suffix around, to give the algorithm a good chance to generate a diff > output of good quality (in all but the

Re: [WIP PATCH] Make svn_diff_diff skip identical prefix and suffix to make diff and blame faster

2010-10-08 Thread Johan Corveleyn
Ok, third iteration of the patch in attachment. It passes make check. As discussed in [1], this version keeps 50 lines of the identical suffix around, to give the algorithm a good chance to generate a diff output of good quality (in all but the most extreme cases, this will be the same as with the

[PATCH] Addition of Win32Svn to packages page

2010-10-08 Thread David Darj
As I now am quite confident that my build of Subversion works and have a working build environment (although it's not near fully automated). I think I should put in a patch to put my site on the "Getting Subversion/Binary packages page" My MSI-packages has been downloaded about 2000 times up t

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Johan Corveleyn
On Fri, Oct 8, 2010 at 10:35 PM, Hyrum K. Wright wrote: > On Fri, Oct 8, 2010 at 3:24 PM, Johan Corveleyn wrote: >> ... >> >> Just one more thing: as I mentioned in my rather long mail, blame >> would benefit the most from my optimization if the server were fast >> enough. So if anyone could spar

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Hyrum K. Wright
On Fri, Oct 8, 2010 at 3:24 PM, Johan Corveleyn wrote: > ... > > Just one more thing: as I mentioned in my rather long mail, blame > would benefit the most from my optimization if the server were fast > enough. So if anyone could spare some review cycles (ok, I know they > are scarce these days),

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Johan Corveleyn
On Fri, Oct 8, 2010 at 3:08 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Fri, 8 Oct 2010 at 01:44 -: >> With suffix-lines-to-keep=50, you'd need to insert a >> block of text that has its last 50 lines identical to the 50 lines >> preceding the insertion point, to mess up the diff result

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Blair Zajac
On 10/08/2010 07:41 AM, Hyrum K. Wright wrote: On Fri, Oct 8, 2010 at 7:06 AM, Bert Huijben wrote: -Original Message- From: style...@apache.org [mailto:style...@apache.org] Sent: vrijdag 8 oktober 2010 13:52 To: comm...@subversion.apache.org Subject: svn commit: r1005788 - /subversion/b

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Hyrum K. Wright
On Thu, Oct 7, 2010 at 6:44 PM, Johan Corveleyn wrote: > Hi all, > > This is a follow-up to the WIP-patches I posted last week [1], which > are about improving performance of svn_diff (and therefor also blame > on the client-side), especially for large files. > > To summarize: the idea was (is) to

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Stefan Sperling
On Fri, Oct 08, 2010 at 07:15:06PM +0200, Stefan Sperling wrote: > On Fri, Oct 08, 2010 at 10:50:13AM -0400, C. Michael Pilato wrote: > > On 10/08/2010 10:41 AM, Hyrum K. Wright wrote: > > > Plus, we haven't really heard much demand for it, anyway. > > > > ...but yeah, is anybody asking for this?

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Stefan Sperling
On Fri, Oct 08, 2010 at 10:50:13AM -0400, C. Michael Pilato wrote: > On 10/08/2010 10:41 AM, Hyrum K. Wright wrote: > > Plus, we haven't really heard much demand for it, anyway. > > ...but yeah, is anybody asking for this? I want it. I think many unix geeks not using gnome or kde would, too. As

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Branko Čibej
On 08.10.2010 16:50, C. Michael Pilato wrote: > On 10/08/2010 10:41 AM, Hyrum K. Wright wrote: >> I dunno. If we get the same ability from Keychain (which is >> guaranteed to be available on OS X, iirc), then adding gpg-agent >> support seems a bit redundant. We then have to answer questions abo

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread C. Michael Pilato
On 10/08/2010 10:41 AM, Hyrum K. Wright wrote: > I dunno. If we get the same ability from Keychain (which is > guaranteed to be available on OS X, iirc), then adding gpg-agent > support seems a bit redundant. We then have to answer questions about > precedence, and possibly add more config, and i

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Mark Phippard
On Fri, Oct 8, 2010 at 10:41 AM, Hyrum K. Wright wrote: > I dunno.  If we get the same ability from Keychain (which is > guaranteed to be available on OS X, iirc), then adding gpg-agent > support seems a bit redundant.  We then have to answer questions about > precedence, and possibly add more co

Re: GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Hyrum K. Wright
On Fri, Oct 8, 2010 at 7:06 AM, Bert Huijben wrote: >> -Original Message- >> From: style...@apache.org [mailto:style...@apache.org] >> Sent: vrijdag 8 oktober 2010 13:52 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1005788 - /subversion/branches/gpg-agent- >> password-stor

Re: [PATCH] fix @deprecated tags in header comments

2010-10-08 Thread C. Michael Pilato
It's on my radar. I'll try to review it today, okay? On 10/07/2010 07:25 PM, Gavin Beau Baumanis wrote: > Ping. This patch has received no comments. > > > Gavin "Beau" Baumanis > > > On 27/09/2010, at 7:23 AM, Dani Church wrote: > >> This patch is a fix for some of the @deprecated tags in th

Re: [RFC] Diff (blame) optimization: how to go forward

2010-10-08 Thread Daniel Shahaf
Johan Corveleyn wrote on Fri, 8 Oct 2010 at 01:44 -: > With suffix-lines-to-keep=50, you'd need to insert a > block of text that has its last 50 lines identical to the 50 lines > preceding the insertion point, to mess up the diff result. > > - If really necessary, we could say default=50, but

Re: [RFC] caret notation enhancement

2010-10-08 Thread Daniel Shahaf
Idea I had once: to have ^-not-followed-by-slash interpreted according to a config file, e.g., % cat ~/.subversion/config [shorthands] svn16 = https://svn.eu.apache.org/repos/asf/subversion/branches/1.6.x % svn info ^svn16/README | grep URL URL: https://svn.eu.apache.org/repos/asf/subversion/branc

Re: [RFC] caret notation enhancement

2010-10-08 Thread Johan Corveleyn
On Fri, Oct 8, 2010 at 2:35 PM, Karl Heinz Marbaise wrote: > Hi Tino, > >>>     svn cp ^^/trunk ^^/tags/RELEASE-1.0.0 -m"- Tagging" >>> >>> The usage of the doubled ^ is just as an example, cause i know >>> on Windows you already have to type the doubled ^ because of the shell. >> >> So what shoul

Re: [RFC] caret notation enhancement

2010-10-08 Thread Karl Heinz Marbaise
Hi Tino, svn cp ^^/trunk ^^/tags/RELEASE-1.0.0 -m"- Tagging" The usage of the doubled ^ is just as an example, cause i know on Windows you already have to type the doubled ^ because of the shell. So what should ^^ (or however it turns out) mean, exactly? It was just an example how it m

GPG support on Windows and OS/X? (Was RE: svn commit: r1005788 - /subversion/branches/gpg-agent-password-store/subversion/libsvn_subr/config_file.c)

2010-10-08 Thread Bert Huijben
> -Original Message- > From: style...@apache.org [mailto:style...@apache.org] > Sent: vrijdag 8 oktober 2010 13:52 > To: comm...@subversion.apache.org > Subject: svn commit: r1005788 - /subversion/branches/gpg-agent- > password-store/subversion/libsvn_subr/config_file.c > > Author: stylese

Re: svn commit: r1005065 - in /subversion/branches/gpg-agent-password-store: ./ build/generator/ subversion/include/ subversion/include/private/ subversion/libsvn_auth_gpg_agent/ subversion/libsvn_sub

2010-10-08 Thread Senthil Kumaran S
Hi Philip, Philip Martin wrote: style...@apache.org writes: Author: stylesen Date: Wed Oct 6 14:41:35 2010 New Revision: 1005065 +static svn_boolean_t +password_get_gpg_agent(const char **password, + apr_hash_t *creds, + const char *realmstring,

Re: svn commit: r1005065 - in /subversion/branches/gpg-agent-password-store: ./ build/generator/ subversion/include/ subversion/include/private/ subversion/libsvn_auth_gpg_agent/ subversion/libsvn_sub

2010-10-08 Thread Senthil Kumaran S
Hi Philip, Thanks for the review. Philip Martin wrote: + + if (socket_name != NULL) +{ + addr.sun_family = AF_UNIX; + strncpy(addr.sun_path, socket_name, 108); + sd = socket(AF_UNIX, SOCK_STREAM, 0); + if (sd == -1) +return FALSE; + + if (connect(sd, (s

Re: svn commit: r1005065 - in /subversion/branches/gpg-agent-password-store: ./ build/generator/ subversion/include/ subversion/include/private/ subversion/libsvn_auth_gpg_agent/ subversion/libsvn_sub

2010-10-08 Thread Senthil Kumaran S
Hi Stefan, Stefan Sperling wrote: On Wed, Oct 06, 2010 at 02:41:35PM -, style...@apache.org wrote: Author: stylesen Date: Wed Oct 6 14:41:35 2010 New Revision: 1005065 URL: http://svn.apache.org/viewvc?rev=1005065&view=rev Log: On the 'gpg-agent-password-store' branch: Add GPG-AGENT supp

Re: svn commit: r1005751 - /subversion/trunk/notes/wc-ng/nodes

2010-10-08 Thread Greg Stein
Can the client issue a delete, and continue if there is a failure? And more importantly, if the server issues a failure, will it continue to accept further changes? IOW, can we send a delete (when we have no definitive knowledge), ignore failures, and continue processing. Will the overall system

Re: [RFC] caret notation enhancement

2010-10-08 Thread Tino Schwarze
Hi Karl Heinz, On Fri, Oct 08, 2010 at 11:25:56AM +0200, Karl Heinz Marbaise wrote: > i've a suggestion about the caret notation which is very handy in daily > work. > > The caret syntax is very helpfull if you're working with a repository > which contains only a single project and of course ma

[RFC] caret notation enhancement

2010-10-08 Thread Karl Heinz Marbaise
Hi to all, i've a suggestion about the caret notation which is very handy in daily work. The caret syntax is very helpfull if you're working with a repository which contains only a single project and of course makes life easier. svn cp ^/trunk ^/tags/RELEASE-1.0.0 -m"- Tagging" But unfo