RE: Performance branch review: single revision changes

2010-09-19 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: zondag 19 september 2010 21:59 > To: Subversion Development > Subject: Performance branch review: single revision changes > > Hi there, > > as per public request, this is a list of smaller changes

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > > Daniel Shahaf writes: > > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > > > 2. If you do duplicat

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
(to stsp and other interested parties: I reviewed only the libsvn_subr part of the patch; see last paragraph for details) Daniel Trebbien wrote on Mon, Sep 13, 2010 at 19:22:38 -0700: > Attached are the new patch and log message. > > I have already shared one test repository with this mailing lis

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > Daniel Shahaf writes: > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > > 2. If you do duplicate code, then add big comments (in all instan

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > +# Mismatched headers during dumping operation > > +mismatched_headers_re = \ > > +"Prop-delta: |Text-content-sha1: |Text-copy-source-md5: |" \ > > +"Text-copy-source-sha1: |Text-delta-base-sha1: .*" > > + > > So: > > * ignore sha1 because RA doesn't

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > +#define SVNRDUMP_PROP_LOCK "rdump-lock" > > Need SVN_PROP_PREFIX. Fixed in r998772. > 1. Please don't duplicate code. > > 2. If you do duplicate code, then add big comments (in all instanc

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 17:53:12 +0530: > Hi, > > I thought this patch might need a little bit of special attention. Let > me know quickly if something is obviously wrong with it- as far as I > know, all tests pass and this patch works as expected. I'm going ahead > and

Re: Tigris : Issue Tracker.

2010-09-19 Thread Gavin Beau Baumanis
Hi Daniel, Thanks for checking, Mark Phippard has corrected my issue with logging into s.t.o. Thanks Mark! Gavin "Beau" Baumanis E: gav...@thespidernet.com On 19/09/2010, at 8:39 PM, Daniel Shahaf wrote: > issues@ archives say one of your accounts is 'gavinbaumanis'. I don't > see another

Re: About SQL backend design

2010-09-19 Thread Jan Horák
Hi, I'm sorry about this, it should be repaired again right now. But as I'm no longer a student at BUT, I've moved all files to my personal web: http://www.wild-web.eu/diplomathesis/ , so you can access all files there. Best Regards Jan Horák E-mail: horak.ho...@gmail.com Dne 19.9.2010 11

Performance branch review: single revision changes

2010-09-19 Thread Stefan Fuhrmann
Hi there, as per public request, this is a list of smaller changes made on the performance branch. Each revision can be reviewed (hopefully) without further context and be merged into trunk independently. * r982335 Limit the amount of unused memory kept in apr_pools to the same amount as every

Performance branch review strategy

2010-09-19 Thread Stefan Fuhrmann
Hi devs, During the Apache Retreat we came up with a plan how to review larger parts of the performance branch, so that these parts may be become part of 1.7. We identified the most promising parts and I will present these patches in a way / grouping that they can be reviewed somewhat easier. In

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Ramkumar Ramachandra
Hi, I've committed this to r998661, but the Subversion bot reports some breakages. I'm not sure what to make of them though. -- Ram

[PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Ramkumar Ramachandra
Hi, I thought this patch might need a little bit of special attention. Let me know quickly if something is obviously wrong with it- as far as I know, all tests pass and this patch works as expected. I'm going ahead and adding lots of tests and fixing whatever bugs there may be shortly. [[[ Add so

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi, Daniel Shahaf writes: > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > 1. Please don't duplicate code. > > > > I think it's fine for svnrdump to have its own copy of this for now. > > We could at some poin

Re: Tigris : Issue Tracker.

2010-09-19 Thread Daniel Shahaf
issues@ archives say one of your accounts is 'gavinbaumanis'. I don't see another accountname there. (I can't login to tigris right now to check, sorry.) Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 09:01:34 +1000: > Hi, > > I haven't has to send a submission to the issue tracker for quite

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Stefan Sperling
On Sun, Sep 19, 2010 at 11:14:02AM +0100, Daniel Shahaf wrote: > Thanks for the reminder. I've been at Hursley this weekend (and haven't > had much time for coding!), but it's on my list. Same here (at Hursely and interested in the patch). Feel free to prod me about it if you don't hear from anyo

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
Gavin, thanks for the information, but I think Daniel Trebbien already knows this. :-) Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000: > Hi Daniel, > > You should always feel comfortable with "pimping" your own patch submissions. > What you have done is completely fine. > > But

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 2)

2010-09-19 Thread Daniel Shahaf
Thanks for the reminder. I've been at Hursley this weekend (and haven't had much time for coding!), but it's on my list. Daniel Trebbien wrote on Sat, Sep 18, 2010 at 21:33:07 +: > It has been a few days since I submitted my revised patch > (http://thread.gmane.org/gmane.comp.version-control.

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > > +static svn_error_t * > > > +get_lock(svn_ra_session_t *session, apr_pool_t *pool) > > > +{ ...

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Stefan Sperling
On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > Author: artagnon > > Date: Sat Sep 18 17:54:50 2010 > > New Revision: 998502 > > > > URL: http://svn.apache.org/viewvc?rev=998502&view=rev > > Log: > > * subversio

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > Author: artagnon > Date: Sat Sep 18 17:54:50 2010 > New Revision: 998502 > > URL: http://svn.apache.org/viewvc?rev=998502&view=rev > Log: > * subversion/svnrdump/load_editor.c: Attempt to acquire a lock of > sorts before attempt

Re: UTF-8 NFC/NFD paths issue

2010-09-19 Thread Daniel Shahaf
Greg Stein wrote on Sat, Sep 18, 2010 at 15:55:57 -0400: > On Sat, Sep 18, 2010 at 04:42, Daniel Shahaf wrote: > > Greg Stein wrote on Fri, Sep 17, 2010 at 07:22:12 -0400: > >> On Thu, Sep 16, 2010 at 19:26, Daniel Shahaf > >> wrote: > >> > Greg Stein wrote on Thu, Sep 16, 2010 at 00:59:59 -0400

Re: Hursley Discussion

2010-09-19 Thread Daniel Shahaf
Hyrum K. Wright wrote on Sat, Sep 18, 2010 at 17:01:00 +0200: > Other items on the agenda which I left before they were discussed: > > * fsfs issues [Daniel Sharaf] > - file handles are used excessively > - corruption issues I can add a bit more information: * fsfs issues [Daniel Shahaf]