Re: svn commit: r997249 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/cl.h svn/main.c svn/patch-cmd.c tests/cmdline/patch_tests.py tests/libsvn_client/client-test.c

2010-09-16 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Sep 15, 2010 at 20:42:55 +0200: > On Wed, Sep 15, 2010 at 04:51:15PM +0200, Daniel Shahaf wrote: > > s...@apache.org wrote on Wed, Sep 15, 2010 at 10:05:15 -: > > > Author: stsp > > > Date: Wed Sep 15 10:05:14 2010 > > > New Revision: 997249 > > > > > > URL: http:

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-16 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Sep 15, 2010 at 21:40:16 +0200: > On Wed, Sep 15, 2010 at 06:15:58PM +0200, Daniel Shahaf wrote: > > Stefan Sperling wrote on Tue, Sep 14, 2010 at 21:18:26 +0200: > > > On Tue, Sep 14, 2010 at 12:49:06PM +0100, Julian Foad wrote: > > > > Right. The issue seems to be "

Re: UTF-8 NFC/NFD paths issue

2010-09-16 Thread Daniel Shahaf
Greg Stein wrote on Thu, Sep 16, 2010 at 00:59:59 -0400: > On Wed, Sep 15, 2010 at 23:35, Daniel Shahaf wrote: > > Erik Huelsmann wrote on Wed, Sep 15, 2010 at 23:20:06 +0200: > >> Yesterday, I was talking to CMike about our long-standing issue with UTF-8 > >> strings designating a certain path no

Re: svn commit: r997905 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

2010-09-16 Thread Philip Martin
Erik Huelsmann writes: > However, the UPDATE_RECURSIVE_BASE_REPO query doesn't take any of that into > account and simply rewrites all repo_ids to be the new repo to relocate to. > That doesn't seem correct though: if other nodes had different repository > sources, those should probably be exclud

Re: svn commit: r997905 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

2010-09-16 Thread Erik Huelsmann
Hi Greg, On Thu, Sep 16, 2010 at 10:47 PM, Erik Huelsmann wrote: > > > On Thu, Sep 16, 2010 at 10:40 PM, Philip Martin < > philip.mar...@wandisco.com> wrote: > >> Erik Huelsmann writes: >> >> > We're now back to a single failure. It's in the relocation-verification >> code >> > in db-test.c (li

svn client has inconsistent returnstatus for non-existing local files

2010-09-16 Thread Sjon Hortensius
LS, Please advise if this is a bug, or a known feature. I have a local checkout on which I can execute svn commands. However, there seems to be some inconsistency in the exitcode of the client. `svn ls repository/non-existing` exits with status 1, and so does `svn info repository/non-existing`. H

Re: svn commit: r997905 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

2010-09-16 Thread Erik Huelsmann
On Thu, Sep 16, 2010 at 10:40 PM, Philip Martin wrote: > Erik Huelsmann writes: > > > We're now back to a single failure. It's in the relocation-verification > code > > in db-test.c (line 1505). With the half-hour I've spent so far, I wasn't > > able to locate it, but I have to move to other busi

Re: svn commit: r997905 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

2010-09-16 Thread Philip Martin
Erik Huelsmann writes: > We're now back to a single failure. It's in the relocation-verification code > in db-test.c (line 1505). With the half-hour I've spent so far, I wasn't > able to locate it, but I have to move to other business now. Hopefully > you'll be able to find it. It's the differen

Re: svn commit: r997905 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

2010-09-16 Thread Erik Huelsmann
Hi Philip, On Thu, Sep 16, 2010 at 10:07 PM, wrote: > Author: ehu > Date: Thu Sep 16 20:07:27 2010 > New Revision: 997905 > > URL: http://svn.apache.org/viewvc?rev=997905&view=rev > Log: > Fix one of two remaining SVN_WC__NODES failures (manifesting itself twice). > > * subversion/tests/libsvn_

Re: Pending 1.6.x backport proposals.

2010-09-16 Thread C. Michael Pilato
On 09/15/2010 04:11 PM, C. Michael Pilato wrote: > I've committed a bunch of changes for issue #3709 and related situations > (r996884, r997026, r997457, r997466, r997471, and r997474). I *do* plan to > propose them for backport to 1.6.x, but that work will have to wait until > tomorrow. Just le

Re: svn commit: r995478 [1/2] - in /subversion/branches/performance: ./ subversion/bindings/javahl/native/ subversion/bindings/javahl/src/org/apache/subversion/javahl/ subversion/bindings/javahl/src/o

2010-09-16 Thread Johan Corveleyn
On Thu, Sep 9, 2010 at 5:59 PM, wrote: > Author: hwright > Date: Thu Sep  9 15:59:00 2010 > New Revision: 995478 > > URL: http://svn.apache.org/viewvc?rev=995478&view=rev > Log: > On the performance branch: > Bring up-to-date with trunk. The performance branch doesn't compile anymore on my machi

Re: svn commit: r997854 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2010-09-16 Thread Philip Martin
"Bert Huijben" writes: >> +-- STMT_UPDATE_COPYFROM_TO_INHERIT_1 >> +UPDATE NODES SET >> + repos_id = null, >> + repos_path = null, >> + revision = null >> +WHERE wc_id = ?1 AND local_relpath = ?2 >> + AND op_depth IN (SELECT op_depth FROM nodes >> + WHERE wc_id = ?1 AND loca

RE: svn commit: r997403 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-09-16 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: donderdag 16 september 2010 19:47 > To: Greg Stein > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r997403 - > /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql > > On Wed, 2010-09-15 at 16

RE: svn commit: r997854 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2010-09-16 Thread Bert Huijben
> -Original Message- > From: phi...@apache.org [mailto:phi...@apache.org] > Sent: donderdag 16 september 2010 19:25 > To: comm...@subversion.apache.org > Subject: svn commit: r997854 - in > /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c > > Author: philip > Date: Thu Sep

Re: svn commit: r997403 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-09-16 Thread Julian Foad
On Wed, 2010-09-15 at 16:17 -0400, Greg Stein wrote: > On Wed, Sep 15, 2010 at 13:19, wrote: > >... > > -- ### A comment on 'repos_id' and 'repos_relpath' says they may be > > null; > > - is this true and wanted? > > Yes. That meant "use the parent's information, and extend it to > com

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread C. Michael Pilato
On 09/16/2010 10:24 AM, Uwe Stuehler wrote: > Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure > > * subversion/libsvn_client/cleanup.c (svn_client_upgrade): Check that > path isn't a URL. r99. Thanks again. -- C. Michael Pilato CollabNet <> www.collab.net

Failing patch_tests.py 27: revert a patch by reverse patching

2010-09-16 Thread Paul Burba
Today in IRC: Bert, pburba do you think a sleep for timestamps is needed to fix patch test 27 on windows? not sure what else could be the problem stsp: Not sure, will try to look in a moment thank you stsp: Not likely.. On NTFS you don't need to sleep for timestamps stsp: You need sleeps

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread Uwe Stuehler
On Thu, Sep 16, 2010 at 3:26 PM, C. Michael Pilato wrote: > On 09/16/2010 08:59 AM, Uwe Stuehler wrote: >> Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure >> >> * subversion/svn/upgrade-cmd.c >> (svn_cl__upgrade): Check that target arguments aren't URLs before >> upgr

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-16 Thread Julian Foad
On Wed, 2010-09-15 at 20:59 +0200, Stefan Sperling wrote: > On Wed, Sep 15, 2010 at 05:12:43PM +0100, Julian Foad wrote: > > > > > + * @since New in 1.7. > > > > > + */ > > > > > +svn_error_t * > > > > > +svn_cstring_strtoi64(apr_int64_t *n, const char *str, > > > > > + apr_int6

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread C. Michael Pilato
On 09/16/2010 08:59 AM, Uwe Stuehler wrote: > Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure > > * subversion/svn/upgrade-cmd.c > (svn_cl__upgrade): Check that target arguments aren't URLs before upgrading. > > * subversion/tests/cmdline/input_validation_tests.py: Ne

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-16 Thread Julian Foad
Stefan Sperling wrote: > Looking at the patch(1) man page, it sounds like we don't really need > to reinvent the wheel here: Phew! - wheels are complex, and the ones we make too often seem to have nails sticking out of them. > patch will choose the file name by performing the following steps

Re: [PATCH] NODES table presence values

2010-09-16 Thread Julian Foad
Greg Stein wrote: > On Wed, Sep 15, 2010 at 13:29, Julian Foad wrote: > > Bert, Erik, Greg... > > > > I think the schema should not disallow the 'excluded' presence in NODES > > table where op_depth > 0 (which corresponds roughly to old > > WORKING_NODE). There are already 'copy' cases where it

[PATCH] issue 3620: svn add ^/ triggers assertion failure

2010-09-16 Thread Uwe Stuehler
This patch adds to the input validation tests a new case to verify that "svn upgrade" rejects URL arguments (instead of crashing) and changes the svn_cl__upgrade() routine to make it so. The change in svn_cl__upgrade() is directly based on Stefan's change to svn_cl__add() in r965551. I've started

Re: svn commit: r997670 - in /subversion/branches/object-model: ./ subversion/bindings/c++/ subversion/tests/libsvn++/

2010-09-16 Thread Hyrum K. Wright
On Thu, Sep 16, 2010 at 12:10 PM, Bert Huijben wrote: > > >> -Original Message- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: donderdag 16 september 2010 12:02 >> To: comm...@subversion.apache.org >> Subject: svn commit: r997670 - in /subversion/branches/object-model: ./

Re: svn commit: r997639 - /subversion/trunk/subversion/include/svn_client.h

2010-09-16 Thread Hyrum Wright
On Thu, Sep 16, 2010 at 12:04 PM, Bert Huijben wrote: > > >> -Original Message- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: donderdag 16 september 2010 10:24 >> To: comm...@subversion.apache.org >> Subject: svn commit: r997639 - >> /subversion/trunk/subversion/include/

RE: svn commit: r997670 - in /subversion/branches/object-model: ./ subversion/bindings/c++/ subversion/tests/libsvn++/

2010-09-16 Thread Bert Huijben
> -Original Message- > From: hwri...@apache.org [mailto:hwri...@apache.org] > Sent: donderdag 16 september 2010 12:02 > To: comm...@subversion.apache.org > Subject: svn commit: r997670 - in /subversion/branches/object-model: ./ > subversion/bindings/c++/ subversion/tests/libsvn++/ > > Au

RE: svn commit: r997639 - /subversion/trunk/subversion/include/svn_client.h

2010-09-16 Thread Bert Huijben
> -Original Message- > From: hwri...@apache.org [mailto:hwri...@apache.org] > Sent: donderdag 16 september 2010 10:24 > To: comm...@subversion.apache.org > Subject: svn commit: r997639 - > /subversion/trunk/subversion/include/svn_client.h > > Author: hwright > Date: Thu Sep 16 08:23:54 2

Re: svn commit: r997639 - /subversion/trunk/subversion/include/svn_client.h

2010-09-16 Thread Hyrum K. Wright
On Thu, Sep 16, 2010 at 11:06 AM, Greg Stein wrote: > On Thu, Sep 16, 2010 at 04:23,   wrote: >> Author: hwright >> Date: Thu Sep 16 08:23:54 2010 >> New Revision: 997639 >> >> URL: http://svn.apache.org/viewvc?rev=997639&view=rev >> Log: >> Attempt to centralize and improve our API documentation,

Re: svn commit: r997639 - /subversion/trunk/subversion/include/svn_client.h

2010-09-16 Thread Greg Stein
On Thu, Sep 16, 2010 at 04:23, wrote: > Author: hwright > Date: Thu Sep 16 08:23:54 2010 > New Revision: 997639 > > URL: http://svn.apache.org/viewvc?rev=997639&view=rev > Log: > Attempt to centralize and improve our API documentation, starting with the > client library.  See mailing list thread