Re: Do we want 'svn patch' to be able to add empty files?

2010-09-01 Thread Daniel Näslund
On Wed, Sep 01, 2010 at 06:37:08PM +0100, Julian Foad wrote: > Daniel Näslund wrote: > > Hi! > > > > (This started out as me trying to apply added paths using the information > > from a patch file in the git diff format. The only that I could come up > > with where an add could not be detected by

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-01 Thread Daniel Näslund
On Wed, Sep 01, 2010 at 10:54:08PM +0300, Daniel Shahaf wrote: > Daniel Näslund wrote on Wed, Sep 01, 2010 at 11:28:51 +0200: > > (This started out as me trying to apply added paths using the information > > from a patch file in the git diff format. The only that I could come up > > with where an a

Re: svn commit: r991619 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit.c libsvn_client/commit_util.c libsvn_client/merge.c libsvn_wc/entries.c libsvn_wc/node.

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 13:44, wrote: >... > +++ subversion/trunk/subversion/include/private/svn_wc_private.h Wed Sep  1 > 17:44:41 2010 > @@ -394,6 +394,7 @@ svn_wc__node_is_status_deleted(svn_boole >                                const char *local_abspath, >                                apr_

Re: svn commit: r991474 - /subversion/trunk/tools/dev/wc-ng/bump-to-19.py

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 04:44, wrote: >... > +++ subversion/trunk/tools/dev/wc-ng/bump-to-19.py Wed Sep  1 08:44:08 2010 >... > +    try: > +      os.remove(db_path(wc_subdir_path)) > +      if os.path.exists(pristine_path(wc_subdir_path)): > +        os.rmdir(pristine_path(wc_subdir_path)) > +  

Re: svn commit: r991642 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 14:34, wrote: > Author: rhuijben > Date: Wed Sep  1 18:34:26 2010 > New Revision: 991642 > > URL: http://svn.apache.org/viewvc?rev=991642&view=rev > Log: > Fix some compatibility with the old entries world that was broken by using > the SINGLE_DB define in wc_db.c. After th

Re: svn commit: r991717 - /subversion/trunk/subversion/libsvn_wc/props.c

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 17:52, wrote: > Author: rhuijben > Date: Wed Sep  1 21:52:45 2010 > New Revision: 991717 > > URL: http://svn.apache.org/viewvc?rev=991717&view=rev > Log: > * subversion/libsvn_wc/props.c >  (load_actual_props): Remove function that only wrapped >    svn_wc__db_read_props.

Re: Obsoleting svn_wc__db_kind_subdir and db_status_obstructed

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 14:00, Julian Foad wrote: > I've disabled svn_wc__db_kind_subdir (#ifdef'd out, except - oops - that > #define isn't active during processing of wc_db.h ...) and some temp > APIs that use it. > > Now it looks like db_status_obstructed{,_*} are totally unref'd and can > go to

Re: WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

2010-09-01 Thread Greg Stein
On Wed, Sep 1, 2010 at 08:22, Julian Foad wrote: > Greg Stein wrote: >> You mean the note sent three whole hours before this >> thread's original post? > > Hi Greg.  We were on a roll!  But I don't like it when people do things > like that to me, and I especially don't like it if someone gives m

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-01 Thread Daniel Shahaf
Daniel Näslund wrote on Wed, Sep 01, 2010 at 11:28:51 +0200: > (This started out as me trying to apply added paths using the information > from a patch file in the git diff format. The only that I could come up > with where an add could not be detected by just looking at the regular > unidiff heade

Obsoleting svn_wc__db_kind_subdir and db_status_obstructed

2010-09-01 Thread Julian Foad
I've disabled svn_wc__db_kind_subdir (#ifdef'd out, except - oops - that #define isn't active during processing of wc_db.h ...) and some temp APIs that use it. Now it looks like db_status_obstructed{,_*} are totally unref'd and can go too. Bert, Greg, sanity check please. Nothing you still want

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-01 Thread Julian Foad
Daniel Näslund wrote: > Hi! > > (This started out as me trying to apply added paths using the information > from a patch file in the git diff format. The only that I could come up > with where an add could not be detected by just looking at the regular > unidiff headers was adding an empty file (

Re: WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

2010-09-01 Thread Julian Foad
Greg Stein wrote: > You mean the note sent three whole hours before this > thread's original post? Hi Greg. We were on a roll! But I don't like it when people do things like that to me, and I especially don't like it if someone gives me a lousy upgrade script and expects me to deal with the co

Do we want 'svn patch' to be able to add empty files?

2010-09-01 Thread Daniel Näslund
Hi! (This started out as me trying to apply added paths using the information from a patch file in the git diff format. The only that I could come up with where an add could not be detected by just looking at the regular unidiff headers was adding an empty file (it has no unidiff headers). If any