Re: svn commit: r982415 - in /subversion/trunk/subversion/libsvn_ra_serf: commit.c replay.c serf.c update.c

2010-08-04 Thread Daniel Shahaf
rhuij...@apache.org wrote on Wed, Aug 04, 2010 at 22:20:30 -: > Author: rhuijben > Date: Wed Aug 4 22:20:30 2010 > New Revision: 982415 > > URL: http://svn.apache.org/viewvc?rev=982415&view=rev > Log: > Following up on r982398, fix a few more mostly theoretical error leaks. > Thanks; review

Re: svn commit: r982057 - in /subversion/branches/performance/subversion/svnserve: main.c server.h

2010-08-04 Thread Johan Corveleyn
On Wed, Aug 4, 2010 at 12:46 AM, wrote: > Author: stefan2 > Date: Tue Aug  3 22:46:10 2010 > New Revision: 982057 > > URL: http://svn.apache.org/viewvc?rev=982057&view=rev > Log: > Add "compression", "memory-cache-size" and "open-file-count" > command line parameters to svnserve. The latter two a

Re: svn commit: r982397 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/deprecated.c libsvn_wc/props.c

2010-08-04 Thread Greg Stein
On Wed, Aug 4, 2010 at 16:45, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Wed Aug  4 20:45:46 > 2010 > @@ -2330,12 +2330,26 @@ svn_wc_props_modified_p(svn_boolean_t *m >                         svn_wc_adm_access_t *adm_access, >                         apr_pool_t *pool)

Re: svn commit: r982375 - in /subversion/branches/performance/subversion: include/svn_io.h libsvn_subr/stream.c

2010-08-04 Thread Hyrum K. Wright
On Wed, Aug 4, 2010 at 2:27 PM, wrote: > Author: stefan2 > Date: Wed Aug  4 19:27:41 2010 > New Revision: 982375 > > URL: http://svn.apache.org/viewvc?rev=982375&view=rev > Log: > Introduce a variant of svn_stream_from_aprfile2, that takes cached file > handles > instead of APR file handles. > >

Re: opening fsfs rev files rw

2010-08-04 Thread Daniel Shahaf
Branko Čibej wrote on Wed, Aug 04, 2010 at 12:20:45 +0200: > I'm assuming "svnadmin pack" deletes obsolete revprop files. Yes, it deletes obsolete rev and revprop files. > Read-only files can be deleted on Unix as long as the containing directory > is read-write. This needs to be tested on Window

Re: [RFC] Incremental dumps and mergeinfo (Was: Vetoing latest issue #3020 fix in 1.6.10)

2010-08-04 Thread C. Michael Pilato
On 08/03/2010 02:35 PM, Paul Burba wrote: > Sweeping through my TODO list turned up this thread. > > I'll commit this last patch tomorrow if there are no objections. None here. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Descri

Re: opening fsfs rev files rw

2010-08-04 Thread Daniel Shahaf
Julian Foad wrote on Wed, Aug 04, 2010 at 11:14:45 +0100: > On Tue, 2010-08-03 at 20:08 +0300, Daniel Shahaf wrote: > > Does anyone see a problem here, or see an error when trying to edit revprops > > with this patch applied? > > I didn't encounter a problem on Ubuntu, in a simple manual test (not

Re: opening fsfs rev files rw

2010-08-04 Thread 'Daniel Shahaf'
Bert Huijben wrote on Tue, Aug 03, 2010 at 17:43:38 +0200: > > -Original Message- > > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > > Sent: dinsdag 3 augustus 2010 17:20 > > To: dev@subversion.apache.org > > Subject: Re: opening fsfs rev files rw > > > > Daniel Shahaf wrote on Tue

Re: fs_fs core dumps in checksum code

2010-08-04 Thread Blair Zajac
On 08/04/2010 05:38 AM, Julian Foad wrote: Hi Blair. I had a look but can't see how this can occur. On Sat, 2010-07-31, Blair Zajac wrote: We run long running, persistent processes that expose the svn_fs and svn_repos APIs via RPC (using ZeroC's Ice). We've seen some occasional core dumps aft

Re: merging into locally added files

2010-08-04 Thread Paul Burba
On Wed, Aug 4, 2010 at 12:14 PM, Julian Foad wrote: > On Wed, 2010-08-04 at 11:23 -0400, Paul Burba wrote: >> On Wed, Aug 4, 2010 at 10:52 AM, Julian Foad >> wrote: >> > Stefan Sperling wrote: >> >> It does not seem possible right now to merge into locally added >> >> files, because the Subversi

Re: merging into locally added files

2010-08-04 Thread Julian Foad
On Wed, 2010-08-04 at 11:23 -0400, Paul Burba wrote: > On Wed, Aug 4, 2010 at 10:52 AM, Julian Foad wrote: > > Stefan Sperling wrote: > >> It does not seem possible right now to merge into locally added > >> files, because the Subversion assumes that the merge target will > >> always have a corres

[PATCH] Test case for exporting externals with native-eol

2010-08-04 Thread vijayaguru
Hi, The attached patch adds a test case for the export of externals(directory/file) with --native-eol option. [[[ Log: Export of externals(directory/file) with `--native-eol' option was added in r966747 and r981757. * subversion/tests/cmdline/export_tests.py (export_externals_with_nati

Re: merging into locally added files

2010-08-04 Thread Paul Burba
On Wed, Aug 4, 2010 at 10:29 AM, Stefan Sperling wrote: > I haven't run make check yet either, in fear that lots of merge > tests will just start to fail on me when I try. I forget to mention in my earlier response, I ran [ra_serf] x [merge_tests.py | merge_reintegrate_tests.py | merge_tree_conf

Re: merging into locally added files

2010-08-04 Thread Paul Burba
On Wed, Aug 4, 2010 at 10:52 AM, Julian Foad wrote: > Stefan Sperling wrote: >> It does not seem possible right now to merge into locally added >> files, because the Subversion assumes that the merge target will >> always have a corresponding URL in the repository, and errors out. >> >> With a bit

Re: svn commit: r982275 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-08-04 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 02:56:42PM -, rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Aug 4 14:56:41 2010 > New Revision: 982275 > > URL: http://svn.apache.org/viewvc?rev=982275&view=rev > Log: > * subversion/libsvn_wc/wc_db.c > (set_new_dir_to_incomplete_baton_txn): Following up

Re: merging into locally added files

2010-08-04 Thread Julian Foad
Stefan Sperling wrote: > It does not seem possible right now to merge into locally added > files, because the Subversion assumes that the merge target will > always have a corresponding URL in the repository, and errors out. > > With a bit of special-casing during error handling in a few places, >

merging into locally added files

2010-08-04 Thread Stefan Sperling
While trying to improve input validation in svn merge, I stumbled across an apparently unsupported use case. It does not seem possible right now to merge into locally added files, because the Subversion assumes that the merge target will always have a corresponding URL in the repository, and error

Re: fs_fs core dumps in checksum code

2010-08-04 Thread Julian Foad
Hi Blair. I had a look but can't see how this can occur. On Sat, 2010-07-31, Blair Zajac wrote: > We run long running, persistent processes that expose the svn_fs and > svn_repos > APIs via RPC (using ZeroC's Ice). We've seen some occasional core dumps > after > the processes have been up fo

Re: svn commit: r981905 - /subversion/trunk/subversion/tests/cmdline/depth_tests.py

2010-08-04 Thread Julian Foad
Philip Martin wrote: > Greg Stein writes: > > On Tue, Aug 3, 2010 at 13:41, Julian Foad wrote: > >> Greg Stein wrote: > >>> Why would this be true only in single-db? Shouldn't the test perform > >>> exactly the same in both cases? I see no rationale for WHY these > >>> should differ. > >>> > >>>

Re: svn commit: r981905 - /subversion/trunk/subversion/tests/cmdline/depth_tests.py

2010-08-04 Thread Philip Martin
Greg Stein writes: > On Tue, Aug 3, 2010 at 13:41, Julian Foad wrote: >> Greg Stein wrote: >>> Why would this be true only in single-db? Shouldn't the test perform >>> exactly the same in both cases? I see no rationale for WHY these >>> should differ. >>> >>> On Tue, Aug 3, 2010 at 10:56,   wrot

Re: svn commit: r982173 - /subversion/trunk/subversion/svn/log-cmd.c

2010-08-04 Thread Stefan Sperling
On Wed, Aug 04, 2010 at 09:21:16AM -, rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Aug 4 09:21:13 2010 > New Revision: 982173 > > URL: http://svn.apache.org/viewvc?rev=982173&view=rev > Log: > * subversion/svn/log-cmd.c > (svn_cl__log): Check for paths starting with a '/' inste

Re: opening fsfs rev files rw

2010-08-04 Thread Branko Čibej
On 04.08.2010 12:14, Julian Foad wrote: > On Tue, 2010-08-03 at 20:08 +0300, Daniel Shahaf wrote: > >> Julian Foad wrote on Tue, Aug 03, 2010 at 17:36:00 +0100: >> >>> On Tue, 2010-08-03 at 18:19 +0300, Daniel Shahaf wrote: >>> Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:3

Re: opening fsfs rev files rw

2010-08-04 Thread Julian Foad
On Tue, 2010-08-03 at 20:08 +0300, Daniel Shahaf wrote: > Julian Foad wrote on Tue, Aug 03, 2010 at 17:36:00 +0100: > > On Tue, 2010-08-03 at 18:19 +0300, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:32 +0300: > > > > There was yesterday on IRC [1] some discussion ar

RE: Need fast ways to get Info once WC-NG is introduced

2010-08-04 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: maandag 2 augustus 2010 21:52 > To: Bert Huijben > Cc: 'Subversion Development' > Subject: Re: Need fast ways to get Info once WC-NG is introduced > > On 02.08.2010 12:32, Bert Huijben wrote: > > > I don't t

RE: NODE_DATA (2nd iteration)

2010-08-04 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: dinsdag 3 augustus 2010 15:19 > To: Erik Huelsmann > Cc: dev > Subject: Re: NODE_DATA (2nd iteration) > > TABLE NODE_DATA ( > > wc_id INTEGER NOT NULL REFERENCES WCROOT (id), > > local_relpath TEXT N

RE: Mergeinfo not inherited due to file externals

2010-08-04 Thread Bert Huijben
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: dinsdag 3 augustus 2010 22:50 > To: Brandt, Servatius (External) > Cc: Subversion Development List > Subject: Re: Mergeinfo not inherited due to file externals > > On Mon, Jul 26, 2010 at 4:50 AM, Brandt, Servatiu

RE: opening fsfs rev files rw

2010-08-04 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: dinsdag 3 augustus 2010 17:20 > To: dev@subversion.apache.org > Subject: Re: opening fsfs rev files rw > > Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:32 +0300: > > There was yesterday on IRC [1] some

Re: [RFC] Incremental dumps and mergeinfo (Was: Vetoing latest issue #3020 fix in 1.6.10)

2010-08-04 Thread Julian Foad
On Tue, 2010-08-03 at 14:35 -0400, Paul Burba wrote: > Sweeping through my TODO list turned up this thread. > > I'll commit this last patch tomorrow if there are no objections. No objections to this improvement from me. - Julian > I pause a day only because I recall Mike saying he was planning