Hi Stefan!
Do you think the attached patch looks reasonable, e.g. it does not
interfer with the overall design of 'svn patch'? It's not fun to review
a patch that touches on so many parts. Sorry 'bout that. Find below some
specific questions.
The patch code consist of four steps:
1) match text i
Greg Stein writes:
> This is just scattering them around, rather than thinking about where
> they should go.
>
> Basically, reset as soon as possible after pulling column values. That
> means after the assignment of "levels", where column_int() is called,
> and then in an else branch of the got_r
Greg Stein writes:
> Yes, svn_sqlite__update() *does* reset the statement before returning
> (it isn't something where you can iterate over results; it is done; so
> it resets the statement).
>
> Thus, the extra reset should not be there. "Following the pattern"
> isn't right here.
Ah, I didn't
This is just scattering them around, rather than thinking about where
they should go.
Basically, reset as soon as possible after pulling column values. That
means after the assignment of "levels", where column_int() is called,
and then in an else branch of the got_row test.
Thus, a reset isn't ne
Yes, svn_sqlite__update() *does* reset the statement before returning
(it isn't something where you can iterate over results; it is done; so
it resets the statement).
Thus, the extra reset should not be there. "Following the pattern"
isn't right here.
On Fri, Jul 16, 2010 at 13:44, Philip Martin
> -Original Message-
> From: style...@apache.org [mailto:style...@apache.org]
> Sent: vrijdag 16 juli 2010 13:34
> To: comm...@subversion.apache.org
> Subject: svn commit: r964772 - /subversion/branches/1.6.x/STATUS
>
> Author: stylesen
> Date: Fri Jul 16 11:34:25 2010
> New Revision: 96
Bert Huijben writes:
> Doesn't _update handle this specific reset? If not I think it should.
The compiler was complaing about a missing argument to
svn_error_createf. I was just following the pattern used by next
function.
>if (affected_rows != 1)
> return svn_error_createf(SVN_ERR_WC
Doesn't _update handle this specific reset? If not I think it should.
Bert Huijben (mobile phone)
- Oorspronkelijk bericht -
Van: phi...@apache.org
Verzonden: vrijdag 16 juli 2010 9:57
Aan: comm...@subversion.apache.org
Onderwerp: svn commit: r964704 - /subversion/trunk/subversion/libsvn_
On Fri, Jul 16, 2010 at 12:16:48PM +0200, Stefan Sperling wrote:
> This crash below happens reliably during
> svn co https://svn.apache.org/repos/asf/subversion/trunk
> somewhere in the middle of the checkout (not always at the same spot):
Filed as http://subversion.tigris.org/issues/show_bug.cgi
Just for the record, I still can't use ra_serf, with serf from the
0.6.x branch.
$ head CHANGES
Serf 0.6.2
Fix double free abort when destroying request buckets.
Fix test server in unit test framework to avoid random test failures.
I'd like to switch t
10 matches
Mail list logo
