Re: CollabNet links in packages.html

2010-07-09 Thread Julian Foad
Mark Phippard wrote: > On Fri, Jul 9, 2010 at 3:06 PM, Peter Samuelson wrote: > > > A user on IRC seemed to be confused at the lack of Windows binaries > > from tigris.org, a link we recently removed. Now the first link on the > > list of Windows binaries is CollabNet, but registration is requir

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Greg Hudson
On Fri, 2010-07-09 at 12:45 -0400, Stefan Sperling wrote: > It's the older Windows systems that will still have problems, > and I don't think we should be ignoring them (as much as I'd love > it if everyone just ditched Windows for good). Is this really a concern on Windows systems? This is basic

Re: CollabNet links in packages.html

2010-07-09 Thread Mark Phippard
On Fri, Jul 9, 2010 at 3:06 PM, Peter Samuelson wrote: > A user on IRC seemed to be confused at the lack of Windows binaries > from tigris.org, a link we recently removed.  Now the first link on the > list of Windows binaries is CollabNet, but registration is required in > order to download them.

CollabNet links in packages.html

2010-07-09 Thread Peter Samuelson
A user on IRC seemed to be confused at the lack of Windows binaries from tigris.org, a link we recently removed. Now the first link on the list of Windows binaries is CollabNet, but registration is required in order to download them. Greg and I think we should add "(registration required)" tags

Re: [PATCH] Add svnrdump

2010-07-09 Thread Junio C Hamano
Michael J Gruber writes: > Blair Zajac venit, vidit, dixit 09.07.2010 02:42: >> On 07/08/2010 01:17 AM, Daniel Shahaf wrote: >>> @Bert: could you please trim quoted patches to only the relevant parts? >>> Scrolling is tedious when I don't have have line folding available... >> >> +1 on this, in

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 11:40:59AM -0500, Peter Samuelson wrote: > > [Stefan Sperling] > > "Before the SO_EXCLUSIVEADDRUSE socket option was introduced, there was > > very little a network application developer could do to prevent a > > malicious program from binding to the port on which the netwo

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Peter Samuelson
[Stefan Sperling] > "Before the SO_EXCLUSIVEADDRUSE socket option was introduced, there was > very little a network application developer could do to prevent a > malicious program from binding to the port on which the network > application had its own sockets bound." > > So not using SO_EXCLUSIVE

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 12:05:47PM -0400, Greg Hudson wrote: > On Fri, 2010-07-09 at 11:44 -0400, Stefan Sperling wrote: > > As far as I can tell there is little we can do to secure svnserve > > against this attack on Windows systems other than Server 2003, > > because APR won't let us set the SO_E

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Peter Samuelson
[Greg Hudson] > That's okay, we don't want the SO_EXCLUSIVEADDR behavior. We want the > default behavior under Windows, which corresponds to the SO_REUSEADDR > behavior under Unix. Well, the attack Stefan is referring to is if a third-party app (aka virus) tries to bind with SO_REUSEADDR. Prior

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Greg Hudson
On Fri, 2010-07-09 at 11:44 -0400, Stefan Sperling wrote: > As far as I can tell there is little we can do to secure svnserve > against this attack on Windows systems other than Server 2003, > because APR won't let us set the SO_EXCLUSIVEADDR option. That's okay, we don't want the SO_EXCLUSIVEADDR

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 09:36:05AM -0500, Peter Samuelson wrote: > > [Stefan Sperling] > > This doesn't make any sense. > > I don't understand how an OS can allow a user process to break > > a system service simply by binding a socket to the same port. > > And yet ... http://msdn.microsoft.com/en

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Peter Samuelson
[Stefan Sperling] > This doesn't make any sense. > I don't understand how an OS can allow a user process to break > a system service simply by binding a socket to the same port. And yet ... http://msdn.microsoft.com/en-us/library/ms740621%28VS.85%29.aspx Once the second socket has successful

[PATCH v2] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi, Along with the changes suggested by Bert and Daniel, this new version includes a few small bugfixes and feature additions contributed by David and Will, among others. Unfortunately, a diff of the changes made is not available due to whitespace/ style conversion issues: please check the recent

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi, Ramkumar Ramachandra writes: > Where is svn_dirent_basename defined? I can't seem to find it in the > codebase at all. np, I found it. It's svn_relpath_basename. -- Ram

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi, Bert Huijben writes: > > + /* Cleanup */ > > + SVN_ERR(svn_io_file_close(hb->temp_file, hb->pool)); > > + SVN_ERR(svn_stream_close(hb->temp_filestream)); > > The standard handler already closes the stream for you and if you don't > disown the file on mapping, this also closes the file. >

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > > + /* Use a temporary file to measure the text-content-length */ > > > + apr_err = apr_temp_dir_get(&tempdir, hb->pool); > > svn_io_temp_dir() Fixed. > > > + if (apr_err != APR_SUCCESS) > > > +SVN_ERR(svn_error_wrap_apr(apr_err, NULL)); > > > + > > >

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi Bert, Thank you for the review. Bert Huijben writes: > > +svn_error_t *open_root(void *edit_baton, > > + svn_revnum_t base_revision, > > + apr_pool_t *pool, > > + void **root_baton) > > Static and the return type on its own lin

Re: How to migrate to Single DB per WC

2010-07-09 Thread Julian Foad
On Thu, 2010-07-08 at 13:24 -0400, Greg Stein wrote: > On Thu, Jul 8, 2010 at 12:33, Julian Foad wrote: > >... > > The auto-upgrade code, currently used for 1.7-dev to 1.7-dev, is invoked > > when opening a versioned directory: > >... > > So a possible way is: > > > > * bump_to_19() needs to migr

Re: [PATCH] Add svnrdump

2010-07-09 Thread Sverre Rabbelier
Heya, On Fri, Jul 9, 2010 at 03:16, Michael J Gruber wrote: > In fact, on the git list we tend to trim as little as possible. Huh? Quite the opposite I thought... -- Cheers, Sverre Rabbelier

Re: Slow execution with needs lock property

2010-07-09 Thread C. Michael Pilato
On 07/09/2010 07:40 AM, Philip Martin wrote: > Senthil Kumaran S writes: > >> In a repository that contains a large number of files and folders >> (over 100K), many of which have the needs-lock property set, If any >> user attempts to check out this entire repository, the large number of >> locks

Re: Slow execution with needs lock property

2010-07-09 Thread Philip Martin
Senthil Kumaran S writes: > In a repository that contains a large number of files and folders > (over 100K), many of which have the needs-lock property set, If any > user attempts to check out this entire repository, the large number of > locks created on the server > render the server almost unu

Re: Non-matching revision arguments in the diff code

2010-07-09 Thread Julian Foad
On Fri, 2010-07-09 at 09:52 +0200, Daniel Näslund wrote: > Hi! > > The diff callbacks for handling text have revision arguments. The prop > callbacks don't. > > I'm creating diff headers for the cases when we only have property > changes. When creating those diff headers I need revisions. Since t

Re: 'svn patch' issue

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 12:52:24PM +0300, Daniel Shahaf wrote: > # no changes between 'diff' and 'patch', so hope for idempotency: > # for 'patch' to realize the patch is applied and does nothing. Now I understand. We don't check for already applied patches right now. Your patch matches with fuzz

Re: Slow execution with needs lock property

2010-07-09 Thread Senthil Kumaran S
Senthil Kumaran S wrote: Following are my findings, With svn 1.6.9, in the working copy, $ time /usr/sbin/svn ls . > /tmp/ls.txt real0m5.745s user0m4.281s sys0m1.653s $ tail /tmp/ls.txt test0.txt test1.txt test2.txt test3.txt test4.txt test5.txt test6.t

Re: 'svn patch' issue

2010-07-09 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, 9 Jul 2010 at 11:43 +0200: > On Fri, Jul 09, 2010 at 12:47:05AM +0300, Daniel Shahaf wrote: > > Working on #3641. I had a changelist containing svnsync_tests.py, two > > dumpfiles (for the test), and libsvn_repos/replay.c. > > > > I saved a diff of the whole CL as .

Re: Bug: svnserve fail to detect it is already running

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 06:25:20AM +, Lorenz wrote: > just checked, and no there is no error message. > Instead the newly started server blocks / hides the allready running > one. > In my case I have one server running as a windows service, serving a > repo from a folder on my C: drive. > If I

Re: 'svn patch' issue

2010-07-09 Thread Stefan Sperling
On Fri, Jul 09, 2010 at 12:47:05AM +0300, Daniel Shahaf wrote: > Working on #3641. I had a changelist containing svnsync_tests.py, two > dumpfiles (for the test), and libsvn_repos/replay.c. > > I saved a diff of the whole CL as ../i3.diff. > > I 'svn revert'ed replay.c and rebuilt. > > I then

Re: svn commit: r961756 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

2010-07-09 Thread Philip Martin
rhuij...@apache.org writes: > Author: rhuijben > Date: Thu Jul 8 13:13:52 2010 > New Revision: 961756 > > URL: http://svn.apache.org/viewvc?rev=961756&view=rev > Log: > * subversion/tests/cmdline/copy_tests.py > (move_dir_containing_file): Following up on r961397, enable status call > in te

Re: [PATCH] Add svnrdump

2010-07-09 Thread Michael J Gruber
Blair Zajac venit, vidit, dixit 09.07.2010 02:42: > On 07/08/2010 01:17 AM, Daniel Shahaf wrote: >> @Bert: could you please trim quoted patches to only the relevant parts? >> Scrolling is tedious when I don't have have line folding available... > > +1 on this, in Thunderbird, it took a while to sc

Non-matching revision arguments in the diff code

2010-07-09 Thread Daniel Näslund
Hi! The diff callbacks for handling text have revision arguments. The prop callbacks don't. I'm creating diff headers for the cases when we only have property changes. When creating those diff headers I need revisions. Since the prop diff callback doesn't have revision arguments I'm using the rev

Slow execution with needs lock property

2010-07-09 Thread Senthil Kumaran S
Hi, In a repository that contains a large number of files and folders (over 100K), many of which have the needs-lock property set, If any user attempts to check out this entire repository, the large number of locks created on the server render the server almost unusable due to high load and cau