Progress report for GSoC 'svn patch' project

2010-06-17 Thread Daniel Näslund
Hi! The goal is to be able to create, parse and apply diffs in the 'git unidiff' format. The original thought was to add support for property diffs when the basic parts of the 'git unidiff' part was in place, but Stefan suggested that we could easily add property diffs even without the git parts.

Re: status information

2010-06-17 Thread Greg Stein
On Thu, Jun 17, 2010 at 16:48, Stefan Küng wrote: > On 17.06.2010 22:35, Bert Huijben wrote: >>> Sure, I said before I can get any information myself, but only with >>> a severe performance hit. Because every time I call an svn_client_* >>> API, it walks the whole tree again, opens the files again

Re: 1.6.12 tarballs up for signing / testing

2010-06-17 Thread Philip M. Gollucci
On 6/17/2010 8:37 PM, Hyrum K. Wright wrote: > 1.6.12 tarballs are up for testing and signing. The magic revision is > r955767: > http://people.apache.org/~hwright/svn/1.6.12/ > > As usual, signatures from full committers please send back to me. > Testing by enthusiastic users is also welcomed (

1.6.12 tarballs up for signing / testing

2010-06-17 Thread Hyrum K. Wright
1.6.12 tarballs are up for testing and signing. The magic revision is r955767: http://people.apache.org/~hwright/svn/1.6.12/ As usual, signatures from full committers please send back to me. Testing by enthusiastic users is also welcomed (but remember that this is not yet a blessed release, with

Re: status information

2010-06-17 Thread Hyrum K. Wright
On Thu, Jun 17, 2010 at 3:35 PM, C. Michael Pilato wrote: > Stefan Küng wrote: >> So for me, 1.7 doesn't look like an improvement at all, no matter how >> great WC-NG will get. There aren't any new features in it (yet) which I >> haven't already used in 1.6, but I have to drop more and more existi

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread Johan Corveleyn
On Thu, Jun 17, 2010 at 5:54 PM, C. Michael Pilato wrote: > Julian Foad wrote: >> My recommendation:  Let's strive for compatibility where we can, and >> where the old behaviour is reasonable.  I think a 6-character minimum >> column width is reasonable for most purposes, even though it's not the

Re: status information

2010-06-17 Thread Stefan Küng
On 17.06.2010 22:35, Bert Huijben wrote: Sure, I said before I can get any information myself, but only with a severe performance hit. Because every time I call an svn_client_* API, it walks the whole tree again, opens the files again, opens the db again and again, ... svn_client doesn't open

Re: status information

2010-06-17 Thread C. Michael Pilato
Stefan Küng wrote: > So for me, 1.7 doesn't look like an improvement at all, no matter how > great WC-NG will get. There aren't any new features in it (yet) which I > haven't already used in 1.6, but I have to drop more and more existing > features. > > And from your comments I get the impression

RE: status information

2010-06-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: donderdag 17 juni 2010 22:28 > To: Bert Huijben > Cc: 'C. Michael Pilato'; 'Subversion Development' > Subject: Re: status information > > On 17.06.2010 22:08, Bert Huijben wrote: > > >> May I suggest an appr

Re: status information

2010-06-17 Thread Stefan Küng
On 17.06.2010 22:08, Bert Huijben wrote: May I suggest an approach that doesn't force me to find expensive workarounds for more and more missing information the svn APIs return: Use a mask parameter which specifies which members of a returned struct get filled in by the API and which ones are no

RE: status information

2010-06-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: donderdag 17 juni 2010 20:55 > To: C. Michael Pilato > Cc: Bert Huijben; 'Subversion Development' > Subject: Re: status information > > On 17.06.2010 17:52, C. Michael Pilato wrote: > > Bert Huijben wrote: > >>

Re: svn commit: r955708 - /subversion/trunk/subversion/svnadmin/main.c

2010-06-17 Thread Hyrum K. Wright
On Thu, Jun 17, 2010 at 2:01 PM, C. Michael Pilato wrote: >> @@ -1184,18 +1180,19 @@ set_revprop(const char *prop_name, const >>    if (opt_state->use_pre_revprop_change_hook || >>        opt_state->use_post_revprop_change_hook) >>      { >> -      SVN_ERR(svn_repos_fs_change_rev_prop3 >> -      

Re: svn commit: r955708 - /subversion/trunk/subversion/svnadmin/main.c

2010-06-17 Thread C. Michael Pilato
> @@ -1184,18 +1180,19 @@ set_revprop(const char *prop_name, const >if (opt_state->use_pre_revprop_change_hook || >opt_state->use_post_revprop_change_hook) > { > - SVN_ERR(svn_repos_fs_change_rev_prop3 > - (repos, opt_state->start_revision.value.number, > -

Re: status information

2010-06-17 Thread Stefan Küng
On 17.06.2010 17:52, C. Michael Pilato wrote: Bert Huijben wrote: Most simple clients can just use svn_client_status5() and trust the results to be complete like they were used to, but more advanced clients can use svn_wc_walk_status() to get higher performance. E.g. If TortoiseSVN or AnkhSVN s

Re: [PATCH] Fix filename encoding error in svn_io_open_unique_file3()

2010-06-17 Thread Philip Martin
Julian Foad writes: > How can I easily test this in my Ubuntu UTF-8 environment? I think you can do it in an 8-bit non-utf8 locale: $ sudo dpkg-reconfigure locales # select en_GB.8859-15 $ LANG=en_GB.8859-15 ./executable -- Philip

[PATCH] Fix filename encoding error in svn_io_open_unique_file3()

2010-06-17 Thread Julian Foad
I spotted a filename encoding error when using "delete on pool cleanup" with svn_io_open_unique_file3(). I have not tested this, but I believe this bug would fail to clean up the temp file if the UTF-8 encoding of the directory path differs from its APR encoding. How can I easily test this in my

Re: revprop changes and hooks

2010-06-17 Thread Daniel Shahaf
[ summary: a question about the ra_dav protocol ] Daniel Shahaf wrote on Thu, 17 Jun 2010 at 16:21 +0300: > Philip Martin wrote on Thu, 17 Jun 2010 at 12:18 -: > > Daniel Shahaf writes: > > > But I wonder if, while here, we could go further and obtain the > > > "expected old property value" f

RE: Hot-backup.py won't create zipfiles bigger than 2GB

2010-06-17 Thread Daniel Shahaf
Donald Gordon wrote on Thu, 17 Jun 2010 at 08:49 +1200: > Hi > > > > > Here's a patch to hot-backup, then. > > Donald, this mailing list unfortunately strips off some kinds of > > attachments. Please try attaching as plain text, or even paste in-line > > text if it's a very small patch. > > Atta

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread C. Michael Pilato
Julian Foad wrote: > My recommendation: Let's strive for compatibility where we can, and > where the old behaviour is reasonable. I think a 6-character minimum > column width is reasonable for most purposes, even though it's not the > purest design. +1 -- C. Michael Pilato CollabNet <> ww

Re: status information

2010-06-17 Thread C. Michael Pilato
Bert Huijben wrote: > Most simple clients can just use svn_client_status5() and trust the results > to be complete like they were used to, but more advanced clients can use > svn_wc_walk_status() to get higher performance. > > E.g. If TortoiseSVN or AnkhSVN switched to the wc apis, they can just

Re: [PATCH] Extend the test for "svnadmin hotcopy" copying symlinks

2010-06-17 Thread Julian Foad
On Wed, 2010-06-16, I (Julian Foad) wrote: > In testing for back-port to 1.6.x, I wanted a more thorough test, so > here it is. Committed revision 955605. - Julian > [[[ > Extend the test for "svnadmin hotcopy" copying symlinks. Ensure that the > result is a symlink and not just a copy of the

Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

2010-06-17 Thread Daniel Shahaf
Julian Foad wrote on Thu, 17 Jun 2010 at 14:53 +0100: > On Wed, 2010-06-16, C. Michael Pilato wrote: > > If we decide that we need to rev this API, though, then let's do the sane > > (Did you mean "rev this API" or merely "change it in any way"?) > > > thing and teach the function to return *all*

Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

2010-06-17 Thread Julian Foad
On Wed, 2010-06-16, C. Michael Pilato wrote: > Julian Foad wrote: > > Previously, svn_io_dir_walk() reported only files and dirs. With this > > change it reports symlinks in the same way that it reports files (even > > if they point to a directory). > > The function has always reported files and

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread Julian Foad
On Thu, 2010-06-17, Johan Corveleyn wrote: > Please find in attachment my (very first) patch addressing the issue > discussed in [1] and [2]. > > Log message (maybe a bit too verbose ...): This amount of detail is fine. > [[[ > Fix alignment of blame output containing revision numbers >= 100

Re: revprop changes and hooks

2010-06-17 Thread Daniel Shahaf
Philip Martin wrote on Thu, 17 Jun 2010 at 12:18 -: > Daniel Shahaf writes: > > > Philip Martin wrote on Tue, 15 Jun 2010 at 11:16 -: > > > >> Then the repos layer can loop (in practice only if the > >> use_pre_revprop_change_hook flag is set): > >> > >>do > >> svn_fs_re

Re: svn commit: r955551 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/cmdline/copy_tests.py

2010-06-17 Thread Philip Martin
"Hyrum K. Wright" writes: > Wrong log message? Yes, fixed. -- Philip

Re: javahl compatibility question

2010-06-17 Thread Mark Phippard
On Thu, Jun 17, 2010 at 8:22 AM, Hyrum K. Wright wrote: > On Thu, Jun 17, 2010 at 4:16 AM,   wrote: >> Hello, >> >> I am developing a Java program that uses the javahl jar file. What I don't >> understand however is if it is safe to use one version of javahl (say >> 1.6.11) with a repository of SV

Re: svn commit: r955551 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/cmdline/copy_tests.py

2010-06-17 Thread Hyrum K. Wright
Wrong log message? On Thu, Jun 17, 2010 at 5:58 AM, wrote: > Author: philip > Date: Thu Jun 17 10:58:55 2010 > New Revision: 91 > > URL: http://svn.apache.org/viewvc?rev=91&view=rev > Log: > * subversion/libsvn_wc/adm_ops.c (svn_wc_add4): Remove unused variable. > > Modified: >    subver

Re: javahl compatibility question

2010-06-17 Thread Hyrum K. Wright
On Thu, Jun 17, 2010 at 4:16 AM, wrote: > Hello, > > I am developing a Java program that uses the javahl jar file. What I don't > understand however is if it is safe to use one version of javahl (say > 1.6.11) with a repository of SVN server 1.5.x. I am a bit afraid of > introducing errors into t

Re: status information

2010-06-17 Thread Stefan Küng
On Thu, Jun 17, 2010 at 11:49, Bert Huijben wrote: > > >> -Original Message- >> From: Stefan Küng [mailto:tortoise...@gmail.com] >> Sent: woensdag 16 juni 2010 22:14 >> To: Bert Huijben; Subversion Development >> Subject: Re: status information >> >> On 16.06.2010 21:40, Bert Huijben wrote

RE: status information

2010-06-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: woensdag 16 juni 2010 22:14 > To: Bert Huijben; Subversion Development > Subject: Re: status information > > On 16.06.2010 21:40, Bert Huijben wrote: > > > The plan is to remove even more expensive members f

javahl compatibility question

2010-06-17 Thread mruhrbach
Hello, I am developing a Java program that uses the javahl jar file. What I don't understand however is if it is safe to use one version of javahl (say 1.6.11) with a repository of SVN server 1.5.x. I am a bit afraid of introducing errors into the SVN repository that will not show up immediat

Re: revprop changes and hooks

2010-06-17 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Tue, 15 Jun 2010 at 11:16 -: > >> Then the repos layer can loop (in practice only if the >> use_pre_revprop_change_hook flag is set): >> >>do >> svn_fs_revision_prop(¤t_value) >> action = ... >> svn_repos__hook