[PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-16 Thread Johan Corveleyn
Hi, Please find in attachment my (very first) patch addressing the issue discussed in [1] and [2]. Log message (maybe a bit too verbose ...): [[[ Fix alignment of blame output containing revision numbers >= 100 * subversion/include/svn_client.h (svn_client_blame_receiver3_t): Add parameter

Re: revprop changes and hooks

2010-06-16 Thread Daniel Shahaf
Philip Martin wrote on Tue, 15 Jun 2010 at 11:16 -: > Philip Martin writes: > > > Multiple clients. It arises from my idea to solve issue 3546 > > > > http://subversion.tigris.org/issues/show_bug.cgi?id=3546 > > > > In svn_repos_fs_change_rev_prop3 the code first gets the old property > > va

RE: Hot-backup.py won't create zipfiles bigger than 2GB

2010-06-16 Thread Donald Gordon
Hi > > > Here's a patch to hot-backup, then. > Donald, this mailing list unfortunately strips off some kinds of > attachments. Please try attaching as plain text, or even paste in-line > text if it's a very small patch. Attached, again: hopefully the list lets text/plain through. donald Index:

Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

2010-06-16 Thread C. Michael Pilato
Julian Foad wrote: > Previously, svn_io_dir_walk() reported only files and dirs. With this > change it reports symlinks in the same way that it reports files (even > if they point to a directory). The function has always reported files and directories using exactly the same construct: a call to

Re: status information

2010-06-16 Thread Stefan Küng
On 16.06.2010 21:40, Bert Huijben wrote: The plan is to remove even more expensive members from svn_wc_status3_t, to make it just return cheap information. (I think working_size is available, so we can add that specific one; but the scan if the file has been modified on disk will be removed).

Re: svn commit: r954830 - in /subversion/trunk/subversion/tests/cmdline: svnadmin_tests.py svntest/actions.py svntest/main.py svntest/sandbox.py tree_conflict_tests.py

2010-06-16 Thread Hyrum K. Wright
On Wed, Jun 16, 2010 at 11:21 AM, Philip Martin wrote: > hwri...@apache.org writes: > >> Author: hwright >> Date: Tue Jun 15 11:35:36 2010 >> New Revision: 954830 > >> -  if verbose_mode and quiet_mode: >> -    sys.stderr.write("ERROR: 'verbose' and 'quiet' are incompatible\n") >> -    sys.exit(1)

RE: status information

2010-06-16 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: woensdag 16 juni 2010 21:29 > To: Subversion Development > Subject: status information > > Hi, > > Since the svn_wc_status3_t struct is now missing the entry member, a > lot > of information previously avail

Re: Fixing blame misalignment for >1m revs - some questions

2010-06-16 Thread Johan Corveleyn
On Wed, Jun 16, 2010 at 3:58 PM, Julian Foad wrote: > Johan Corveleyn wrote: >> On Wed, Jun 16, 2010 at 1:11 PM, Julian Foad >> wrote: >> > Note that the caller can request a blame where the "end" revision is the >> > "WORKING" pseudo-revision, so be careful not to confuse the reader when >> > d

status information

2010-06-16 Thread Stefan Küng
Hi, Since the svn_wc_status3_t struct is now missing the entry member, a lot of information previously available from a status call is missing. I can work around a lot of that information using other svn API calls, but there's at least two pieces of info I'd really have back in a status call:

Re: svn commit: r954797 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2010-06-16 Thread Julian Foad
Ivan Zhakov wrote: > On Tue, Jun 15, 2010 at 17:38, Julian Foad wrote: > > On Tue, 2010-06-15, i...@apache.org wrote: > >> Author: ivan > >> Date: Tue Jun 15 10:37:09 2010 > >> New Revision: 954797 > >> > >> URL: http://svn.apache.org/viewvc?rev=954797&view=rev > >> Log: > >> Write update request

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread Daniel Shahaf
Julian Foad wrote on Wed, 16 Jun 2010 at 15:05 +0100: > On Wed, 2010-06-16 at 14:30 +0100, Philip Martin wrote: > > Daniel Shahaf writes: > > > > > Philip Martin wrote on Wed, 16 Jun 2010 at 11:17 -: > > >> How are you going to check adds? During an add the old value is NULL > > >> but must

Re: svn commit: r954797 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2010-06-16 Thread Ivan Zhakov
On Tue, Jun 15, 2010 at 17:38, Julian Foad wrote: > On Tue, 2010-06-15, i...@apache.org wrote: >> Author: ivan >> Date: Tue Jun 15 10:37:09 2010 >> New Revision: 954797 >> >> URL: http://svn.apache.org/viewvc?rev=954797&view=rev >> Log: >> Write update request body to file, to able resend it if ne

Re: svn commit: r954797 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2010-06-16 Thread Ivan Zhakov
On Tue, Jun 15, 2010 at 15:56, Philip Martin wrote: > i...@apache.org writes: > >> Author: ivan >> Date: Tue Jun 15 10:37:09 2010 >> New Revision: 954797 >> >> URL: http://svn.apache.org/viewvc?rev=954797&view=rev >> Log: >> Write update request body to file, to able resend it if needed. >> >> * s

Re: svn commit: r954830 - in /subversion/trunk/subversion/tests/cmdline: svnadmin_tests.py svntest/actions.py svntest/main.py svntest/sandbox.py tree_conflict_tests.py

2010-06-16 Thread Philip Martin
hwri...@apache.org writes: > Author: hwright > Date: Tue Jun 15 11:35:36 2010 > New Revision: 954830 > - if verbose_mode and quiet_mode: > -sys.stderr.write("ERROR: 'verbose' and 'quiet' are incompatible\n") > -sys.exit(1) > +if not appended: > + parser.error("invalid test numbe

Re: [PATCH] svn status ^/ foo: The node '/path/to/wc/foo' was not found.

2010-06-16 Thread Daniel Shahaf
Julian Foad wrote on Wed, 16 Jun 2010 at 16:31 +0100: > On Mon, 2010-06-14 at 03:44 +0200, Uwe Stuehler wrote: > > As far as I understood the purpose of check_root_url_of_target(), > > it is applied in order to make sure that if ^/ is being used, all > > other arguments refer to the same repository

Re: Info needed in 1.6.x STATUS file

2010-06-16 Thread Kamesh Jayachandran
On 06/15/2010 10:51 PM, Julian Foad wrote: Hi devs. Going through the 1.6.x. STATUS file, I am finding some items that could do with a better description or justification to make it easier to evaluate them. Can anyone provide information on the following: * r934599, r934603 Fix a c

Re: [PATCH] svn status ^/ foo: The node '/path/to/wc/foo' was not found.

2010-06-16 Thread Julian Foad
On Mon, 2010-06-14 at 03:44 +0200, Uwe Stuehler wrote: > On 06/13/10 06:25 PM, Uwe Stuehler wrote: > > Index: subversion/libsvn_client/cmdline.c > > === > > --- subversion/libsvn_client/cmdline.c (revision 953325) > > +++ subversion/li

1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

2010-06-16 Thread Julian Foad
> * r950445, 950468 >Fix for issue #2591 "'svnadmin hotcopy' does not replicate symlinks". >Justification: > This fix helps server administrators who has common files symlinked > across their repositories and take frequent backups of their repos > using svnadmin hotcopy. >

[PATCH] Extend the test for "svnadmin hotcopy" copying symlinks

2010-06-16 Thread Julian Foad
In testing for back-port to 1.6.x, I wanted a more thorough test, so here it is. [[[ Extend the test for "svnadmin hotcopy" copying symlinks. Ensure that the result is a symlink and not just a copy of the original symlink's target. Ensure that the new symlinks has the same target as the old one.

RE: svn commit: r955232 - /subversion/trunk/subversion/libsvn_wc/copy.c

2010-06-16 Thread Bert Huijben
> -Original Message- > From: style...@apache.org [mailto:style...@apache.org] > Sent: woensdag 16 juni 2010 16:06 > To: comm...@subversion.apache.org > Subject: svn commit: r955232 - > /subversion/trunk/subversion/libsvn_wc/copy.c > > Author: stylesen > Date: Wed Jun 16 14:05:30 2010 > N

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread Julian Foad
On Wed, 2010-06-16 at 14:30 +0100, Philip Martin wrote: > Daniel Shahaf writes: > > > Philip Martin wrote on Wed, 16 Jun 2010 at 11:17 -: > >> How are you going to check adds? During an add the old value is NULL > >> but must still be checked. > >> > > > > During an add, old_value_p!=NULL a

Re: Fixing blame misalignment for >1m revs - some questions

2010-06-16 Thread Julian Foad
Johan Corveleyn wrote: > On Wed, Jun 16, 2010 at 1:11 PM, Julian Foad wrote: > > It seems sensible to pass the start and end revision numbers of the > > requested blame range to this callback. > > Heh, I was just about to send a patch (was fiddling with getting gmail > to set a good mime-type for

speeding up bugfixes

2010-06-16 Thread Tino Schwarze
Hi there, I looked at the website already but did not find anything helpful. Is there a way to "speed up" a certain bugfix? I'm talking about that svnsync bug I recently discovered (http://subversion.tigris.org/issues/show_bug.cgi?id=3641) which is a showstopper for us since cvs2svn happens to cre

Re: revprop changes and hooks

2010-06-16 Thread C. Michael Pilato
Philip Martin wrote: > Philip Martin writes: > >> Multiple clients. It arises from my idea to solve issue 3546 >> >> http://subversion.tigris.org/issues/show_bug.cgi?id=3546 >> >> In svn_repos_fs_change_rev_prop3 the code first gets the old property >> value which it uses to calculate the action

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread C. Michael Pilato
Philip Martin wrote: > danie...@apache.org writes: > >> Author: danielsh >> Date: Wed Jun 16 06:05:17 2010 >> New Revision: 955136 >> >> URL: http://svn.apache.org/viewvc?rev=955136&view=rev >> Log: >> Revv the FS change_rev_prop() interface towards more atomicity. >> >> Suggested by: philip >> >>

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Wed, 16 Jun 2010 at 11:17 -: >> How are you going to check adds? During an add the old value is NULL >> but must still be checked. >> > > During an add, old_value_p!=NULL and *old_value_p==NULL, and the code > checks that present_value==NULL as

Re: Berlin Hackathon Debrief

2010-06-16 Thread C. Michael Pilato
Hyrum K. Wright wrote: > First, let me give a hearty thanks to the many people to worked hard > to make the Berlin summit a success. It was really useful for those > of us who were able to come and work through both design and > implementation issues in a real-time, high-bandwidth way. Oh, and th

Fwd: SVN broken since the newest version

2010-06-16 Thread Sjors Gielen
Hello, Subversion list, I have reported this problem in the Fink SVN package yesterday. Since version 1.6.11, SVN crashes and corrups my checkouts. > It seems like SVN is broken in the newest version in Fink. I have recently > updated to version 1.6.11-2 from unstable, which Fink compiled itsel

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread Daniel Shahaf
Philip Martin wrote on Wed, 16 Jun 2010 at 11:17 -: > danie...@apache.org writes: > > > == > > --- subversion/trunk/subversion/include/svn_fs.h (original) > > +++ subversion/trunk/subversion/include/svn_fs.h Wed Jun 16

Re: Fixing blame misalignment for >1m revs - some questions

2010-06-16 Thread Johan Corveleyn
On Wed, Jun 16, 2010 at 1:11 PM, Julian Foad wrote: > On Tue, 2010-06-15, Johan Corveleyn wrote: >> On Tue, Jun 15, 2010 at 4:36 PM, Philip Martin >> wrote: >> > Johan Corveleyn writes: >> > >> >> 1) To do this, the blame_receiver callback needs to know the >> >> end_revnum. So I need to extend

Re: Fixing blame misalignment for >1m revs - some questions

2010-06-16 Thread Julian Foad
On Tue, 2010-06-15, Johan Corveleyn wrote: > On Tue, Jun 15, 2010 at 4:36 PM, Philip Martin > wrote: > > Johan Corveleyn writes: > > > >> 1) To do this, the blame_receiver callback needs to know the > >> end_revnum. So I need to extend svn_client_blame_receiver3_t to > >> include end_revnum as a

RE: Hot-backup.py won't create zipfiles bigger than 2GB

2010-06-16 Thread Julian Foad
On Wed, 2010-06-16 at 09:03 +0300, Daniel Shahaf wrote: > Donald Gordon wrote on Wed, 16 Jun 2010 at 02:12 -: > > > hot-backup.py is in our trunk/tools/, and requests to extend it may be > > > dev > > > topics (e.g., if they come with patches). So I don't think it's off- > > > topic? > > > >

Re: Berlin Hackathon Debrief

2010-06-16 Thread Stefan Sperling
On Tue, Jun 15, 2010 at 08:16:06PM -0500, Hyrum K. Wright wrote: > elego did so many things right here that it's hard to list them all. Thanks Hyrum! I'd like to note that the event would have been much harder to pull off if we hadn't received sponsorship from other companies for the event, namel

Re: svn commit: r955136 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ tests/libsvn_fs/

2010-06-16 Thread Philip Martin
danie...@apache.org writes: > Author: danielsh > Date: Wed Jun 16 06:05:17 2010 > New Revision: 955136 > > URL: http://svn.apache.org/viewvc?rev=955136&view=rev > Log: > Revv the FS change_rev_prop() interface towards more atomicity. > > Suggested by: philip > > > * subversion/include/svn_fs.h >