Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-10 Thread Alexander Thomas
On Thu, 2010-06-10 at 18:23 +0200, Stefan Sperling wrote: > On Wed, Jun 09, 2010 at 01:31:54PM +0200, Stefan Sperling wrote: > > > PASS: prop_tests.py 22: test prop* handle invalid property names > > > > Hmmm... I will try to debug this during the hackathon. > > This is not a problem in Subver

RE: svn commit: r949964 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-06-10 Thread Bert Huijben
STMT_INSERT_ACTUAL_NODE does an insert or replace, which might be invalid in this case. (It's documentation says that it is only used from entries.c). I think we should create a similar statement (maybe with the missing rows) that is always safe to use Bert From: hy...@hyrumwrig

Re: svn commit: r953308 - /subversion/trunk/build/generator/gen_win.py

2010-06-10 Thread Ivan Zhakov
On Thu, Jun 10, 2010 at 18:18, Greg Stein wrote: > On Thu, Jun 10, 2010 at 08:37,   wrote: >>... >> +++ subversion/trunk/build/generator/gen_win.py Thu Jun 10 12:37:23 2010 >> @@ -1151,10 +1151,12 @@ class WinGeneratorBase(GeneratorBase): >>     self.move_proj_file(self.serf_path, name, >>        

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-10 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 01:31:54PM +0200, Stefan Sperling wrote: > > PASS: prop_tests.py 22: test prop* handle invalid property names > > Hmmm... I will try to debug this during the hackathon. This is not a problem in Subversion. The problem is way deeper, down in the iconv implementation, an

Re: svn commit: r953308 - /subversion/trunk/build/generator/gen_win.py

2010-06-10 Thread Greg Stein
On Thu, Jun 10, 2010 at 08:37, wrote: >... > +++ subversion/trunk/build/generator/gen_win.py Thu Jun 10 12:37:23 2010 > @@ -1151,10 +1151,12 @@ class WinGeneratorBase(GeneratorBase): >     self.move_proj_file(self.serf_path, name, >                         (('serf_sources', >                    

Re: Eating peg revisions [was: [PATCH] Fix issue #3651 - "svn copy does not eat peg revision within copy target path"]

2010-06-10 Thread Senthil Kumaran S
Hi Julian, Julian Foad wrote: >> [[[ >> Fix issue #3651. > > Hi Senthil. > > Please could you quote the issue's Subject when you quote its issue > number in a log message or in an email subject line. That would make > life easier for me. Thanks. I did that in the original commit log message.

RE: svn commit: r953302 - in /subversion/trunk/subversion: include/svn_diff.h libsvn_client/diff.c

2010-06-10 Thread Bert Huijben
-Original Message- From: dan...@apache.org [mailto:dan...@apache.org] Sent: donderdag 10 juni 2010 14:25 To: comm...@subversion.apache.org Subject: svn commit: r953302 - in /subversion/trunk/subversion: include/svn_diff.h libsvn_client/diff.c Author: dannas Date: Thu Jun 10 12:24:39 20

Eating peg revisions [was: [PATCH] Fix issue #3651 - "svn copy does not eat peg revision within copy target path"]

2010-06-10 Thread Julian Foad
On Wed, 2010-06-09 at 17:05 +0530, Senthil Kumaran S wrote: > Hi, > > I am attaching a patch to fix issue #3651, just to check whether this is what > stsp intended to say via > http://subversion.tigris.org/issues/show_bug.cgi?id=3651#desc2 > > Thank You. > plain text document attachment (3651.pat

Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c

2010-06-10 Thread Senthil Kumaran S
Senthil Kumaran S wrote: > Senthil Kumaran S wrote: >>> We want to add #include "private/svn_opt_private.h" to avoid compiler >>> warnings about an undefined function yes? >> I thought '#include "svn_private_config.h' will include the required private >> header files. If that is the case then we n

Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c

2010-06-10 Thread Senthil Kumaran S
Senthil Kumaran S wrote: >> We want to add #include "private/svn_opt_private.h" to avoid compiler >> warnings about an undefined function yes? > > I thought '#include "svn_private_config.h' will include the required private > header files. If that is the case then we need not explicitly include i

Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c

2010-06-10 Thread Senthil Kumaran S
Hi Paul, Paul Burba wrote: > On Wed, Jun 9, 2010 at 8:48 AM, wrote: > >> Author: stylesen >> Date: Wed Jun 9 12:48:05 2010 >> New Revision: 952981 >> >> URL: http://svn.apache.org/viewvc?rev=952981&view=rev >> Log: >> On the '1.6.x-issue3651' branch: >> >> Merge from trunk r952973 and use the

Re: commit: affected paths in commit hooks

2010-06-10 Thread C. Michael Pilato
Winston Smith wrote: > I am trying to pass down the paths that are affected by a commit down to the > commit hooks. My question is how can I detect these paths? Use the svn_fs_paths_changed() interface. There are plenty of examples of this to be found. Here's one: http://svn.apache.org/repos/asf

Getting data out of SVN quickly and efficiently

2010-06-10 Thread Ramkumar Ramachandra
Hi, I'm working on a project to convert SVN revisions to a stream that git-fast-import can import. We have already built an excellent exporter for an SVN dumpfile [1], because we figured that dumpfile is the most reliable way to get data out of SVN. Now, to connect to the SVN server and emit data

Re: commit: affected paths in commit hooks

2010-06-10 Thread Philip Martin
Winston Smith writes: > I am trying to pass down the paths that are affected by a commit down > to the commit hooks. My question is how can I detect these paths? I > have tried to do so when the editor is driven, but functions like > ra_svn_handle_* would only read the basename of any dir or file

Re: [PATCH] issue #3292: fix for 'svnlook diff' regression: doesn't print added dirs

2010-06-10 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 06:10:29PM -0700, Lamar Goddard wrote: > Oh, I don't think my reply on the other thread made it to the dev > list, hopefully this one will. > > On Wed, Jun 9, 2010 at 1:11 AM, Stefan Sperling wrote: > > On Fri, Jun 04, 2010 at 06:02:52PM -0700, Lamar Goddard wrote: > >> [[