[PATCH] readable error messages on non-ASCII systems, v2

2010-05-12 Thread Greg Ames
This patch also produces readable error messages on z/OS by defining two new svn_cmdline functions which take native string arguments, then calling svn_cmdline_fprintf_asis() from print_error(), only in the path where I can see that native strings are being used. Greg Index: subversion/libsvn_sub

Re: keep_local in harvest_committables

2010-05-12 Thread Philip Martin
Neels J Hofmeyr writes: > On 2010-05-13 00:25, Philip Martin wrote: >> Neels J Hofmeyr writes: >> >>> The bottom line is: simply remove that madly misguided entry->keep_local >>> conditional and always call bail_on_tree_conflicted_children(). The rest of >>> the patch is mending the test suite

Re: keep_local in harvest_committables

2010-05-12 Thread Neels J Hofmeyr
On 2010-05-13 00:25, Philip Martin wrote: > Neels J Hofmeyr writes: > >> The bottom line is: simply remove that madly misguided entry->keep_local >> conditional and always call bail_on_tree_conflicted_children(). The rest of >> the patch is mending the test suite to be sensible about it. Will do.

Re: keep_local in harvest_committables

2010-05-12 Thread Philip Martin
Neels J Hofmeyr writes: > The bottom line is: simply remove that madly misguided entry->keep_local > conditional and always call bail_on_tree_conflicted_children(). The rest of > the patch is mending the test suite to be sensible about it. Will do. See r943722 for a slightly different approach.

Re: keep_local in harvest_committables

2010-05-12 Thread Neels J Hofmeyr
On 2010-05-12 16:46, Philip Martin wrote: > I saw you talking about keep-local on IRC a couple of days ago, are > you working on keep-local in harvest_committables? Yes, indeed I am ... was ... will. I've been kept busy by real life issues, but that's about to pass. Thanks for reminding me, btw.

Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Greg Stein
On Wed, May 12, 2010 at 16:34, Daniel Shahaf wrote: > Daniel Shahaf wrote on Wed, 12 May 2010 at 23:19 +0300: >> It only affects symlinks being added on Windows > > And even then, what exactly is the effect?  What code exactly is going to > bother noticing that the property's value is not "*", giv

Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, 12 May 2010 at 23:19 +0300: > It only affects symlinks being added on Windows And even then, what exactly is the effect? What code exactly is going to bother noticing that the property's value is not "*", given that we promise it to always be "*" whenever the propert

Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Daniel Shahaf
It only affects symlinks being added on Windows --- a pretty rare use case. If folks think it's important enough a fix to be backported, then I'm +1 too. Daniel Greg Stein wrote on Wed, 12 May 2010 at 14:46 -0400: > Backport? > > On May 12, 2010 2:18 PM, wrote: > > Author: danielsh > Date: We

Re: [PATCH] readable error messages on non-ASCII systems

2010-05-12 Thread Greg Ames
On Wed, May 12, 2010 at 3:09 PM, Mark Phippard wrote: > You should look at this now deleted branch for Subversion on EBCDIC > systems. > > http://svn.apache.org/viewvc/subversion/branches/ebcdic/?pathrev=876004 > > It was written for AS/400, not z/OS but examining the diff of this > branch and wh

Re: Optimizing back-end: saving cycles or saving I/O (was: Re: [PATCH v2] Saving a few cycles, part 3/3)

2010-05-12 Thread Greg Hudson
On Wed, 2010-05-12 at 13:44 -0400, Hyrum K. Wright wrote: > There may be other ways of caching this information, which would be great. Maybe. Caches add complexity, and too many layers of caching (disk, OS, application) can actually reduce performance in some scenarios. I would suggest getting a

Re: [PATCH] readable error messages on non-ASCII systems

2010-05-12 Thread Mark Phippard
You should look at this now deleted branch for Subversion on EBCDIC systems. http://svn.apache.org/viewvc/subversion/branches/ebcdic/?pathrev=876004 It was written for AS/400, not z/OS but examining the diff of this branch and what it was synched with will help get an idea on where to look. The

Re: [PATCH] readable error messages on non-ASCII systems

2010-05-12 Thread Greg Ames
ooops, I meant to cc: dev at subversion. Thanks, Daniel. I'm more used to dev at httpd where there is some magic involving replyto: Here is what I see if I run dbx against svnversion with a stop set in svn_cmdline_fputs: [2] stopped in svn_cmdline_fputs at line 288 in file "cmdline.c" ($t1)

Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Greg Stein
Backport? On May 12, 2010 2:18 PM, wrote: Author: danielsh Date: Wed May 12 18:18:03 2010 New Revision: 943609 URL: http://svn.apache.org/viewvc?rev=943609&view=rev Log: Fix special_tests 15: normalize "svn:special"'s value. * subversion/libsvn_wc/props.c (svn_wc_canonicalize_svn_prop): No

Re: Commiting, tree conflicts and keep-local

2010-05-12 Thread Greg Stein
Temp function. It can be used in entries.c, too. It'll only last until single-db. Not blasting conflict info is good, in case of reverts. On May 12, 2010 2:17 PM, "Philip Martin" wrote: The only thing keeping me from finally removing svn_wc_entry_t from harvest_committables is keep_local. The

Re: Possible security problem with svnsync?

2010-05-12 Thread C. Michael Pilato
C. Michael Pilato wrote: > Peter Samuelson wrote: >> [Jon Foster] >>> All he has to do is change the svn:sync-from-url property on the >>> mirror repository to be a file:// URL to the source repository, >>> rather than a http:// one. The correct file:// URL is probably >>> guessable. >> I'd never

Commiting, tree conflicts and keep-local

2010-05-12 Thread Philip Martin
The only thing keeping me from finally removing svn_wc_entry_t from harvest_committables is keep_local. There was some discussion on IRC a few days ago http://colabti.org/irclogger/irclogger_log/svn-dev?date=2010-05-06#l44 but it really resolve things. It includes pointers to Neels patch to make

First SVN performance data

2010-05-12 Thread Stefan Fuhrmann
Hi there, as I promised, I'm going to conduct some in-depth analysis and comprehensive SVN performance testing. That is very time-consuming process. However, it seems that many people have incorrect or outdated ideas about the current state of affairs. To add a bit more substance to the discussi

Re: Optimizing back-end: saving cycles or saving I/O (was: Re: [PATCH v2] Saving a few cycles, part 3/3)

2010-05-12 Thread Hyrum K. Wright
On Tue, May 11, 2010 at 6:16 PM, Johan Corveleyn wrote: > On Tue, May 11, 2010 at 1:56 PM, Stefan Sperling wrote: > > On Tue, May 11, 2010 at 07:43:33AM -0400, Mark Phippard wrote: > >> On Tue, May 11, 2010 at 7:27 AM, Stefan Sperling wrote: > >> > On Tue, May 11, 2010 at 01:36:26AM +0200, Joha

Re: WC-NG: Perhaps it's time to write a new summary of where we stand at the moment?

2010-05-12 Thread Hyrum K. Wright
On Wed, May 12, 2010 at 12:14 PM, Greg Stein wrote: > On Wed, May 12, 2010 at 09:33, Daniel Näslund > wrote: > > Hi! > > > > Greg [1] identified the following items in the beginning of February. > > > > * remove entry_t usage within libsvn_wc/client > > This is very close in the client, but ther

Re: WC-NG: Perhaps it's time to write a new summary of where we stand at the moment?

2010-05-12 Thread Greg Stein
On Wed, May 12, 2010 at 09:33, Daniel Näslund wrote: > Hi! > > Greg [1] identified the following items in the beginning of February. > > * remove entry_t usage within libsvn_wc/client This is very close in the client, but there is still a good chunk of work in libsvn_wc. > * remove access_t usag

Re: What are the plans for svn_wc_status3_t?

2010-05-12 Thread Bert Huijben
On Wed, May 12, 2010 at 3:10 PM, Daniel Näslund wrote: > Hi! > > I set out to remove the entry field in svn_wc_status3_t. The reasons was > i) svn_wc_entry_t is deprecated and ii) fetching all the info contained > in the entry field is slow and we want 'svn status' to be fast! > > So far this has

Re: svn commit: r943574 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c wc_db.h

2010-05-12 Thread Greg Stein
On Wed, May 12, 2010 at 12:41, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Wed May 12 16:41:18 2010 > @@ -3767,6 +3767,49 @@ svn_wc__db_temp_op_remove_entry(svn_wc__ >  } > > > +svn_error_t * > +svn_wc__db_temp_op_remove_working(svn_wc__db_t *db, > +                          

Re: svn commit: r943571 - /subversion/trunk/subversion/libsvn_wc/status.c

2010-05-12 Thread Greg Stein
On Wed, May 12, 2010 at 12:40, wrote: > Author: dannas > Date: Wed May 12 16:40:08 2010 > New Revision: 943571 > > URL: http://svn.apache.org/viewvc?rev=943571&view=rev > Log: > Remove two usages of svn_wc_entry_t for checking if we have some > interresting status to return. > > * subversion/libs

Re: Possible security problem with svnsync?

2010-05-12 Thread C. Michael Pilato
Peter Samuelson wrote: > [Jon Foster] >> All he has to do is change the svn:sync-from-url property on the >> mirror repository to be a file:// URL to the source repository, >> rather than a http:// one. The correct file:// URL is probably >> guessable. > > I'd never thought of this as as security

Re: Possible security problem with svnsync?

2010-05-12 Thread Peter Samuelson
[Jon Foster] > All he has to do is change the svn:sync-from-url property on the > mirror repository to be a file:// URL to the source repository, > rather than a http:// one. The correct file:// URL is probably > guessable. I'd never thought of this as as security problem, but I _do_ think it's

Re: Possible security problem with svnsync?

2010-05-12 Thread Greg Hudson
I would guess that svnsync was designed under the assumption that it would be run on the slave repository via a cron job or something. It's a pull tool, not a push tool. That said, your suggestion seems reasonable. (When I've set up replicated repositories using push, I've used svnadmin dump and

Re: Possible security problem with svnsync?

2010-05-12 Thread C. Michael Pilato
Jon Foster wrote: > Hi, > > I have a repository that is partially mirrored, using svnsync and > mod_authz_svn [1]. I just realised that the administrator of the > mirror server can bypass the authz rules I've set up on the master > server. All he has to do is change the svn:sync-from-url propert

RE: Possible security problem with svnsync?

2010-05-12 Thread Jon Foster
Hi, Bob Archer wrote: > Jon Foster wrote: > > I have a repository that is partially mirrored, using svnsync and > > mod_authz_svn [1]. I just realised that the administrator of the > > mirror server can bypass the authz rules I've set up on the master > > server. All he has to do is change the

RE: Possible security problem with svnsync?

2010-05-12 Thread Bob Archer
> I have a repository that is partially mirrored, using svnsync and > mod_authz_svn [1]. I just realised that the administrator of the > mirror server can bypass the authz rules I've set up on the master > server. All he has to do is change the svn:sync-from-url property > on the mirror repositor

WC-NG: Perhaps it's time to write a new summary of where we stand at the moment?

2010-05-12 Thread Daniel Näslund
Hi! Greg [1] identified the following items in the beginning of February. * remove entry_t usage within libsvn_wc/client * remove access_t usage withing libsvn_wc/client * move props into wc.db * move to single/root wc.db * switch to new pristine file mgmt I have the feeling, we've made some pro

Re: svn commit: r943460 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-05-12 Thread Greg Stein
On Wed, May 12, 2010 at 07:58, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/update_editor.c Wed May 12 11:58:16 > 2010 > @@ -4717,27 +4717,38 @@ close_file(void *file_baton, >     SVN_ERR(svn_checksum_parse_hex(&expected_md5_checksum, svn_checksum_md5, >                              

What are the plans for svn_wc_status3_t?

2010-05-12 Thread Daniel Näslund
Hi! I set out to remove the entry field in svn_wc_status3_t. The reasons was i) svn_wc_entry_t is deprecated and ii) fetching all the info contained in the entry field is slow and we want 'svn status' to be fast! So far this has been done: -- * The revision information

RE: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: woensdag 12 mei 2010 12:59 > To: comm...@subversion.apache.org > Subject: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h > svn/log-cmd.c svn/main.c > tests/cmdline/getopt_tests_data/svn_help_log_s

Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Stefan Sperling
On Wed, May 12, 2010 at 08:13:55AM -0400, Mark Phippard wrote: > It would also be easy to script and that has always been our position > on adding options like this. Especially if we cannot implement the > option internally more efficiently than the script. Oh, it's not quite the same thing. What

Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Mark Phippard
On Wed, May 12, 2010 at 8:00 AM, Stefan Sperling wrote: >> I don't want to pee in the punch bowl, but why are we doing this? > > Because it has proven to be a popular feature in other systems. > It's very convenient if you want to catch up with the latest N > commits made and skim the diffs. Espe

Possible security problem with svnsync?

2010-05-12 Thread Jon Foster
Hi, I have a repository that is partially mirrored, using svnsync and mod_authz_svn [1]. I just realised that the administrator of the mirror server can bypass the authz rules I've set up on the master server. All he has to do is change the svn:sync-from-url property on the mirror repository to

Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Stefan Sperling
On Wed, May 12, 2010 at 07:48:58AM -0400, Mark Phippard wrote: > On Wed, May 12, 2010 at 7:24 AM, Stefan Sperling wrote: > > On Wed, May 12, 2010 at 10:59:28AM -, s...@apache.org wrote: > >> Author: stsp > >> Date: Wed May 12 10:59:27 2010 > >> New Revision: 943445 > >> > >> URL: http://svn.ap

Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Mark Phippard
On Wed, May 12, 2010 at 7:24 AM, Stefan Sperling wrote: > On Wed, May 12, 2010 at 10:59:28AM -, s...@apache.org wrote: >> Author: stsp >> Date: Wed May 12 10:59:27 2010 >> New Revision: 943445 >> >> URL: http://svn.apache.org/viewvc?rev=943445&view=rev >> Log: >> Add a new --show-diff option t

Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2010-05-12 Thread Stefan Sperling
On Wed, May 12, 2010 at 10:59:28AM -, s...@apache.org wrote: > Author: stsp > Date: Wed May 12 10:59:27 2010 > New Revision: 943445 > > URL: http://svn.apache.org/viewvc?rev=943445&view=rev > Log: > Add a new --show-diff option to svn log, fixing part of issue #2909. > + SVN_ERR(svn_clie

Free Online Subversion Training - All About Subversion Hook Scripts

2010-05-12 Thread george.pow...@wandisco.com
svn.wandisco.com/hookscripts Hook scripts are server-side executables tied to various Subversion events. During this course, attendees will learn how to use hook scripts for: * Email notification of an event * Commit validation * Automatic backup of changes * Integration with issu