[PATCH v4] Fix O(n) runtime in cache lookup, part 1/2

2010-04-28 Thread Stefan Fuhrmann
Hi devs, this is version 4 of the patch part 1/2. Part 2/2 remains valid as posted. The following things have been improved over v3: * rename all pools used for temporary allocations to "scratch_pool * add more comments to the inproc cache code & fix typos * route cache overflow warnings to the

Re: Feature idea: user-configurable post-commit notifications

2010-04-28 Thread Neels J Hofmeyr
Bolstridge, Andrew wrote: >> -Original Message- >> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] >> Sent: Mon 26/04/2010 19:27 >> To: Bolstridge, Andrew >> Cc: dev@subversion.apache.org >> Subject: RE: Feature idea: user-configurable post-commit notifications >> >> Bolstridge, Andrew

Re: patch API review

2010-04-28 Thread Hyrum K. Wright
On Wed, Apr 28, 2010 at 1:43 PM, Stefan Sperling wrote: > On Wed, Apr 28, 2010 at 10:05:58AM -0500, Hyrum K. Wright wrote: > > I'm looking at adding support for the patch client API to JavaHL, but in > > doing so, I have a few questions about the API itself. I'm pretty late > the > > game, so th

Re: patch API review

2010-04-28 Thread Stefan Sperling
On Wed, Apr 28, 2010 at 10:05:58AM -0500, Hyrum K. Wright wrote: > I'm looking at adding support for the patch client API to JavaHL, but in > doing so, I have a few questions about the API itself. I'm pretty late the > game, so these questions might already be answered. If so, please point me > t

RE: Feature idea: user-configurable post-commit notifications

2010-04-28 Thread Bolstridge, Andrew
>-Original Message- >From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] >Sent: Mon 26/04/2010 19:27 >To: Bolstridge, Andrew >Cc: dev@subversion.apache.org >Subject: RE: Feature idea: user-configurable post-commit notifications > >Bolstridge, Andrew wrote on Fri, 23 Apr 2010 at 13:52 +01

Re: svn commit: r939002 - /subversion/trunk/subversion/mod_dav_svn/reports/update.c

2010-04-28 Thread C. Michael Pilato
rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Apr 28 16:25:09 2010 > New Revision: 939002 [...] > Modified: subversion/trunk/subversion/mod_dav_svn/reports/update.c > == > --- subversion/trunk/subversion/mod_d

Re: Error with transform_sql.sh rule

2010-04-28 Thread Hyrum K. Wright
On Wed, Apr 28, 2010 at 10:35 AM, Peter Samuelson wrote: > > [Hyrum K. Wright] > > Yes, this is a bug in the build / distribution process. In 1.7 and > beyond, > > we pretransform the sql files, since they aren't platform-dependent, but > > those bits have yet to be backported to 1.6.x. > > I'd

Re: Error with transform_sql.sh rule

2010-04-28 Thread Peter Samuelson
[Hyrum K. Wright] > Yes, this is a bug in the build / distribution process. In 1.7 and beyond, > we pretransform the sql files, since they aren't platform-dependent, but > those bits have yet to be backported to 1.6.x. I'd rather see us go in the opposite direction: "output is not platform-depen

patch API review

2010-04-28 Thread Hyrum K. Wright
I'm looking at adding support for the patch client API to JavaHL, but in doing so, I have a few questions about the API itself. I'm pretty late the game, so these questions might already be answered. If so, please point me to the relevant thread(s). For reference, here's the public API: svn_err

Re: Error with transform_sql.sh rule

2010-04-28 Thread Daniel Richard G.
On Wed, 2010 Apr 28 09:33-0500, Hyrum K. Wright wrote: > > > > Given that rep-cache-db.h is always generated at build time, and is > > not something that (I gather) can be bundled in the source tarball, > > it should be written to builddir, not to srcdir. > > Yes, this is a bug in the build / distr

Re: Error with transform_sql.sh rule

2010-04-28 Thread Hyrum K. Wright
On Wed, Apr 28, 2010 at 1:21 AM, Daniel Richard G. wrote: > I'm building Subversion 1.6.11 from a read-only source tree. I get this: > > /nfs/subversion-1.6.11/build/transform_sql.sh > /nfs/subversion-1.6.11/subversion/libsvn_fs_fs/rep-cache-db.sql < > /nfs/subversion-1.6.11/subversion/libsvn_fs_

Re: svndumpfilter --renumber-revs and --drop-empty-revs

2010-04-28 Thread C. Michael Pilato
Paul Burba wrote: > Is the --renumber-revs option to svndumpfilter supposed to do anything > when the --drop-empty-revs option is *not* present? > > The help text is a bit vague "--renumber-revs : Renumber revisions > left after filtering." and the "book" seems to say that it doesn't: > > [[[ >

Re: wc-ng: determine if a node is versioned

2010-04-28 Thread Neels J Hofmeyr
Neels J Hofmeyr wrote: > Greg Stein wrote: >> On Sat, Apr 24, 2010 at 10:37, Neels J Hofmeyr wrote: >>> ... >>> At first glance, it appears that different code paths want to handle >>> incomplete nodes differently. Some want to act as if the node was 'normal' >>> == versioned. Most appear to want

Re: svn commit: r927098 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c

2010-04-28 Thread Julian Foad
On Tue, 2010-04-27, Greg Stein wrote: > On Wed, Mar 24, 2010 at 12:02, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_wc/workqueue.c Wed Mar 24 16:02:26 > > 2010 > >... > > @@ -1596,9 +1590,12 @@ run_postcommit(svn_wc__db_t *db, > > SVN_ERR(svn_skel__parse_proplist(&new_dav_cache,