RE: svn commit: r935413 - /subversion/trunk/subversion/libsvn_wc/adm_crawler.c

2010-04-18 Thread Bert Huijben
> -Original Message- > From: gst...@apache.org [mailto:gst...@apache.org] > Sent: zondag 18 april 2010 23:17 > To: comm...@subversion.apache.org > Subject: svn commit: r935413 - > /subversion/trunk/subversion/libsvn_wc/adm_crawler.c > > Author: gstein > Date: Sun Apr 18 21:16:55 2010 > N

Re: misaligned blame output if repo has >1m revisions

2010-04-18 Thread Branko Čibej
Johan Corveleyn wrote: > Hi all, > > Sorry it took a while to respond (been away for a while). I've been > thinking a little about this, looking at the code ... > > I see 3 options: > > 1) Determine the max length of revnum (and author) in blame.c, either > while building the blame chunks or in an

Re: misaligned blame output if repo has >1m revisions

2010-04-18 Thread Johan Corveleyn
Hi all, Sorry it took a while to respond (been away for a while). I've been thinking a little about this, looking at the code ... I see 3 options: 1) Determine the max length of revnum (and author) in blame.c, either while building the blame chunks or in an extra loop before sending the blame in

[PATCH] Re: Thinko in libsvn_client/merge.c?

2010-04-18 Thread Roderich Schupp
On Thu, Apr 15, 2010 at 2:25 PM, C. Michael Pilato wrote: > Roderich Schupp wrote: >> On Tue, Apr 13, 2010 at 4:37 PM, C. Michael Pilato >> wrote: > Cool.  I'll watch for your followup posts, and be glad to try to answer any > questions you might have about the code. OK, here's my patch for me

[PATCH] Use _node_is_status_added() in libsvn_client/status.c

2010-04-18 Thread Daniel Näslund
Hi! [[[ As part of WC-NG, remove a use of svn_wc_entry_t. * subversion/libsvn_client/status.c (svn_client_status5): Use svn_wc__node_is_status_added() instead of checking entry->schedule. The check is meant to be used for correctly determining when a node has been deleted in the repo

Re: [PATCH] Use a node func for fetching file external status in libsvn_client/delete.c

2010-04-18 Thread Daniel Näslund
On Sat, Apr 17, 2010 at 03:38:16PM -0400, Greg Stein wrote: > Dude. Totally fine. I wrote that function last week for exactly what you're > doing. > > On Apr 17, 2010 2:10 PM, "Daniel Näslund" wrote: > > Hi! > > This patch passes make check. > > svn_wc__node_is_file_external() seems to be in a