RE: [PATCH] sasl service name for svnserve

2010-04-12 Thread Катаргин Алексей
-Original Message- From: 'Stefan Sperling' [mailto:s...@elego.de] Sent: Monday, April 12, 2010 10:05 PM To: Катаргин Алексей Cc: dev@subversion.apache.org; n...@chelcom.ru Subject: Re: [PATCH] sasl service name for svnserve > On Mon, Apr 12, 2010 at 10:33:03AM +0600, Катаргин Алексей wrot

Re: Expansion of authz policy name leak (was: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c)

2010-04-12 Thread Peter Samuelson
[C. Michael Pilato] > IIUC, prior to your change, nobody who had enabled authz at all could > make use of the SVNListParentPath feature (because the authorization > for that display would systematically fail). But this also means > that Subversion never leaked the name of a repository that was >

Re: [PATCH] Follow-up to r932571 - missed one caller was: Re: svn commit: r932571 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/

2010-04-12 Thread Greg Stein
+1 to apply On Apr 12, 2010 3:50 PM, "Daniel Näslund" wrote: On Mon, Apr 12, 2010 at 08:58:49AM -0400, Greg Stein wrote: > On Fri, Apr 9, 2010 at 16:16, Greg Stein wrote: > > On Fri, Apr 9, 2010 at 16:07, wrote: > >>... > >>... > >> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri A

[PATCH] Follow-up to r932571 - missed one caller was: Re: svn commit: r932571 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/

2010-04-12 Thread Daniel Näslund
On Mon, Apr 12, 2010 at 08:58:49AM -0400, Greg Stein wrote: > On Fri, Apr 9, 2010 at 16:16, Greg Stein wrote: > > On Fri, Apr 9, 2010 at 16:07,   wrote: > >>... > >>... > >> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri Apr  9 20:07:51 > >> 2010 > >>... > >> @@ -2515,13 +2551,15 @@ s

RE: Expansion of authz policy name leak (was: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c)

2010-04-12 Thread Kamesh Jayachandran
>IIUC, prior to your change, nobody who had enabled authz at all could make >use of the SVNListParentPath feature (because the authorization for that >display would systematically fail). But this also means that Subversion >never leaked the name of a repository that was intended to be private/hidd

Re: svn commit: r932459 - in /subversion/trunk/subversion/libsvn_wc: entries.c wc-queries.sql wc_db.c wc_db.h

2010-04-12 Thread Julian Foad
Greg Stein wrote: > On Fri, Apr 9, 2010 at 11:17, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_wc/entries.c Fri Apr 9 15:17:06 2010 > > @@ -1059,7 +1059,18 @@ read_entries_new(apr_hash_t **result_ent > > result_pool); > > > > if

Re: Subversion Vision and Roadmap Proposal

2010-04-12 Thread Greg Stein
On Mon, Apr 12, 2010 at 13:14, Mike Dixon wrote: >... > And so we have identified one of the problems. > > If you're serious about getting new people involved in development, getting > a patch reviewed needs to be *easy*. If someone sends in a patch and it gets > ignored (not maliciously, of cours

Re: Subversion Vision and Roadmap Proposal

2010-04-12 Thread Mike Dixon
C. Michael Pilato wrote: When the agenda item for voting new full committers into membership was on the table, there were no candidates. Think about that: no new full committers for Subversion in the past year. This is a bad thing. We need to find a way to embrace and empower would-be Subvers

Re: svn commit: r933272 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c

2010-04-12 Thread Greg Stein
On Mon, Apr 12, 2010 at 13:11, Julian Foad wrote: > Greg Stein wrote: >> On Mon, Apr 12, 2010 at 12:35, Julian Foad >> wrote: >> > On Mon, 2010-04-12 at 11:48 -0400, Greg Stein wrote: >> >> On Mon, Apr 12, 2010 at 11:19,   wrote: >> >> >... >> >... >> >> > +      SVN_ERR(svn_sqlite__reset(stmt))

Re: svn commit: r933272 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c

2010-04-12 Thread Julian Foad
Greg Stein wrote: > On Mon, Apr 12, 2010 at 12:35, Julian Foad wrote: > > On Mon, 2010-04-12 at 11:48 -0400, Greg Stein wrote: > >> On Mon, Apr 12, 2010 at 11:19, wrote: > >> >... > >... > >> > + SVN_ERR(svn_sqlite__reset(stmt)); > >> > + return svn_error_createf(SVN_ERR_WC_PATH_NOT_FO

Re: svn commit: r933272 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c

2010-04-12 Thread Greg Stein
On Mon, Apr 12, 2010 at 12:35, Julian Foad wrote: > On Mon, 2010-04-12 at 11:48 -0400, Greg Stein wrote: >> On Mon, Apr 12, 2010 at 11:19,   wrote: >> >... >... >> > +      SVN_ERR(svn_sqlite__reset(stmt)); >> > +      return svn_error_createf(SVN_ERR_WC_PATH_NOT_FOUND, NULL, >> > +              

Re: svn commit: r933272 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c

2010-04-12 Thread Julian Foad
On Mon, 2010-04-12 at 11:48 -0400, Greg Stein wrote: > On Mon, Apr 12, 2010 at 11:19, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Mon Apr 12 15:19:23 2010 > > @@ -7254,13 +7254,17 @@ svn_wc__db_get_pristine_md5(const svn_ch > > SVN_ERR(svn_sqlite__step(&have_row, stmt));

Re: [PATCH] issue #3242: fix another occurence

2010-04-12 Thread C. Michael Pilato
C. Michael Pilato wrote: > Roderich Schupp wrote: >> Hi, >> the fixes for issue 3242 ("Subversion demands unnecessary access >> to parent directories of operations") currently in trunk do not address >> scenario gicen below. >> >> [[[ >> Fix another scenario related to issue #3242: >> >> - user has

Re: [PATCH] sasl service name for svnserve

2010-04-12 Thread 'Stefan Sperling'
On Mon, Apr 12, 2010 at 10:33:03AM +0600, Катаргин Алексей wrote: > -Original Message- > From: Stefan Sperling > >The patch looks technically correct, but I don't understand why it is > >needed. Can you explain why it is needed? > > > >It sounds to me as if you'd like to forward authenticat

Re: [PATCH] issue #3242: fix another occurence

2010-04-12 Thread C. Michael Pilato
Roderich Schupp wrote: > Hi, > the fixes for issue 3242 ("Subversion demands unnecessary access > to parent directories of operations") currently in trunk do not address > scenario gicen below. > > [[[ > Fix another scenario related to issue #3242: > > - user has no access in repo root, only in /

Re: svn commit: r933272 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc_db.c

2010-04-12 Thread Greg Stein
On Mon, Apr 12, 2010 at 11:19, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Mon Apr 12 15:19:23 2010 > @@ -7254,13 +7254,17 @@ svn_wc__db_get_pristine_md5(const svn_ch >   SVN_ERR(svn_sqlite__step(&have_row, stmt)); >   if (!have_row) >     { > -      *md5_checksum = NULL;  /*

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Erik Huelsmann
Hi Philip, On Mon, Apr 12, 2010 at 3:14 PM, Philipp Marek wrote: > Hello Bert! > > On Montag, 12. April 2010, Bert Huijben wrote: >> Well, on Windows consoles are all 80 characters wide. (You can fix this if >> you are a frequent Command Prompt User, but most applications just assume >>  80 chara

Expansion of authz policy name leak (was: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c)

2010-04-12 Thread C. Michael Pilato
Kamesh Jayachandran wrote: >> I would expect that a request to the parent directory would yield a >> listing >> that included the 'calc' and 'watch' repositories, but not the 'lamp' >> one. >> >> Is that the case? >> >> > No. > > These authz rule should *not* list anything inside the repo 'lam

Re: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c

2010-04-12 Thread Kamesh Jayachandran
On 04/12/2010 07:49 PM, C. Michael Pilato wrote: kame...@apache.org wrote: Author: kameshj Date: Mon Apr 12 11:26:28 2010 New Revision: 933194 URL: http://svn.apache.org/viewvc?rev=933194&view=rev Log: [issue2753] Fix issue 2753. Relax requests aimed at the repo Parent path from authz cont

Re: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c

2010-04-12 Thread C. Michael Pilato
kame...@apache.org wrote: > Author: kameshj > Date: Mon Apr 12 11:26:28 2010 > New Revision: 933194 > > URL: http://svn.apache.org/viewvc?rev=933194&view=rev > Log: > [issue2753] Fix issue 2753. > > Relax requests aimed at the repo Parent path from authz control. > > * subversion/mod_authz_svn/m

Re: Subversion Vision and Roadmap Proposal

2010-04-12 Thread C. Michael Pilato
Hyrum K. Wright wrote: > While there has been lots of discussion about aspects of the following, > there really hasn't been any dissent about the core vision and other > ideas presented below. Given that, I propose that we massage this into > a public, web-facing statement, and put it on the websi

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Bert! On Montag, 12. April 2010, Bert Huijben wrote: > Well, on Windows consoles are all 80 characters wide. (You can fix this if > you are a frequent Command Prompt User, but most applications just assume > 80 characters on Windows. And in many cases Windows switches back to 80 > characte

Re: svn commit: r931162 - in /subversion/trunk: ./ subversion/libsvn_diff/parse-diff.c subversion/tests/cmdline/patch_tests.py

2010-04-12 Thread Greg Stein
On Thu, Apr 8, 2010 at 04:32, Bert Huijben wrote: >... >> +def patch_no_index_line(sbox): >> +  "patch with no index lines" >> + >> +  sbox.build() >> +  wc_dir = sbox.wc_dir >> + >> +  patch_file_path = >> tempfile.mkstemp(dir=os.path.abspath(svntest.main.temp_dir))[1] > > This line reintroduces

RE: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Bert Huijben
> -Original Message- > From: Philipp Marek [mailto:philipp.ma...@emerion.com] > Sent: maandag 12 april 2010 14:43 > To: Hyrum K. Wright > Cc: dev; Erik Huelsmann; Stefan Sperling; Johan Corveleyn > Subject: Re: misaligned blame output if repo has >1m revisions > > Hello Hyrum! > > On Mo

Re: svn commit: r932571 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/

2010-04-12 Thread Greg Stein
On Fri, Apr 9, 2010 at 16:16, Greg Stein wrote: > On Fri, Apr 9, 2010 at 16:07,   wrote: >>... >>... >> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri Apr  9 20:07:51 >> 2010 >>... >> @@ -2515,13 +2551,15 @@ svn_wc_status2(svn_wc_status2_t **status >>  { >>   const char *local_abspath

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Hyrum! On Montag, 12. April 2010, Hyrum K. Wright wrote: > On Mon, Apr 12, 2010 at 11:01 AM, Philipp Marek > > So 9 digits should buy a bit of time ;-) > Sure, but the more digits you put in, the more stuff gets pushed off the > back of the line. On a 80-character terminal, with code that's

Re: 1.6.10 up for testing/signing

2010-04-12 Thread Hyrum K. Wright
On Sun, Apr 11, 2010 at 8:27 PM, Joe Swatosh wrote: > Mike and Hyrum, > > On Mon, Apr 5, 2010 at 8:11 AM, C. Michael Pilato > wrote: > > Hyrum K. Wright wrote: > >>> Thanks for the reminder. Merging the changed suggested here (r876245) > does > >>> indeed fix the test failure for me. > >> > >>

Re: Severe performance issues with large directories

2010-04-12 Thread Paul Holden
On 9 Apr 2010 20:59, "Greg Stein" wrote: > Not a new API. Just a revamp of svn_io_open_unique_file3. Compare the > 1.6.x version against trunk. > Paul: if you're adventurous, and build your own svn, you could try > lifting the contents of trunk's svn_io_open_unique_file3, and dropping > that int

Re: [PATCH] Conversion func for translating svn_wc_status3_t to svn_wc_status2_t

2010-04-12 Thread Hyrum K. Wright
+1 On Mon, Apr 12, 2010 at 10:06 AM, Julian Foad wrote: > Daniel Näslund wrote: > > [[[ > > Follow-up to r932571. Since converting a svn_wc_status3_t struct to a > > svn_wc_status2_t dito will be a pretty complex operation, we create a > > function to handle it. > > +1. > > - Julian > > > > * sub

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Hyrum K. Wright
On Mon, Apr 12, 2010 at 11:01 AM, Philipp Marek wrote: > Hello Erik! > > On Montag, 12. April 2010, Erik Huelsmann wrote: > > wrote: > > >http://websvn.kde.org/trunk/ > > >Directory revision: 1113881 > > With 3 additional spaces, that would fit, wouldn't it? > They're doing 100k

RE: Pushmi support

2010-04-12 Thread Bolstridge, Andrew
> -Original Message- > From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of > Hyrum K. Wright > Sent: Friday, April 09, 2010 9:58 PM > To: Stefan Sperling > Cc: Philip Martin; Tim Starling; Greg Stein; Subversion Development > Subject: Re: Pushmi support > > The last thi

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Philipp Marek
Hello Erik! On Montag, 12. April 2010, Erik Huelsmann wrote: > wrote: > >http://websvn.kde.org/trunk/ > >Directory revision: 1113881 > With 3 additional spaces, that would fit, wouldn't it? They're doing 100k revisions in about 8 months: 1013930 => Fri Aug 21 09:33:02 20

Re: misaligned blame output if repo has >1m revisions

2010-04-12 Thread Erik Huelsmann
hi Phil, On Mon, Apr 12, 2010 at 7:54 AM, Philipp Marek wrote: > Hello Johan, > hello Stefan, > > On Freitag, 9. April 2010, Stefan Sperling wrote: >> On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote: >> > So I guess this is coming up for you guys when s.a.o reaches the 1 >> > mill

Re: [PATCH] Conversion func for translating svn_wc_status3_t to svn_wc_status2_t

2010-04-12 Thread Julian Foad
Daniel Näslund wrote: > [[[ > Follow-up to r932571. Since converting a svn_wc_status3_t struct to a > svn_wc_status2_t dito will be a pretty complex operation, we create a > function to handle it. +1. - Julian > * subversion/include/private/svn_wc_private.h > (svn_wc__status2_from_3): New. >

[PATCH] Conversion func for translating svn_wc_status3_t to svn_wc_status2_t

2010-04-12 Thread Daniel Näslund
Hi! I'm letting the func return the old struct in the same manner as svn_wc__cd2_to_cd() works for conflict_description_t. When we start replacing entries, we might need to return and error instead, but since the func will only be used in two places I can easily change parameters and return values