Re: [PATCH] Allow "cease invocation" return from Python callback for repos.svn_repos_history2()

2010-03-17 Thread Роман Донченко
Alexey Neyman писал в своём письме Wed, 17 Mar 2010 00:05:01 +0300: Hi all, The svn_repos_history2() function allows the history_func() to return a special error, SVN_ERR_CEASE_INVOCATION, to stop the search. This is not supported in Python bindings, though: attempt to return core.SVN_ERR_CE

Re: svn commit: r922867 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit.c libsvn_wc/lock.c

2010-03-17 Thread Greg Stein
On Sun, Mar 14, 2010 at 10:36, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/lock.c Sun Mar 14 14:36:26 2010 > @@ -1789,8 +1789,19 @@ svn_wc__acquire_write_lock(const char ** >       SVN_ERR(svn_wc__db_read_kind(&kind, wc_ctx->db, child_abspath, FALSE, >                                

BUG: WC-NG code crawls too high to find WC root (was: "Re: locking problems")

2010-03-17 Thread C. Michael Pilato
C. Michael Pilato wrote: > From time to time, I've seen evidence that our trunk code is walking up too > far in its parent tree as well, but every time I try to create a reliable > recipe, I can't. I have nothing but wc-1 working copies on my system for > day-to-day use. (I run subversion 1.6.x b

Re: svn commit: r924260 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-03-17 Thread Greg Stein
On Wed, Mar 17, 2010 at 08:29, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Wed Mar 17 12:29:14 2010 > @@ -582,22 +582,21 @@ svn_wc__prop_array_to_hash(const apr_arr >                            apr_pool_t *result_pool) >  { >   int i; > -  apr_hash_t *dav_cache; > +  apr_has

Re: svn commit: r924360 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/io.c

2010-03-17 Thread Julian Foad
Stefan Sperling wrote: > > * subversion/libsvn_subr/io.c > > (svn_io_file_mktemp): > > Update prototype. Use svn_path_cstring_from_utf8(), which makes a > > local copy on all operating systems, to make sure apr never tries to > > overwrite read only memory on systems with a utf-8 file

Re: svn commit: r917523 - mod_dav_svn/mirror.c - Are the URIs URI-encoded?

2010-03-17 Thread C. Michael Pilato
C. Michael Pilato wrote: > Julian Foad wrote: >> On Mon, 2010-03-01, kame...@apache.org wrote: >>> Author: kameshj >>> Date: Mon Mar 1 13:48:01 2010 >>> New Revision: 917523 >>> >>> URL: http://svn.apache.org/viewvc?rev=917523&view=rev >>> Log: >>> With the below apache configuration(See the char

Re: svn commit: r917523 - mod_dav_svn/mirror.c - Are the URIs URI-encoded?

2010-03-17 Thread C. Michael Pilato
Julian Foad wrote: > On Mon, 2010-03-01, kame...@apache.org wrote: >> Author: kameshj >> Date: Mon Mar 1 13:48:01 2010 >> New Revision: 917523 >> >> URL: http://svn.apache.org/viewvc?rev=917523&view=rev >> Log: >> With the below apache configuration(See the character "/svn 1/"). >> >> > [...] >>

Re: svn commit: r924360 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/io.c

2010-03-17 Thread Stefan Sperling
On Wed, Mar 17, 2010 at 04:40:51PM -, rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Mar 17 16:40:51 2010 > New Revision: 924360 > > URL: http://svn.apache.org/viewvc?rev=924360&view=rev > Log: > Make svn_io_file_mktemp() behave in the same way on all operating > systems. > > * sub

Re: svn commit: r917523 - mod_dav_svn/mirror.c - Are the URIs URI-encoded?

2010-03-17 Thread Julian Foad
On Mon, 2010-03-01, kame...@apache.org wrote: > Author: kameshj > Date: Mon Mar 1 13:48:01 2010 > New Revision: 917523 > > URL: http://svn.apache.org/viewvc?rev=917523&view=rev > Log: > With the below apache configuration(See the character "/svn 1/"). > > [...] > Write through proxy is *not* h

Re: svn commit: r924236 - /subversion/trunk/subversion/libsvn_client/copy.c

2010-03-17 Thread Julian Foad
phi...@apache.org wrote: > > +struct repos_to_wc_copy_baton { > + const apr_array_header_t *copy_pairs; > + const char *top_dst_path; > + svn_boolean_t ignore_externals; > + svn_ra_session_t *ra_session; > + svn_client_ctx_t *ctx; > +}; > + > +static svn_error_t * > +repos_to_wc_copy_cb(void

Re: svn commit: r924229 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc.h

2010-03-17 Thread Julian Foad
C. Michael Pilato wrote: > julianf...@apache.org wrote: > > Author: julianfoad > > Date: Wed Mar 17 11:33:45 2010 > > New Revision: 924229 > > > > URL: http://svn.apache.org/viewvc?rev=924229&view=rev > > Log: > > Rename a function parameter to match the doc string. A follow-up to r921503. > > >

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-17 Thread Julian Foad
On Wed, 2010-03-17, C. Michael Pilato wrote: > Julian Foad wrote: > > On Thu, 2010-03-11, I (Julian Foad) wrote: > >> Excellent, too. Just one nit: it looks like you intended to rename the > >> argument "wcprop_changes" to "props". > > > > Renamed in r924229. > > Thanks. For the record, I hadn'

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-17 Thread C. Michael Pilato
Julian Foad wrote: > On Thu, 2010-03-11, I (Julian Foad) wrote: >> Excellent, too. Just one nit: it looks like you intended to rename the >> argument "wcprop_changes" to "props". > > Renamed in r924229. Thanks. For the record, I hadn't ignored your review -- I just had left the changes sitting

Re: svn commit: r924229 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc.h

2010-03-17 Thread C. Michael Pilato
julianf...@apache.org wrote: > Author: julianfoad > Date: Wed Mar 17 11:33:45 2010 > New Revision: 924229 > > URL: http://svn.apache.org/viewvc?rev=924229&view=rev > Log: > Rename a function parameter to match the doc string. A follow-up to r921503. > > * subversion/libsvn_wc/wc.h, > subversio

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-17 Thread Julian Foad
On Thu, 2010-03-11, I (Julian Foad) wrote: > Excellent, too. Just one nit: it looks like you intended to rename the > argument "wcprop_changes" to "props". Renamed in r924229. - Julian

Re: Will subversion participate in Google Summer of Code 2010?

2010-03-17 Thread Stefan Sperling
On Sun, Mar 14, 2010 at 12:34:30PM +0100, Daniel Näslund wrote: > Ok, I've already mentioned it but here's my main suggestion: > > Git diff format > - > svn {diff,patch} should be able to use the git diff format. That would > allow us to use patches for tree and mode changes. It sh

Re: Valid values of svn_merge_range_t - no change number zero

2010-03-17 Thread Julian Foad
On Tue, 2010-03-16, Paul Burba wrote: > Your patch looks good to me. It passes all tests [fsfs x ra_local] > and I can't see that it will introduce any problems. I assume the > mergeinfo_tests.py 2 failure you mentioned at the start of the thread > was solved in v2? Thanks. Yes, the test failur