Re: [RFC] MTime functional specifications (v2.0)

2010-02-04 Thread Philipp Marek
Hello Ed, some more comments. On Freitag, 5. Februar 2010, Ed wrote: >+Issue #1256 was entered into the Subversion issue tracker on 24th April > +2003 and has been opened since then. A few patches have been submitted; There's even a branch with a full implementation in the subversion repository

Re: [PATCH] Fix failing ci caused in r40202

2010-02-04 Thread Kannan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: > But that's not right. Like I said before, the variable holds different > kinds of data at different times. (If we this variable was intended to > always hold a URL, we would want the variable's name to indicate so.) > > It is wron

[RFC] MTime functional specifications (v2.0)

2010-02-04 Thread Ed
Hi, First, some commentary. I realized that the previous specification was absolutely terrible and I do appreciate everyone's patience with me (esp Philip Martin, Philipp Marek and Julian Foad). Their commentary made me realize that all the while, I had a small monkey on my back. Over the perio

wc-ng question -- is this an optimization?

2010-02-04 Thread Neels J Hofmeyr
In this commit, I run svn_wc__db_read_info() in check_tree_conflicts(), when half or more of its callers have already called svn_wc__db_read_info(). So would it be an optimization to pass STATUS, maybe more, as args to check_tree_conflict(), rather than calling svn_wc__db_read_info() twice? Code r

Re: [PATCH] Test context within fuzzy hunk for 'svn patch'

2010-02-04 Thread Stefan Sperling
On Thu, Feb 04, 2010 at 08:11:00PM +0100, Daniel Näslund wrote: > Hi! > > [[[ > * subversion/tests/cmdline/patch_tests.py > (patch_with_fuzz): Add context in the middle of one of the fuzzy > hunks. > > Patch by: Daniel Näslund > ]]] Can you explain why? > Index: subversion/tests/cmdline/

[PATCH] Test context within fuzzy hunk for 'svn patch'

2010-02-04 Thread Daniel Näslund
Hi! [[[ * subversion/tests/cmdline/patch_tests.py (patch_with_fuzz): Add context in the middle of one of the fuzzy hunks. Patch by: Daniel Näslund ]]] Index: subversion/tests/cmdline/patch_tests.py === --- subversion/tests/cmd

Re: Obliterate - milestone 1 reached: the most basic obliteration

2010-02-04 Thread Julian Foad
On Thu, 2010-02-04 at 17:25 +0100, Lieven Govaerts wrote: > On Thu, Jan 28, 2010 at 1:00 PM, Julian Foad wrote: > > Hi, fans of "obliterate". > > > > I am pleased to announce that a very restricted form of "svn obliterate" > > is now working. > > > > According to the plan > >

Re: [PATCH] Fix failing ci caused in r40202

2010-02-04 Thread Julian Foad
Kannan wrote: > Assertion failure occurred due to a non-canonical base URL passed to > `svn_path_url_add_component2()'. Despite having canonicalized them > wherever they are generated, the reason for this was that in > `end_element()' of props.c, canonicalization was done where the url was > assign

Re: [PATCH] Fix bug: svn patch does not find hunks in file with missing newline at end

2010-02-04 Thread Daniel Näslund
Oups, debug statements and trailing white spaces. Here's a new one. On Thu, Feb 04, 2010 at 06:27:46PM +0100, Daniel Näslund wrote: > Hi! > > [[[ > Fix bug with 'svn patch' not recognizing hunks with missing newline at > end of patch file. > > * subversion/libsvn_diff/parse-diff.c > (parse_ne

[PATCH] Fix bug: svn patch does not find hunks in file with missing newline at end

2010-02-04 Thread Daniel Näslund
Hi! [[[ Fix bug with 'svn patch' not recognizing hunks with missing newline at end of patch file. * subversion/libsvn_diff/parse-diff.c (parse_next_hunk): Don't stop reading lines until we've reached eof and the line read is empty. * subversion/tests/cmdline/patch_tests.py (patch_with_fu

Re: [PATCH] Fix failing ci caused in r40202

2010-02-04 Thread Kannan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > I committed the patch (with that fix) in 901797. > > Thanks for the patch. > > Now I am running the test suite on your patch to use > svn_path_url_add_component2(), >

Re: Obliterate - milestone 1 reached: the most basic obliteration

2010-02-04 Thread Lieven Govaerts
On Thu, Jan 28, 2010 at 1:00 PM, Julian Foad wrote: > Hi, fans of "obliterate". > > I am pleased to announce that a very restricted form of "svn obliterate" > is now working. > > According to the plan > , > I

RE: community guide redux

2010-02-04 Thread Jon Foster
Hi, Justin Erenkrantz wrote: > http://subversion.apache.org/docs/community-guide/general.html This looks nice. One minor nit: is there any way you can make the word-wrapped entries in the left-nav menu more obvious? For me, it looks like this: > Participating in the > community > Theory and >

Re: Question on svnsync - want to quickly start from rev 800000

2010-02-04 Thread Philip Martin
Julian Foad writes: > (How to quickly generate empty revisions? Using the bindings should be > fast and might let you commit a completely empty revision. "svnmucc" and > "svn" do not let you commit an empty revision, You can use dump/load and svndumpfilter to generate empty revisions: rm -rf

Re: Question on svnsync - want to quickly start from rev 800000

2010-02-04 Thread Julian Foad
On Wed, 2010-02-03, Karl Heinz Marbaise wrote: > Hi, > > i have observed a strange behaviour of svnsync in partially replicating > a repository (In my opinion).. > > Created a local repository (svnadmin create...) change the > pre-revprop-change hook to accept changes...and then > i initializ

Re: [WIP] tests for svn_client_blame5 and svn_repos_get_file_revs2

2010-02-04 Thread Lieven Govaerts
Trying attachment again, now with .txt extension. On Thu, Feb 4, 2010 at 11:10 AM, Lieven Govaerts wrote: > Attached some tests I'm working on for svn_client_blame5 and > svn_repos_get_file_revs2. > > I started moving some code to create a repository, ra session (...) to > tests/svn_test_fs.c so

[WIP] tests for svn_client_blame5 and svn_repos_get_file_revs2

2010-02-04 Thread Lieven Govaerts
Attached some tests I'm working on for svn_client_blame5 and svn_repos_get_file_revs2. I started moving some code to create a repository, ra session (...) to tests/svn_test_fs.c so that these can be reused in other tests. The test for svn_client_blame5 isn't finished yet. @DanielN: This might be

Re: svn commit: r905916 - /subversion/site/publish/site-nav.html

2010-02-04 Thread Julian Foad
On Wed, 2010-02-03, Justin Erenkrantz wrote: > Oh, BTW, I know you're going to hate me, but ASF policy is that every > project site has a reasonably-prominent link to: > > http://www.apache.org/foundation/thanks.html > > (It can be either "Thanks" or "Sponsors" or something related to that > phra

Re: community guide redux

2010-02-04 Thread Julian Foad
Justin Erenkrantz wrote: > http://subversion.apache.org/docs/community-guide/general.html > > http://subversion.apache.org/docs/community-guide/index-onepage.html > > (Outside of, well, this post, it's not hooked up to the rest of the > site - IOW, the old index.html is still in place. So, I'm g

community guide redux

2010-02-04 Thread Justin Erenkrantz
http://subversion.apache.org/docs/community-guide/general.html http://subversion.apache.org/docs/community-guide/index-onepage.html (Outside of, well, this post, it's not hooked up to the rest of the site - IOW, the old index.html is still in place. So, I'm going with C-T-R for now.) I took a s