Re: svn commit: r894053 - in /subversion/trunk/subversion/libsvn_ra_serf: auth.c ra_serf.h serf.c util.c

2009-12-28 Thread Lieven Govaerts
On Mon, Dec 28, 2009 at 11:40 PM, Hyrum K. Wright wrote: > > On Dec 27, 2009, at 4:57 AM, l...@apache.org wrote: > >> Author: lgo >> Date: Sun Dec 27 10:57:39 2009 >> New Revision: 894053 >> >> URL: http://svn.apache.org/viewvc?rev=894053&view=rev >> Log: >> ra_serf: Use the new serf API for serf-

Re: 1.6.7 up for signing/testing

2009-12-28 Thread Bhuvaneswaran A
On Thu, 2009-12-24 at 15:46 +0100, Stefan Sperling wrote: > > I have seen failures like these when I accidentally built svn without > any support for iconv. > > Bhuvaneswaran, are you linking to either GNU libiconv or APR-iconv? > Could it be that Solaris' native iconv implementation (if there is

RE: 1.6.7 up for signing/testing

2009-12-28 Thread Bhuvaneswaran A
On Thu, 2009-12-24 at 10:40 +0100, Bert Huijben wrote: > > All these errors are related to converting characters to and from > UTF8. It could be that these characters can't be represented in the > system locale or that the iconv library has limited support for > converting from the encoding used b

Re: [PATCH] Sticky depths should work for an excluded dir

2009-12-28 Thread Kannan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kannan wrote: > > Hi, > > As of now, after excluding a DIR using `--set-depth', for eg, `svn up > --set-depth=exclude foo', its possible to redefine foo's depth only as > infinity and not as (empty|files|immediates). Attached herewith is the > patch

Re: svn commit: r894053 - in /subversion/trunk/subversion/libsvn_ra_serf: auth.c ra_serf.h serf.c util.c

2009-12-28 Thread Hyrum K. Wright
On Dec 27, 2009, at 4:57 AM, l...@apache.org wrote: > Author: lgo > Date: Sun Dec 27 10:57:39 2009 > New Revision: 894053 > > URL: http://svn.apache.org/viewvc?rev=894053&view=rev > Log: > ra_serf: Use the new serf API for serf-based authentication. Remove support > for > Basic authentication,

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Hyrum K. Wright
On Dec 28, 2009, at 2:09 PM, Hyrum K. Wright wrote: > > On Dec 28, 2009, at 1:47 PM, Joe Swatosh wrote: > >> On Mon, Dec 28, 2009 at 11:44 AM, Stefan Sperling wrote: >>> On Mon, Dec 28, 2009 at 11:25:29AM -0800, Joe Swatosh wrote: This buildbot is still failing the build before the tests

Re: [PATCH] #3483 - Extend svn_client_upgrade() to include externals

2009-12-28 Thread Daniel Näslund
On Mon, Dec 28, 2009 at 10:31:15PM +0100, Daniel Näslund wrote: > Hi! > > [[[ > Fix issue #3483 - extend svn_client_upgrade() to include externals. I've > done the externals upgrading after wc upgrade is finished. In that way > no errors in the externals will affect the wc. > > * subversion/libsv

[PATCH] #3483 - Extend svn_client_upgrade() to include externals

2009-12-28 Thread Daniel Näslund
Hi! [[[ Fix issue #3483 - extend svn_client_upgrade() to include externals. I've done the externals upgrading after wc upgrade is finished. In that way no errors in the externals will affect the wc. * subversion/libsvn_client/cleanup.c (svn_client_upgrade): Get all svn:externals. We need the ta

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Hyrum K. Wright
On Dec 28, 2009, at 1:47 PM, Joe Swatosh wrote: > On Mon, Dec 28, 2009 at 11:44 AM, Stefan Sperling wrote: >> On Mon, Dec 28, 2009 at 11:25:29AM -0800, Joe Swatosh wrote: >>> This buildbot is still failing the build before the tests are even >>> run. Something to do with libtool? >> >>> /usr/s

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Joe Swatosh
On Mon, Dec 28, 2009 at 11:44 AM, Stefan Sperling wrote: > On Mon, Dec 28, 2009 at 11:25:29AM -0800, Joe Swatosh wrote: >> This buildbot is still failing the build before the tests are even >> run.  Something to do with libtool? > >> /usr/share/apr-1.0/build/libtool: line 970: none: command not fo

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 11:25:29AM -0800, Joe Swatosh wrote: > This buildbot is still failing the build before the tests are even > run. Something to do with libtool? > /usr/share/apr-1.0/build/libtool: line 970: none: command not found > make: *** [subversion/bindings/swig/ruby/svn_client.lo] Er

Re: svn trunk r894053: FAIL (x64-ubuntu gcc)

2009-12-28 Thread Joe Swatosh
This buildbot is still failing the build before the tests are even run. Something to do with libtool? Thanks, -- Joe >From the end of the build report: + echo '= make swig-rb' = make swig-rb + make swig-rb -j1 /usr/share/apr-1.0/build/libtool --tag=CC --silent --mode=compile non

Re: 1.6.7 up for signing/testing

2009-12-28 Thread Joe Swatosh
On Sat, Dec 26, 2009 at 11:24 AM, Stefan Sperling wrote: > On Wed, Dec 23, 2009 at 09:35:23AM -0600, Hyrum K. Wright wrote: >> Please be sure to test the bindings. > > Also, a ruby bindings test segfaults. > > I've found this in an OpenBSD ports build, hence no debug symbols > in this trace. I can

Re: [PATCH] v5 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 03:36:46PM +0100, Daniel Näslund wrote: > + /* If we're doing an 'svn export' the current dir will not be a > + working copy. We can't get the parent_dir. */ > + if (err && err->apr_err == SVN_ERR_WC_NOT_WORKING_COPY) > +{ > + if (err->apr_err == SVN_ERR_WC_N

Re: [PATCH] v5 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Daniel Näslund
On Mon, Dec 28, 2009 at 02:05:02PM +, Stefan Sperling wrote: > > + svn_error_clear(err); > > +} > > + else if (err) > > + svn_error_return(err); > > return svn_error_return(err); > ^^ Fixed! > > + else > > + ib.parent_dir_url = url; > > And maybe w

Re: [PATCH] v4 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 02:39:50PM +0100, Daniel Näslund wrote: > On Mon, Dec 21, 2009 at 02:40:46PM +, Philip Martin wrote: > > Daniel Näslund writes: > > > > > + /* First try to get the associated url and if there is none as is the > > > case > > > + * for exports then do use the user s

Re: [PATCH] v4 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 02:39:50PM +0100, Daniel Näslund wrote: > My New Years resolution will be to > not consider a solution finished until I've understood every part of it. But how can you be 100% sure that you've understood every part of it? :) Stefan

Re: [PATCH] v4 Fix #3390 Relative externals not updated during switch

2009-12-28 Thread Daniel Näslund
On Mon, Dec 21, 2009 at 02:40:46PM +, Philip Martin wrote: > Daniel Näslund writes: > > > + /* First try to get the associated url and if there is none as is the > > case > > + * for exports then do use the user supplied values. */ > > + err = svn_wc__node_get_url(&url, cb->ctx->wc_ctx,

Re: client-side hooks

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 01:10:29PM +0100, Miha Vitorovic wrote: > On 12/28/2009 01:03 PM, Stefan Sperling wrote: > >On Mon, Dec 28, 2009 at 12:21:34PM +0100, Miha Vitorovic wrote: > >>I'm just a lurker, so my apologies if I'm missing something obvious, > >>but isn't it much simpler to support clien

Re: client-side hooks

2009-12-28 Thread Miha Vitorovic
On 12/28/2009 01:03 PM, Stefan Sperling wrote: On Mon, Dec 28, 2009 at 12:21:34PM +0100, Miha Vitorovic wrote: I'm just a lurker, so my apologies if I'm missing something obvious, but isn't it much simpler to support client side hooks on a Windows only client (like Tortoise clearly is)?

Re: client-side hooks

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 12:21:34PM +0100, Miha Vitorovic wrote: > I'm just a lurker, so my apologies if I'm missing something obvious, > but isn't it much simpler to support client side hooks on a Windows > only client (like Tortoise clearly is)? It's up to the authors of hook scripts to make sure

Re: client-side hooks

2009-12-28 Thread Miha Vitorovic
On 12/28/2009 12:13 PM, Stefan Sperling wrote: On Mon, Dec 28, 2009 at 06:38:32AM +0100, Branko Čibej wrote: Stefan Sperling wrote: Client-side hooks can do very interesting things. I've seen people pick TortoiseSVN as their only client because it has this feature. Just like server-si

Re: client-side hooks

2009-12-28 Thread Stefan Sperling
On Mon, Dec 28, 2009 at 06:38:32AM +0100, Branko Čibej wrote: > Stefan Sperling wrote: > > Client-side hooks can do very interesting things. > > I've seen people pick TortoiseSVN as their only client because it has this > > feature. Just like server-side hooks, it allows for a higher degree of > >