jnioche commented on PR #1250:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1250#issuecomment-2220969022
This is a substantial change that could have an impact on how things work in
SC. It needs careful reviewing, annoyingly I don't have much time to do that at
the moment but
pjfanning commented on PR #1250:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1250#issuecomment-2220994228
My gut reaction is that adding even more shared state to the classes is not
a good way to go.
How about just using a ReentrantLock to wrap the code where there is
pjfanning commented on PR #1250:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1250#issuecomment-2220999541
The solutions applied in okhttp and httpclient classes seem very different.
It would greatly simply review to have 2 different PRs that can be reviewed
independently.
