[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 137a288fd89a27b4d902af49820b6a2a370f15bf / Richard Zowalla Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" Report U

[PR] Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 opened a new pull request, #1227: URL: https://github.com/apache/incubator-stormcrawler/pull/1227 Thank you for contributing to Apache StormCrawler. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For al

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 137a288fd89a27b4d902af49820b6a2a370f15bf / Richard Zowalla Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" Report U

[GH] (incubator-stormcrawler): Workflow run "Code Coverage" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Code Coverage" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 5c8f720862e94cc2b5227d9484845bb38bdb5898 / Richard Zowalla Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" Report URL: h

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" is working again!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has succeeded. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 5c8f720862e94cc2b5227d9484845bb38bdb5898 / Richard Zowalla Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" Repor

[GH] (incubator-stormcrawler): Workflow run "Code Coverage" is working again!

2024-05-17 Thread GitBox
The GitHub Actions job "Code Coverage" on incubator-stormcrawler.git has succeeded. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 5c8f720862e94cc2b5227d9484845bb38bdb5898 / Richard Zowalla Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" Report URL

Re: [PR] Fix #1226 "Add FileSpout TestCase for Custom Metadata Injections" [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche merged PR #1227: URL: https://github.com/apache/incubator-stormcrawler/pull/1227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[I] Fix link to Javadocs and content of getting started [incubator-stormcrawler-site]

2024-05-17 Thread via GitHub
jnioche opened a new issue, #29: URL: https://github.com/apache/incubator-stormcrawler-site/issues/29 Link to Javadocs should be [https://javadoc.io/doc/org.apache.stormcrawler/stormcrawler-core/3.0/index.html](https://javadoc.io/doc/org.apache.stormcrawler/stormcrawler-core/3.0/index.html)

[PR] Fix link to Javadocs and content of getting started, fix #29 [incubator-stormcrawler-site]

2024-05-17 Thread via GitHub
jnioche opened a new pull request, #30: URL: https://github.com/apache/incubator-stormcrawler-site/pull/30 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Fix link to Javadocs and content of getting started [incubator-stormcrawler-site]

2024-05-17 Thread via GitHub
rzo1 closed issue #29: Fix link to Javadocs and content of getting started URL: https://github.com/apache/incubator-stormcrawler-site/issues/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix link to Javadocs and content of getting started, fix #29 [incubator-stormcrawler-site]

2024-05-17 Thread via GitHub
rzo1 merged PR #30: URL: https://github.com/apache/incubator-stormcrawler-site/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@s

[PR] 1024 Playwright protocol implementation, fixes #1024 [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche opened a new pull request, #1228: URL: https://github.com/apache/incubator-stormcrawler/pull/1228 Thank you for contributing to Apache StormCrawler. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

Re: [PR] 1024 Playwright protocol implementation, fixes #1024 [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 commented on code in PR #1228: URL: https://github.com/apache/incubator-stormcrawler/pull/1228#discussion_r1604728687 ## THIRD-PARTY.txt: ## @@ -136,6 +136,7 @@ List of third-party dependencies grouped by their license type. * FindBugs-jsr305 (com.google.code.fin

Re: [PR] 1024 Playwright protocol implementation, fixes #1024 [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 commented on PR #1228: URL: https://github.com/apache/incubator-stormcrawler/pull/1228#issuecomment-2117263513 A great addition to SC! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Implements a unit test for Playwright PR [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 opened a new pull request, #1229: URL: https://github.com/apache/incubator-stormcrawler/pull/1229 - Implements a unit test to actually test that playwright is rendering HTML/JS content correctly. - Adds an option to specify wait until state to ensure JS is executed properly - Rem

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 88e89f40120a5892bf882c1038cce06f5cdd15e6 / Richard Zowalla Implements a unit test to actually test that playwright is rendering HTML/J

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" is working again!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has succeeded. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 88e89f40120a5892bf882c1038cce06f5cdd15e6 / Richard Zowalla Implements a unit test to actually test that playwright is rendering HTM

Re: [PR] Implements a unit test for Playwright PR [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 commented on PR #1229: URL: https://github.com/apache/incubator-stormcrawler/pull/1229#issuecomment-2117508713 And I think now, that we are actually doing rendering, the tests will fail on GH actions because of ``` ╔══╗

Re: [PR] Implements a unit test for Playwright PR [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 commented on PR #1229: URL: https://github.com/apache/incubator-stormcrawler/pull/1229#issuecomment-2117517054 Added a flag to skip those tests in GH actions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 6f4eb9724cca71671f43b80f64e5c333459217d9 / Richard Zowalla Skip playwright tests in CI as GH action cannot execute them due to missing

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" failed!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has failed. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 6f4eb9724cca71671f43b80f64e5c333459217d9 / Richard Zowalla Skip playwright tests in CI as GH action cannot execute them due to missing

[GH] (incubator-stormcrawler): Workflow run "Java CI with Maven" is working again!

2024-05-17 Thread GitBox
The GitHub Actions job "Java CI with Maven" on incubator-stormcrawler.git has succeeded. Run started by GitHub user rzo1 (triggered by rzo1). Head commit for run: 4519d593914342b3d113e88fd9ba2ef256eda945 / Richard Zowalla Fix formatting Report URL: https://github.com/apache/incubator-stormcr

Re: [PR] 1024 Playwright protocol implementation, fixes #1024 [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche commented on code in PR #1228: URL: https://github.com/apache/incubator-stormcrawler/pull/1228#discussion_r1604993382 ## THIRD-PARTY.txt: ## @@ -136,6 +136,7 @@ List of third-party dependencies grouped by their license type. * FindBugs-jsr305 (com.google.code.

Re: [PR] Implements a unit test for Playwright PR [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche merged PR #1229: URL: https://github.com/apache/incubator-stormcrawler/pull/1229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [I] Redirected sitemaps in SiteMapParserBolt / SiteMapFilter [incubator-stormcrawler]

2024-05-17 Thread via GitHub
rzo1 commented on issue #1230: URL: https://github.com/apache/incubator-stormcrawler/issues/1230#issuecomment-2117611637 Feel free to provide a PR with a fix. We can follow up with a more efficient approach in an additional PR. WDYT? -- This is an automated message from the Apache Git

Re: [PR] 1024 Playwright protocol implementation, fixes #1024 [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche merged PR #1228: URL: https://github.com/apache/incubator-stormcrawler/pull/1228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [I] Add support for Playwright [incubator-stormcrawler]

2024-05-17 Thread via GitHub
jnioche closed issue #1024: Add support for Playwright URL: https://github.com/apache/incubator-stormcrawler/issues/1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu