Re: [PR] #1560 - Test coverage for Solr cloud [stormcrawler]

2025-07-22 Thread via GitHub
mvolikas commented on code in PR #1608: URL: https://github.com/apache/stormcrawler/pull/1608#discussion_r923867 ## external/solr/src/test/java/org/apache/stormcrawler/solr/bolt/IndexerBoltTest.java: ## @@ -14,7 +14,7 @@ * See the License for the specific language governin

Re: [PR] #1560 - Test coverage for Solr cloud [stormcrawler]

2025-07-22 Thread via GitHub
sigee commented on code in PR #1608: URL: https://github.com/apache/stormcrawler/pull/1608#discussion_r834211 ## external/solr/src/test/java/org/apache/stormcrawler/solr/bolt/IndexerBoltTest.java: ## @@ -14,7 +14,7 @@ * See the License for the specific language governing p

Re: [PR] #1560 - Test coverage for Solr cloud [stormcrawler]

2025-07-22 Thread via GitHub
sigee commented on code in PR #1608: URL: https://github.com/apache/stormcrawler/pull/1608#discussion_r834211 ## external/solr/src/test/java/org/apache/stormcrawler/solr/bolt/IndexerBoltTest.java: ## @@ -14,7 +14,7 @@ * See the License for the specific language governing p

[GH] (stormcrawler/feature-1560): Workflow run "Java CI with Maven" is working again!

2025-07-22 Thread GitBox
The GitHub Actions job "Java CI with Maven" on stormcrawler.git/feature-1560 has succeeded. Run started by GitHub user mvolikas (triggered by mvolikas). Head commit for run: 69e45870486d52fb55d105ad296feb34cfdf9baa / Markos Volikas #1560 fix formatting Report URL: https://github.com/apache/st

Re: [PR] #1560 - Test coverage for Solr cloud [stormcrawler]

2025-07-22 Thread via GitHub
mvolikas commented on PR #1608: URL: https://github.com/apache/stormcrawler/pull/1608#issuecomment-3103014879 > Hi, > > thanks :) - just a quick question: Is is necessary to rely on Junit 4 (`@Rule`) or would it be possible to use JUnit 5 (i.e. by writing an extension or callback) ?

[GH] (stormcrawler/feature-1560): Workflow run "Java CI with Maven" failed!

2025-07-22 Thread GitBox
The GitHub Actions job "Java CI with Maven" on stormcrawler.git/feature-1560 has failed. Run started by GitHub user mvolikas (triggered by mvolikas). Head commit for run: e880405343060993cd63666b7ce9815e8bbac523 / Markos Volikas #1560 migrate to junit 5 Report URL: https://github.com/apache/s

Re: [PR] Fix java 5 language level issues [stormcrawler]

2025-07-22 Thread via GitHub
rzo1 commented on PR #1609: URL: https://github.com/apache/stormcrawler/pull/1609#issuecomment-3101976837 Thanks @sigee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix java 5 language level issues [stormcrawler]

2025-07-22 Thread via GitHub
rzo1 merged PR #1609: URL: https://github.com/apache/stormcrawler/pull/1609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler

[GH] (stormcrawler/fix-java5-issues): Workflow run "Java CI with Maven" is working again!

2025-07-22 Thread GitBox
The GitHub Actions job "Java CI with Maven" on stormcrawler.git/fix-java5-issues has succeeded. Run started by GitHub user sigee (triggered by jnioche). Head commit for run: a663bdf5ca556fdcc14fbdfb75a6e5cdd3129aa3 / Sigee Replace StringBuffer with StringBuilder Report URL: https://github.com

Re: [PR] Refactor SQL module to use PreparedStatement (#1611) [stormcrawler]

2025-07-22 Thread via GitHub
jnioche commented on PR #1612: URL: https://github.com/apache/stormcrawler/pull/1612#issuecomment-3101370872 Thanks for contributing @ferCancholaCruz Can you please reinstate the license headers and comments that your PR removed? Also please run the formatting with `mvn git-cod