[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237795529 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -37,16 +42,28 @@ private static final String HIVE_TYPE_STRING = "STRING"; private s

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704486#comment-16704486 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user szvasas commented on a diff in

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Szabolcs Vasas
Hi Attila, I think we won't be able to commit the pull requests on GitHub directly because our GitHub repo is just a mirror of the original Apache Sqoop repo . However the commit process is still simplified, the ASF GitHub Bot JIRA comment contain

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704560#comment-16704560 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user fszabo2 commented on a diff in

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread fszabo2
Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237817782 --- Diff: src/test/org/apache/sqoop/hive/numerictypes/NumericTypesHiveImportTest.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software Fo

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Attila Szabó
Hey Szabi, Thanks for the prompt response! I've thought the repos are connected back and forth and the close PR is the official way. In case of we still stack to the patch file and git apply then commit and push approach. My only question in this case : Do we have any agreement on how we commit

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Szabolcs Vasas
Thanks for the question, I think we should stick to the commit format we had earlier so yes, we should go for squash and push. The easiest solution could be to download the diff file instead of the patch (e.g. https://github.com/apache/sqoop/pull/60.diff instead of https://github.com/apache/sqoop/p

[jira] [Commented] (SQOOP-3410) Test S3 import with fs.s3a.security.credential.provider.path

2018-11-30 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704807#comment-16704807 ] Steve Loughran commented on SQOOP-3410: --- FWIW, that option was put in to let people

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread fszabo2
Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237881838 --- Diff: src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java --- @@ -65,4 +66,21 @@ public String toString() {

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704819#comment-16704819 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user fszabo2 commented on a diff in

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread fszabo2
Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237890806 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -37,16 +42,28 @@ private static final String HIVE_TYPE_STRING = "STRING"; private s

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704873#comment-16704873 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user fszabo2 commented on a diff in

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread fszabo2
Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r237894381 --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java --- @@ -37,16 +42,28 @@ private static final String HIVE_TYPE_STRING = "STRING"; private s

[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-30 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/62#discussion_r237896212 --- Diff: build.gradle --- @@ -356,6 +359,15 @@ tasks.withType(Test) { ignoreFailures ignoreTestFailures } +project.tasks.each { +

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704895#comment-16704895 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user fszabo2 commented on a diff in

[jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704902#comment-16704902 ] ASF GitHub Bot commented on SQOOP-3415: --- Github user szvasas commented on a diff in

[jira] [Created] (SQOOP-3416) Give the default value of /var/lib/sqoop to the sqoopThirdPartyLib variable in the gradle build

2018-11-30 Thread Fero Szabo (JIRA)
Fero Szabo created SQOOP-3416: - Summary: Give the default value of /var/lib/sqoop to the sqoopThirdPartyLib variable in the gradle build Key: SQOOP-3416 URL: https://issues.apache.org/jira/browse/SQOOP-3416

[jira] [Commented] (SQOOP-3410) Test S3 import with fs.s3a.security.credential.provider.path

2018-11-30 Thread Boglarka Egyed (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704947#comment-16704947 ] Boglarka Egyed commented on SQOOP-3410: --- Hey [~ste...@apache.org], Thanks for poin

[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...

2018-11-30 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/62#discussion_r237962514 --- Diff: build.gradle --- @@ -356,6 +359,15 @@ tasks.withType(Test) { ignoreFailures ignoreTestFailures } +project.tasks.each { +

[jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705159#comment-16705159 ] ASF GitHub Bot commented on SQOOP-3415: --- Github user maugly24 commented on a diff i

[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

2018-11-30 Thread maugly24
Github user maugly24 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r238013139 --- Diff: src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java --- @@ -65,4 +66,21 @@ public String toString() {

[jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705314#comment-16705314 ] ASF GitHub Bot commented on SQOOP-3396: --- Github user maugly24 commented on a diff i