Re: Review Request 42809: SQOOP-2649 : Support for importing data onto Apache Phoenix tables

2016-04-12 Thread Ravi Magham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42809/ --- (Updated April 12, 2016, 7:02 a.m.) Review request for Sqoop and Venkat Rangana

[GitHub] sqoop pull request: Optimize toAvroIdentifier

2016-04-12 Thread stanleyxu2005
Github user stanleyxu2005 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/18#discussion_r59337930 --- Diff: src/java/org/apache/sqoop/avro/AvroUtil.java --- @@ -114,11 +114,20 @@ public static String toAvroColumn(String column) { * Format candid

[GitHub] sqoop pull request: Optimize toAvroIdentifier

2016-04-12 Thread JoeriHermans
Github user JoeriHermans commented on the pull request: https://github.com/apache/sqoop/pull/18#issuecomment-208796233 @stanleyxu2005 Why would you check if data has valid length? The original code also crashes if an empty string is specified, so I didn't bother with checking for vali

[GitHub] sqoop pull request: [SQOOP-2906] Optimize toAvroIdentifier

2016-04-12 Thread stanleyxu2005
Github user stanleyxu2005 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/18#discussion_r59360059 --- Diff: src/java/org/apache/sqoop/avro/AvroUtil.java --- @@ -114,11 +114,20 @@ public static String toAvroColumn(String column) { * Format candid

[jira] [Commented] (SQOOP-2906) Optimization of AvroUtil.toAvroIdentifier

2016-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237015#comment-15237015 ] ASF GitHub Bot commented on SQOOP-2906: --- Github user stanleyxu2005 commented on a di

[GitHub] sqoop pull request: [SQOOP-2906] Optimize toAvroIdentifier

2016-04-12 Thread JoeriHermans
Github user JoeriHermans commented on the pull request: https://github.com/apache/sqoop/pull/18#issuecomment-208859666 @stanleyxu2005 The main difference in my implementation is that I only have to do a single copy. StringBuilders are inefficient, char arrays are a lot faster since ev

[jira] [Commented] (SQOOP-2906) Optimization of AvroUtil.toAvroIdentifier

2016-04-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237026#comment-15237026 ] ASF GitHub Bot commented on SQOOP-2906: --- Github user JoeriHermans commented on the p

[jira] [Updated] (SQOOP-2903) Add Kudu connector for Sqoop

2016-04-12 Thread Sameer Abhyankar (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer Abhyankar updated SQOOP-2903: Attachment: SQOOP-2903.1.patch > Add Kudu connector for Sqoop >

[jira] [Commented] (SQOOP-2903) Add Kudu connector for Sqoop

2016-04-12 Thread Sameer Abhyankar (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237171#comment-15237171 ] Sameer Abhyankar commented on SQOOP-2903: - I think I figured out how the dependenc

[jira] [Commented] (SQOOP-2891) Repository encryption documentation

2016-04-12 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237376#comment-15237376 ] Abraham Fine commented on SQOOP-2891: - i do not think that the tests failures are rele

[jira] [Commented] (SQOOP-2891) Repository encryption documentation

2016-04-12 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237605#comment-15237605 ] Sqoop QA bot commented on SQOOP-2891: - Testing file [SQOOP-2891.patch|https://issues.

Re: Review Request 46063: SQOOP-2900

2016-04-12 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46063/ --- (Updated April 12, 2016, 7:24 p.m.) Review request for Sqoop. Bugs: SQOOP-290

[jira] [Updated] (SQOOP-2900) Support encrypting map inputs with sensitive fields

2016-04-12 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2900: Attachment: SQOOP-2900.patch > Support encrypting map inputs with sensitive fields > ---

[jira] [Updated] (SQOOP-2900) Support encrypting map inputs with sensitive fields

2016-04-12 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2900: Attachment: (was: SQOOP-2900.patch) > Support encrypting map inputs with sensitive fields >

[jira] [Commented] (SQOOP-2900) Support encrypting map inputs with sensitive fields

2016-04-12 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238015#comment-15238015 ] Sqoop QA bot commented on SQOOP-2900: - Testing file [SQOOP-2900.patch|https://issues.

[jira] [Commented] (SQOOP-2891) Repository encryption documentation

2016-04-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238131#comment-15238131 ] ASF subversion and git services commented on SQOOP-2891: Commit 31

Re: Review Request 45860: SQOOP-2891

2016-04-12 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45860/#review128562 --- Ship it! Ship It! - Jarek Cecho On April 11, 2016, 11:46 p.m

[jira] [Commented] (SQOOP-2891) Repository encryption documentation

2016-04-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238204#comment-15238204 ] Hudson commented on SQOOP-2891: --- SUCCESS: Integrated in Sqoop2 #1040 (See [https://builds.a