Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210796 --- Ship it! Ship It! - Boglarka Egyed On Nov. 22, 2018, 1:39 p.

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210795 --- Ship it! Ship It! - Szabolcs Vasas On Nov. 22, 2018, 1:39 p.

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java > > Lines 24 (patched) > > > > > > Renamed files are shown as new files n

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 22, 2018, 1:39 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java > > Lines 24 (patched) > > > > > > Renamed files are shown as new files n

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210785 --- src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobT

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 21, 2018, 2:05 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java > > Lines 1 (patched) > > > > > > Apache headers are missing from new files.

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 3 p.m.) Review request for Sqoop, Boglarka Egyed and Sz

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210762 --- Fix it, then Ship it! Hi Fero, Your change generally looks goo

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210756 --- Ship it! Hi Feró, Thank you for improving these tests, unit an

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 10:20 a.m.) Review request for Sqoop, Boglarka Egyed an

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:31 a.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:29 a.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:07 a.m.) Review request for Sqoop, Boglarka Egyed and

Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3405