Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- (Updated Aug. 28, 2018, 12:04 p.m.) Review request for Sqoop, daniel voros, Fer

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

> On Aug. 28, 2018, 11:41 a.m., Fero Szabo wrote: > > All ant tests passed on my system. (unit, 3rd party and s3). Gradle unit tests passed as well. - Fero --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review208030 --- Fix it, then Ship it! src/test/org/apache/sqoop/testutil/S3Tes

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review208029 --- Ship it! Hi Bogi, Thanks for fixing the findings, I have reran

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- (Updated Aug. 28, 2018, 8:33 a.m.) Review request for Sqoop, daniel voros, Fero

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review207962 --- src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.jav

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review207957 --- Fix it, then Ship it! Hi Bogi, Thank you for submitting the fi

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

> On Aug. 24, 2018, 7:49 a.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java > > Lines 33 (patched) > > > > > > I think you could use org.apache.sqoop.util.ParquetReader instea

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- (Updated Aug. 24, 2018, 2:41 p.m.) Review request for Sqoop, daniel voros, Fero

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review207854 --- src/test/org/apache/sqoop/s3/TestS3AvroImport.java Line 46 (origi

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- (Updated Aug. 23, 2018, 6:18 p.m.) Review request for Sqoop, daniel voros, Fero

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- (Updated Aug. 23, 2018, 3:56 p.m.) Review request for Sqoop, daniel voros, Fero

Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/ --- Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs