Re: Review Request 68278: Add LOG message for git hash

2018-08-10 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207067 --- Ship it! Very good idea to include these in the logs! :) Thank

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/ --- (Updated Aug. 9, 2018, 8 p.m.) Review request for Sqoop. Bugs: SQOOP-3359

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong
> On Aug. 9, 2018, 2:02 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/Sqoop.java > > Lines 95 (patched) > > > > > > I have just realized that VERSION and GIT_HASH are static final members > > of SqoopVers

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207030 --- Hi Nguyen, Thank you for submitting this patch, it is a nice litt

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/ --- (Updated Aug. 9, 2018, 1:53 p.m.) Review request for Sqoop. Bugs: SQOOP-3359

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207025 --- src/java/org/apache/sqoop/Sqoop.java Lines 95 (patched)

Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/ --- Review request for Sqoop. Bugs: SQOOP-3359 https://issues.apache.org/jira/b