Re: Review Request 69433: Setting up Travis CI using Gradle test categories

2018-11-23 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/#review210825 --- Ship it! Hi Szabi, not an issue, just an idea. In any case, t

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

2018-11-23 Thread daniel voros
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/#review210826 --- Ship it! So cool, thanks for picking this up! I believe this ca

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

2018-11-23 Thread Szabolcs Vasas
> On Nov. 22, 2018, 4:41 p.m., Fero Szabo wrote: > > Hi Szabi, > > > > The whole change looks good to me, haven't spotted any mistakes, though > > still need to run tests. > > > > Just some questions to clarify my understanding of the change: > > > > I see the build.xml contains the default v

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

2018-11-23 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/ --- (Updated Nov. 23, 2018, 10:33 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

2018-11-22 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/#review210809 --- Hi Szabi, The whole change looks good to me, haven't spotted any