Github user JoeriHermans commented on the pull request:
https://github.com/apache/sqoop/pull/18#issuecomment-208796233
@stanleyxu2005 Why would you check if data has valid length? The original
code also crashes if an empty string is specified, so I didn't bother with
checking for vali
Github user stanleyxu2005 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/18#discussion_r59337930
--- Diff: src/java/org/apache/sqoop/avro/AvroUtil.java ---
@@ -114,11 +114,20 @@ public static String toAvroColumn(String column) {
* Format candid
]
Sent: Monday, April 11, 2016 9:50 PM
To: dev@sqoop.apache.org
Subject: [GitHub] sqoop pull request: Optimize toAvroIdentifier
GitHub user JoeriHermans opened a pull request:
https://github.com/apache/sqoop/pull/18
Optimize toAvroIdentifier
Our distributed profiler indicated some
GitHub user JoeriHermans opened a pull request:
https://github.com/apache/sqoop/pull/18
Optimize toAvroIdentifier
Our distributed profiler indicated some inefficiencies in the
AvroUtil.toAvroIdentifier method, more specifically, the use of Regex patterns.
This can be directly obser
