GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/96
[SPARK-1194] Fix the same-RDD rule for cache replacement
SPARK-1194: https://spark-project.atlassian.net/browse/SPARK-1194
In the current implementation, when selecting candidate blocks to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10388071
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10388411
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10390021
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,23 @@ private class MemoryStore(blockManager: BlockManager
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/96#discussion_r10394826
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -236,13 +236,18 @@ private class MemoryStore(blockManager: BlockManager
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37089290
@pwendell Regression test case added, also ensured that the old
implementation fails on this test case.
---
If your project is set up for it, you can reply to this
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091724
May I ask the reason? I understand that impact of this bug is limited.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/96#issuecomment-37091921
Thanks for the explanation :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
