Re: How to convert InternalRow to Row.

2020-11-27 Thread Wenchen Fan
InternalRow is an internal/developer API that might change overtime. Right now, the way to convert it to Row is to use `RowEncoder`, but you need to know the data schema: val encoder = RowEncoder(schema) val row = encoder.fromRow(internalRow) On Fri, Nov 27, 2020 at 6:16 AM Jason Jun wrote: > H

Re: Seeking committers' help to review on SS PR

2020-11-27 Thread Jungtaek Lim
Thanks for providing valuable feedback. Appreciate it. Sorry I haven't had time to reply to this in time (was OoO this week). I'm also in favor of "review then commit", I haven't been a "perfect" guy making no mistake (probably that justifies me as a human being), hence the review process is a cri

Re: Seeking committers' help to review on SS PR

2020-11-27 Thread Jungtaek Lim
Btw, there are two more PRs which got LGTM by a SS contributor but fail to get attention from committers. They're 6+ months old. Could you help reviewing this as well, or do you all think 6 months of time range + LGTM from an SS contributor is enough to go ahead? https://github.com/apache/spark/pu

Re: Seeking committers' help to review on SS PR

2020-11-27 Thread Sean Owen
I don't know the code well, but those look minor and straightforward. They have reviews from the two most knowledgeable people in this area. I don't think you need to block for 6 months after proactively seeking all likely reviewers - I'm saying that's the resolution to this type of situation (too)