Re: pull request template

2016-03-19 Thread Bryan Cutler
t; >>> > get wrong the order between Jira and component. >> >>> > >> >>> > Moreover, CONTRIBUTING.md is also lacking them. Any reason not to >> >>> > add it >> >>> > there? I can open

Re: pull request template

2016-03-19 Thread Reynold Xin
nd component. >> >>> > >> >>> > Moreover, CONTRIBUTING.md is also lacking them. Any reason not to >> add it >> >>> > there? I can open PRs for both, but maybe you want to keep that >> info on >> >>> > the >>

Re: pull request template

2016-03-15 Thread Marcelo Vanzin
Dragoș >> >>> wrote: >> >>> > It's a good idea. I would add in there the spec for the PR title. I >> >>> > always >> >>> > get wrong the order between Jira and component. >> >>> > >> >>> > Moreover, CONTRIBUTING.md

Re: pull request template

2016-03-15 Thread Joseph Bradley
; > always > >>> > get wrong the order between Jira and component. > >>> > > >>> > Moreover, CONTRIBUTING.md is also lacking them. Any reason not to > add it > >>> > there? I can open PRs for both, but maybe you want to keep th

Re: pull request template

2016-03-12 Thread Sean Owen
ny reason not to add it >>> > there? I can open PRs for both, but maybe you want to keep that info on >>> > the >>> > wiki instead. >>> > >>> > iulian >>> > >>> > On Thu, Feb 18, 2016 at 4:18 AM, Reynold Xin &

Re: pull request template

2016-03-11 Thread Marcelo Vanzin
gt;> >> templates for pull requests. I pushed a very simple template to the >> >> repository: >> >> >> >> >> >> https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE >> >> >> >> >> >&

Re: pull request template

2016-02-19 Thread Reynold Xin
t; >> > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE > >> > >> > >> Over time I think we can see how this works and perhaps add a small > >> checklist to the pull request template so contributors are reminded > every > >

Re: pull request template

2016-02-19 Thread Sean Owen
LATE >> >> >> Over time I think we can see how this works and perhaps add a small >> checklist to the pull request template so contributors are reminded every >> time they submit a pull request the important things to do in a pull request >> (e.g. having proper tests

Re: pull request template

2016-02-19 Thread Iulian Dragoș
LATE > > > Over time I think we can see how this works and perhaps add a small > checklist to the pull request template so contributors are reminded every > time they submit a pull request the important things to do in a pull > request (e.g. having proper tests). > > &g

pull request template

2016-02-17 Thread Reynold Xin
checklist to the pull request template so contributors are reminded every time they submit a pull request the important things to do in a pull request (e.g. having proper tests). ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was the this