Re: Spark internal Logging trait potential thread unsafe

2016-06-22 Thread Prajwal Tuladhar
Created a JIRA issue https://issues.apache.org/jira/browse/SPARK-16131 and PR @ https://github.com/apache/spark/pull/13842 On Fri, Jun 17, 2016 at 5:19 AM, Sean Owen wrote: > I think that's OK to change, yes. I don't see why it's necessary to > init log_ the way it is now. initializeLogIfNecessa

Re: Spark internal Logging trait potential thread unsafe

2016-06-17 Thread Sean Owen
I think that's OK to change, yes. I don't see why it's necessary to init log_ the way it is now. initializeLogIfNecessary() has a purpose though. On Fri, Jun 17, 2016 at 2:39 AM, Prajwal Tuladhar wrote: > Hi, > > The way log instance inside Logger trait is current being initialized > doesn't seem

Spark internal Logging trait potential thread unsafe

2016-06-16 Thread Prajwal Tuladhar
Hi, The way log instance inside Logger trait is current being initialized doesn't seem to be thread safe [1]. Current implementation only guarantees initializeLogIfNecessary() is initialized in lazy + thread safe way. Is there a reason why it can't be just: [2] @transient private lazy val log_ :