Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-12 Thread Reynold Xin
Most these files are just package-info.java there for having a good package index for JavaDoc. If we move them, we will need to create a folder in the java one for each package that exposes any documentation. And it is very likely we will forget to update package-info.java when we update package.sc

Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-12 Thread Sean Owen
There are actually 33 instances of a Java file in src/main/scala -- I opened https://issues.apache.org/jira/browse/SPARK-10576 to track a discussion and decision. On Fri, Sep 11, 2015 at 3:10 PM, lonikar wrote: > It does not cause any problem when building using maven. But when doing > eclipse:ec

Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-11 Thread lonikar
It does not cause any problem when building using maven. But when doing eclipse:eclipse, the generated .classpath files contained only . This caused all the .scala sources to be ignored and caused all kinds of eclipse build errors. It resolved only when I added prebuild jars in the java build path,

Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-10 Thread Sean Owen
This is probably true as the scala plugin actually compiles both .scala and .java files. Still it seems like the wrong place just as a matter of style. Can we try moving it and verify it's still OK? On Fri, Sep 11, 2015 at 12:43 AM, Reynold Xin wrote: > There isn't really any difference I think

Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-10 Thread Reynold Xin
There isn't really any difference I think where you put them. Did you run into a problem? On Thu, Sep 10, 2015 at 6:38 AM, Sean Owen wrote: > I feel like I knew the answer to this but have forgotten. Reynold do > you know about this file? looks like you added it. > > On Thu, Sep 10, 2015 at 1:1

Re: Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-10 Thread Sean Owen
I feel like I knew the answer to this but have forgotten. Reynold do you know about this file? looks like you added it. On Thu, Sep 10, 2015 at 1:10 PM, lonikar wrote: > I found these files: > spark-1.5.0/sql/catalyst/*src/main/scala*/org/apache/spark/sql/types/*SQLUserDefinedType.java* > > spark

Spark 1.5.x: Java files in src/main/scala and vice versa

2015-09-10 Thread lonikar
I found these files: spark-1.5.0/sql/catalyst/*src/main/scala*/org/apache/spark/sql/types/*SQLUserDefinedType.java* spark-1.5.0/core/src/main/java/org/apache/spark/api/java/function/package.scala and several java files in spark-1.5.0/core/src/main/scala/. Is this intentional or inadvertant? --