Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-27 Thread Imran Rashid
Does scoverage work with the spark build in 2.11? That sounds like a big win On Sun, Jul 26, 2015 at 1:29 PM, Josh Rosen wrote: > Given that 2.11 may be more stringent with respect to warnings, we might > consider building with 2.11 instead of 2.10 in the pull request builder. > This would also

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-26 Thread Josh Rosen
Given that 2.11 may be more stringent with respect to warnings, we might consider building with 2.11 instead of 2.10 in the pull request builder. This would also have some secondary benefits in terms of letting us use tools like Scapegoat or SCoverage highlighting. On Sat, Jul 25, 2015 at 8:52 AM,

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-25 Thread Iulian Dragoș
On Fri, Jul 24, 2015 at 8:19 PM, Reynold Xin wrote: Jenkins only run Scala 2.10. I'm actually not sure what the behavior is > with 2.11 for that patch. > > iulian - can you take a look into it and see if it is working as expected? > It is, in the sense that warnings fail the build. Unfortunately

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-24 Thread Reynold Xin
Jenkins only run Scala 2.10. I'm actually not sure what the behavior is with 2.11 for that patch. iulian - can you take a look into it and see if it is working as expected? On Fri, Jul 24, 2015 at 10:24 AM, Iulian Dragoș wrote: > On Thu, Jul 23, 2015 at 6:08 AM, Reynold Xin wrote: > > Hi all,

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-24 Thread Iulian Dragoș
On Thu, Jul 23, 2015 at 6:08 AM, Reynold Xin wrote: Hi all, > > FYI, we just merged a patch that fails a build if there is a scala > compiler warning (if it is not deprecation warning). > I’m a bit confused, since I see quite a lot of warnings in semi-legitimate code. For instance, @transient (p

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-24 Thread Reynold Xin
You can give it a shot, but we will have to revert it for a project as soon as a project uses a deprecated API somewhere. On Fri, Jul 24, 2015 at 7:43 AM, Punyashloka Biswal wrote: > Would it make sense to isolate the use of deprecated warnings to a subset > of projects? That way we could turn

Re: non-deprecation compiler warnings are upgraded to build errors now

2015-07-24 Thread Punyashloka Biswal
Would it make sense to isolate the use of deprecated warnings to a subset of projects? That way we could turn on more stringent checks for the other ones. Punya On Thu, Jul 23, 2015 at 12:08 AM Reynold Xin wrote: > Hi all, > > FYI, we just merged a patch that fails a build if there is a scala >