Re: TimSort bug

2018-08-31 Thread Reynold Xin
Thanks for looking into this, Sean! Loved the tl;dr. On Fri, Aug 31, 2018 at 12:28 PM Sean Owen wrote: > TL;DR - We already had the fix from SPARK-5984. The delta from the current > JDK implementation to Spark's looks actually inconsequential. No action > required AFAICT. > > On Fri, Aug 31, 20

Re: TimSort bug

2018-08-31 Thread Sean Owen
TL;DR - We already had the fix from SPARK-5984. The delta from the current JDK implementation to Spark's looks actually inconsequential. No action required AFAICT. On Fri, Aug 31, 2018 at 12:30 PM Sean Owen wrote: > I looked into this, because it sure sounds like a similar issue from a few > yea

Re: TimSort bug

2018-08-31 Thread Sean Owen
I looked into this, because it sure sounds like a similar issue from a few years ago that was fixed in https://issues.apache.org/jira/browse/SPARK-5984 The change in that JIRA actually looks almost identical to the change mentioned in the JDK bug: http://hg.openjdk.java.net/jdk/jdk/rev/3a6d47df823