Re: Pull Requests on github

2015-02-09 Thread fommil
Cool, thanks! Let me know if there are any more core numerical libraries that you'd like to see to support Spark with optimised natives using a similar packaging model at netlib-java. I'm interested in fast random number generation next, and I keep wondering if anybody would be interested in payin

Re: Pull Requests on github

2015-02-09 Thread Andrew Ash
Sam, I see your PR was merged -- many thanks for sending it in and getting it merged! In general for future reference, the most effective way to contribute is outlined on this wiki page: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark On Mon, Feb 9, 2015 at 1:04 AM, Akhil

Re: Pull Requests on github

2015-02-08 Thread Akhil Das
You can open a Jira issue pointing this PR to get it processed faster. :) Thanks Best Regards On Sat, Feb 7, 2015 at 7:07 AM, fommil wrote: > Hi all, > > I'm the author of netlib-java and I noticed that the documentation in MLlib > was out of date and misleading, so I submitted a pull request o

Re: Pull Requests

2014-10-06 Thread Bill Bejeck
Can someone review patch #2309 (jira task SPARK-3178) Thanks On Mon, Oct 6, 2014 at 10:41 PM, Patrick Wendell wrote: > Hey Bill, > > Automated testing is just one small part of the process that performs > basic sanity checks on code. All patches need to be championed and > merged by a committer

Re: Pull requests will be automatically linked to JIRA when submitted

2014-08-25 Thread Patrick Wendell
Hey Nicholas, That seems promising - I prefer having a proper link to having that fairly verbose comment though, because in some cases there will be dozens of comments and it could get lost. I wonder if they could do something where it posts a link instead... - Patrick On Mon, Aug 25, 2014 at 1

Re: Pull requests will be automatically linked to JIRA when submitted

2014-08-25 Thread Nicholas Chammas
FYI: Looks like the Mesos folk also have a bot to do automatic linking, but it appears to have been provided to them somehow by ASF. See this comment as an example: https://issues.apache.org/jira/browse/MESOS-1688?focusedCommentId=14109078&page=com.atlassian.jira.plugin.system.issuetabpanels:comme

Re: Pull requests will be automatically linked to JIRA when submitted

2014-08-11 Thread Nicholas Chammas
Thanks for looking into this. I think little tools like this are super helpful. Would it hurt to open a request with INFRA to install/configure the JIRA-GitHub plugin while we continue to use the Python script we have? I wouldn't mind opening that JIRA issue with them. Nick On Mon, Aug 11, 2014

Re: Pull requests will be automatically linked to JIRA when submitted

2014-08-11 Thread Patrick Wendell
I spent some time on this and I'm not sure either of these is an option, unfortunately. We typically can't use custom JIRA plug-in's because this JIRA is controlled by the ASF and we don't have rights to modify most things about how it works (it's a large shared JIRA instance used by more than 50

Re: Pull requests will be automatically linked to JIRA when submitted

2014-08-11 Thread Nicholas Chammas
It looks like this script doesn't catch PRs that are opened and *then* have the JIRA issue ID added to the name. Would it be easy to somehow have the script trigger on PR name changes as well as PR creates? Alternately, is there a reason we can't or don't want to use the plugin mentioned below? (I

Re: Pull requests will be automatically linked to JIRA when submitted

2014-07-23 Thread Nicholas Chammas
By the way, it looks like there’s a JIRA plugin that integrates it with GitHub: - https://marketplace.atlassian.com/plugins/com.atlassian.jira.plugins.jira-bitbucket-connector-plugin - https://confluence.atlassian.com/display/BITBUCKET/Linking+Bitbucket+and+GitHub+accounts+to+JIRA I

Re: Pull requests will be automatically linked to JIRA when submitted

2014-07-20 Thread Patrick Wendell
Yeah it needs to have SPARK-XXX in the title (this is the format we request already). It just works with small synchronization script I wrote that we run every five minutes on Jeknins that uses the Github and Jenkins API: https://github.com/apache/spark/commit/49e472744951d875627d78b0d6e93cd139232

Re: Pull requests will be automatically linked to JIRA when submitted

2014-07-20 Thread Nicholas Chammas
That's pretty neat. How does it work? Do we just need to put the issue ID (e.g. SPARK-1234) anywhere in the pull request? Nick On Sat, Jul 19, 2014 at 11:10 PM, Patrick Wendell wrote: > Just a small note, today I committed a tool that will automatically > mirror pull requests to JIRA issues,

Re: Pull requests will be automatically linked to JIRA when submitted

2014-07-20 Thread Nan Zhu
Awesome! On Saturday, July 19, 2014, Patrick Wendell wrote: > Just a small note, today I committed a tool that will automatically > mirror pull requests to JIRA issues, so contributors will no longer > have to manually post a pull request on the JIRA when they make one. > > It will create a "lin