Re: File JIRAs for all flaky test failures

2018-02-08 Thread Marcelo Vanzin
Hey all, I just wanted to bring up Kay's old e-mail about this. If you see a flaky test during a PR, don't just ask for a re-test. File a bug so that we know that test is flaky and someone will eventually take a look at it. A lot of them also make great newbie bugs. I've filed a bunch of these i

Re: File JIRAs for all flaky test failures

2017-03-28 Thread Saikat Kanjilal
nd fixing them, that's all. To organize the effort I suggested tackling this by module. Your second sentence is what I was trying to gauge from the community before putting anymore effort into this. From: Sean Owen mailto:so...@cloudera.com>> Sent: T

Re: File JIRAs for all flaky test failures

2017-03-27 Thread Kay Ousterhout
organize the effort I suggested tackling >> this by module. Your second sentence is what I was trying to gauge from >> the community before putting anymore effort into this. >> >> >> -- >> *From:* Sean Owen >> *Sent:* Thursday, February 16, 2017 8:45 AM >>

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Reynold Xin
putting anymore effort into this. > > > -- > *From:* Sean Owen > *Sent:* Thursday, February 16, 2017 8:45 AM > *To:* Saikat Kanjilal; dev@spark.apache.org > > *Subject:* Re: File JIRAs for all flaky test failures > > I'm not sure what you're specifically s

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Saikat Kanjilal
this. From: Sean Owen Sent: Thursday, February 16, 2017 8:45 AM To: Saikat Kanjilal; dev@spark.apache.org Subject: Re: File JIRAs for all flaky test failures I'm not sure what you're specifically suggesting. Of course flaky tests are bad and they should be fixed, and peopl

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Sean Owen
; *To:* Josh Rosen > *Cc:* Armin Braun; Kay Ousterhout; dev@spark.apache.org > > *Subject:* Re: File JIRAs for all flaky test failures > The issue was not with a lack of tooling, I used the url you are > describing below to drill down to the exact test failure/stack trace, the > problem was t

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Saikat Kanjilal
be an actual problem that we want to spend time and energy to fix. Thanks From: Reynold Xin Sent: Thursday, February 16, 2017 8:27 AM To: Saikat Kanjilal Cc: dev@spark.apache.org Subject: Re: File JIRAs for all flaky test failures What exactly is the issue?

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Saikat Kanjilal
__ From: Saikat Kanjilal Sent: Wednesday, February 15, 2017 6:12 PM To: Josh Rosen Cc: Armin Braun; Kay Ousterhout; dev@spark.apache.org Subject: Re: File JIRAs for all flaky test failures The issue was not with a lack of tooling, I used the url you are describing below to drill down to

Re: File JIRAs for all flaky test failures

2017-02-16 Thread Reynold Xin
; dive into this again with some help. > -- > *From:* Saikat Kanjilal > *Sent:* Wednesday, February 15, 2017 6:12 PM > *To:* Josh Rosen > *Cc:* Armin Braun; Kay Ousterhout; dev@spark.apache.org > > *Subject:* Re: File JIRAs for all flaky test failures > >

Re: File JIRAs for all flaky test failures

2017-02-15 Thread Saikat Kanjilal
nesday, February 15, 2017 12:48 PM To: Saikat Kanjilal Cc: Kay Ousterhout; dev@spark.apache.org<mailto:dev@spark.apache.org> Subject: Re: File JIRAs for all flaky test failures I think one thing that is contributing to this a lot too is the general issue of the tests taking up a lot of file descrip

Re: File JIRAs for all flaky test failures

2017-02-15 Thread Josh Rosen
Armin Braun *Sent:* Wednesday, February 15, 2017 12:48 PM *To:* Saikat Kanjilal *Cc:* Kay Ousterhout; dev@spark.apache.org *Subject:* Re: File JIRAs for all flaky test failures I think one thing that is contributing to this a lot too is the general issue of the tests taking up a lot of file descript

Re: File JIRAs for all flaky test failures

2017-02-15 Thread shane knapp
it's not an open-file limit -- i have the jenkins workers set up w/a soft file limit of 100k, and a hard limit of 200k. On Wed, Feb 15, 2017 at 12:48 PM, Armin Braun wrote: > I think one thing that is contributing to this a lot too is the general > issue of the tests taking up a lot of file desc

Re: File JIRAs for all flaky test failures

2017-02-15 Thread Saikat Kanjilal
ry 15, 2017 12:48 PM To: Saikat Kanjilal Cc: Kay Ousterhout; dev@spark.apache.org Subject: Re: File JIRAs for all flaky test failures I think one thing that is contributing to this a lot too is the general issue of the tests taking up a lot of file descriptors (10k+ if I run them on a standard D

Re: File JIRAs for all flaky test failures

2017-02-15 Thread Armin Braun
I think one thing that is contributing to this a lot too is the general issue of the tests taking up a lot of file descriptors (10k+ if I run them on a standard Debian machine). There are a few suits that contribute to this in particular like `org.apache.spark.ExecutorAllocationManagerSuite` which,

Re: File JIRAs for all flaky test failures

2017-02-15 Thread Saikat Kanjilal
I was working on something to address this a while ago https://issues.apache.org/jira/browse/SPARK-9487 but the difficulty in testing locally made things a lot more complicated to fix for each of the unit tests, should we resurface this JIRA again, I would whole heartedly agree with the flakine