Re: Difference between netty and netty-all

2016-12-06 Thread Steve Loughran
Nicholas, FYI, there's some patch for Hadoop 2.8? 2.9? to move up to Netty https://issues.apache.org/jira/browse/HADOOP-13866 https://issues.apache.org/jira/browse/HADOOP-12854 On 5 Dec 2016, at 19:46, Nicholas Chammas mailto:nicholas.cham...@gmail.com>> wrote: So if I'm running Spark 2.0.2

Re: Difference between netty and netty-all

2016-12-05 Thread Nicholas Chammas
Latest 4.0.x is Netty 4.0.42 and master is already on that version. My comments earlier were about the version of Netty that Spark 2.0.2 uses, which is why I thought you were talking about branch-2.0. Anyway, I don’t think we need to do anything here. If someone is having serious Netty problems c

Re: Difference between netty and netty-all

2016-12-05 Thread Shixiong(Ryan) Zhu
No. I meant only updating master. It's not worth to update a maintenance branch unless there are critical issues. On Mon, Dec 5, 2016 at 5:39 PM, Nicholas Chammas wrote: > You mean just for branch-2.0, right? > ​ > > On Mon, Dec 5, 2016 at 8:35 PM Shixiong(Ryan) Zhu > wrote: > >> Hey Nick, >> >

Re: Difference between netty and netty-all

2016-12-05 Thread Nicholas Chammas
You mean just for branch-2.0, right? ​ On Mon, Dec 5, 2016 at 8:35 PM Shixiong(Ryan) Zhu wrote: > Hey Nick, > > It should be safe to upgrade Netty to the latest 4.0.x version. Could you > submit a PR, please? > > On Mon, Dec 5, 2016 at 11:47 AM, Nicholas Chammas < > nicholas.cham...@gmail.com> w

Re: Difference between netty and netty-all

2016-12-05 Thread Shixiong(Ryan) Zhu
Hey Nick, It should be safe to upgrade Netty to the latest 4.0.x version. Could you submit a PR, please? On Mon, Dec 5, 2016 at 11:47 AM, Nicholas Chammas < nicholas.cham...@gmail.com> wrote: > That file is in Netty 4.0.29, but I believe the PR I referenced is not. > It's only in Netty 4.0.37 an

Re: Difference between netty and netty-all

2016-12-05 Thread Nicholas Chammas
That file is in Netty 4.0.29, but I believe the PR I referenced is not. It's only in Netty 4.0.37 and up. On Mon, Dec 5, 2016 at 1:57 PM Ted Yu wrote: > This should be in netty-all : > > $ jar tvf > /home/x/.m2/repository/io/netty/netty-all/4.0.29.Final/netty-all-4.0.29.Final.jar > | grep Thread

Re: Difference between netty and netty-all

2016-12-05 Thread Nicholas Chammas
So if I'm running Spark 2.0.2 built against Hadoop 2.6, I should be running [Netty 4.0.29.Final]( https://github.com/apache/spark/blob/v2.0.2/dev/deps/spark-deps-hadoop-2.6#L141 ), rig

Re: Difference between netty and netty-all

2016-12-05 Thread Sean Owen
netty should be Netty 3.x. It is all but unused but I couldn't manage to get rid of it: https://issues.apache.org/jira/browse/SPARK-17875 netty-all should be 4.x, actually used. On Tue, Dec 6, 2016 at 12:54 AM Nicholas Chammas wrote: > I’m looking at the list of dependencies here: > > > https:/

Re: Difference between netty and netty-all

2016-12-05 Thread Ted Yu
This should be in netty-all : $ jar tvf /home/x/.m2/repository/io/netty/netty-all/4.0.29.Final/netty-all-4.0.29.Final.jar | grep ThreadLocalRandom 967 Tue Jun 23 11:10:30 UTC 2015 io/netty/util/internal/ThreadLocalRandom$1.class 1079 Tue Jun 23 11:10:30 UTC 2015 io/netty/util/internal/ThreadL