Re: Correctness and data loss issues

2020-01-22 Thread Tom Graves
My thoughts on your list, would be good to get people who worked on these issues input. Obviously we can weigh the importance of these vs getting 2.4.5 out that has a bunch of other correctness fixes you mention as well.  I think you have already pinged on most of the jira to get feedback.  SP

Re: Correctness and data loss issues

2020-01-22 Thread Dongjoon Hyun
Hi, All. BTW, based on the AS-IS feedbacks, I updated all open `correctness` and `dataloss` issues like the followings. 1. Raised the issue priority into `Blocker`. 2. Set the target version to `3.0.0`. It's a time to give more visibility to those issues in order to close or resolve. Th

Re: Correctness and data loss issues

2020-01-22 Thread Dongjoon Hyun
Hi, Tom. Then, along with the following, do you think we need to hold on 2.4.5 release, too? > If it's really a correctness issue we should hold 3.0 for it. Recently, (1) 2.4.4 delivered 9 correctness patches. (2) 2.4.5 RC1 aimed to deliver the following 9 correctness patches, too.

Re: Correctness and data loss issues

2020-01-22 Thread Tom Graves
I agree, I think we just need to go through all of them and individual assess each one. If it's really a correctness issue we should hold 3.0 for it. On the 2.4 release I didn't see an explanation on   https://issues.apache.org/jira/browse/SPARK-26154 why it can't be back ported, I think in the

Re: Correctness and data loss issues

2020-01-21 Thread Dongjoon Hyun
Thank you for checking, Wenchen! Sure, we need to do that. Another question is "What can we do for 2.4.5 release"? Some of the fixes cannot be backported due to the technical difficulty like the followings. 1. https://issues.apache.org/jira/browse/SPARK-26154 Stream-stream joins - lef

Re: Correctness and data loss issues

2020-01-21 Thread Wenchen Fan
I think we need to go through them during the 3.0 QA period, and try to fix the valid ones. For example, the first ticket should be fixed already in https://issues.apache.org/jira/browse/SPARK-28344 On Mon, Jan 20, 2020 at 2:07 PM Dongjoon Hyun wrote: > Hi, All. > > According to our policy, "Co