Re: Auto-closing PRs when there are no feedback or response from its author

2019-10-09 Thread Hyukjin Kwon
Yes, the problem was that it is difficult to automate. I think this has been discussed twice(?) in the mailing list; however, it ended up with doing nothing because it was difficult to automate. I think in case of PRs unlike JIRAs, there are some more different cases that need manual judgement. A

Re: Auto-closing PRs when there are no feedback or response from its author

2019-10-08 Thread Hyukjin Kwon
> 1. Although we close old JIRA issues on EOL-version only, but some issues doesn't have `Affected Versions` field info at all. >- https://issues.apache.org/jira/browse/SPARK-8542 For this case actually, I thought we resolved such cases all .. maybe some of them slipped out of my hand. Few ye

Re: Auto-closing PRs when there are no feedback or response from its author

2019-10-08 Thread Dongjoon Hyun
Thank you for keeping eyes on this difficult issue, Hyukjin. Although we try our best, there exist some corner cases always. For examples, 1. Although we close old JIRA issues on EOL-version only, but some issues doesn't have `Affected Versions` field info at all. - https://issues.apache.org

Re: Auto-closing PRs when there are no feedback or response from its author

2019-10-08 Thread Sean Owen
I'm generally all for closing pretty old PRs. They can be reopened easily. Closing a PR (a particular proposal for how to resolve an issue) is less drastic than closing a JIRA (a description of an issue). Closing them just delivers the reality, that nobody is going to otherwise revisit it, and can