Re: [Spark SQL] A single-pass resolution approach for the Catalyst Analyzer

2024-08-14 Thread Vladimir Golubev
- I think we can rely on the current tests. One possibility would be to dual-run both Analyzer implementations if `Utils.isTesting` and compare the (normalized) logical plans - We can implement the analyzer functionality by milestones (Milestone 0: Project, Filter, UnresolvedInlineTable, Milestone

Re: [Spark SQL] A single-pass resolution approach for the Catalyst Analyzer

2024-08-14 Thread Herman van Hovell
+1(000) on this! This should massively reduce allocations done in the analyzer, and it is much more efficient. I also can't count the times that I had to increase the number of iterations. This sounds like a no-brainer to me. I do have two questions: - How do we ensure that we don't accidenta