Great work, thanks Shane!
On Thu, Apr 18, 2019 at 2:46 PM shane knapp wrote:
> alrighty folks, the future is here and we'll be moving to python 3.6
> monday!
>
> all three PRs are green!
> master PR: https://github.com/apache/spark/pull/24266
> 2.4 PR: https://github.com/apache/spark/pull/2437
alrighty folks, the future is here and we'll be moving to python 3.6 monday!
all three PRs are green!
master PR: https://github.com/apache/spark/pull/24266
2.4 PR: https://github.com/apache/spark/pull/24379
2.3 PR: https://github.com/apache/spark/pull/24380
more detailed email coming out this
2.4 PR: https://github.com/apache/spark/pull/24379
2.3 PR: https://github.com/apache/spark/pull/24380
both of these branches failed pretty spectacularly during my non-PR testing
in the pyspark sql tests, but let's see how they fare when things are run
automagically by jenkins.
shane
On Mon, Ap
1) i absolutely do not want to test against more than two python
versions. consider my foot to have been put down on that. :)
2) i'll start testing against 2.3 and 2.4 now (last week was a bit crazy,
so i didn't get around to it).
once i'm happy w/the 2.3 and 2.4 results, i'll follow up here a
My guess is that branch 2.3, 2.4 still work with Python 3.6 even if
we're not testing that. If we're only testing against 3.6, I guess we
wouldn't detect if something broke for 3.4 which is still 'supported'
in 2.3.x, 2.4.x? For 3.x, no problem, let's raise the minimum anyway.
This could be fine if
ok, i'll create a PR for each branch so we can test things that way, rather
than backporting.
the bigger question i have is how far back, branch-wise, are we willing to
support w/regards to tests?
On Wed, Apr 10, 2019 at 12:16 PM Sean Owen wrote:
> In theory Spark 2.4 supports Python 3.4; would
In theory Spark 2.4 supports Python 3.4; would this mean it's now just
tested vs 3.6? that's not out of the question, but can the older
branches continue to test on older versions or is that super complex?
On Wed, Apr 10, 2019 at 1:37 PM shane knapp wrote:
>
> details here (see most recent commen