Re: [DISCUSS] remove the incomplete code path on aggregation for continuous mode

2020-07-12 Thread Jungtaek Lim
Just submitted the patch: https://github.com/apache/spark/pull/29077 On Tue, Jun 16, 2020 at 3:40 PM Jungtaek Lim wrote: > Bump this again. I filed SPARK-31985 [1] and plan to submit a PR in a > couple of days if there's no voice on the reason we should keep it. > > 1. https://issues.apache.org/

Re: [DISCUSS] remove the incomplete code path on aggregation for continuous mode

2020-06-15 Thread Jungtaek Lim
Bump this again. I filed SPARK-31985 [1] and plan to submit a PR in a couple of days if there's no voice on the reason we should keep it. 1. https://issues.apache.org/jira/browse/SPARK-31985 On Thu, May 21, 2020 at 8:54 AM Jungtaek Lim wrote: > Let me share the effect on removing the incomplete

Re: [DISCUSS] remove the incomplete code path on aggregation for continuous mode

2020-05-20 Thread Jungtaek Lim
Let me share the effect on removing the incomplete and undocumented code path. I manually tried out removing the code path and here's the change. https://github.com/HeartSaVioR/spark/commit/aa53e9b1b33c0b8aec37704ad290b42ffb2962d8 1,120 lines deleted without hurting any existing streaming tests,