---
> *From:* Imran Rashid
> *Sent:* Wednesday, August 29, 2018 1:42 PM
> *To:* ice.xell...@gmail.com
> *Cc:* dev
> *Subject:* Re: [DISCUSS] move away from python doctests
>
> (Also, maybe there are already good unit tests, and I just don't know
> where
.
From: Imran Rashid
Sent: Wednesday, August 29, 2018 1:42 PM
To: ice.xell...@gmail.com
Cc: dev
Subject: Re: [DISCUSS] move away from python doctests
(Also, maybe there are already good unit tests, and I just don't know where to
find them, as Bryan Cutler pointed out for the bit of
Hi Imran,
On Wed, 29 Aug 2018 at 22:26, Imran Rashid
wrote:
> Hi Li,
>
> yes that makes perfect sense. That more-or-less is the same as my view,
> though I framed it differently. I guess in that case, I'm really asking:
>
> Can pyspark changes please be accompanied by more unit tests, and not
(Also, maybe there are already good unit tests, and I just don't know where
to find them, as Bryan Cutler pointed out for the bit of code I was
originally asking about.)
On Wed, Aug 29, 2018 at 3:26 PM Imran Rashid wrote:
> Hi Li,
>
> yes that makes perfect sense. That more-or-less is the same
Hi Li,
yes that makes perfect sense. That more-or-less is the same as my view,
though I framed it differently. I guess in that case, I'm really asking:
Can pyspark changes please be accompanied by more unit tests, and not
assume we're getting coverage from doctests?
Imran
On Wed, Aug 29, 2018
Hi Imran,
My understanding is that doctests and unittests are orthogonal - doctests
are used to make sure docstring examples are correct and are not meant to
replace unittests.
Functionalities are covered by unit tests to ensure correctness and
doctests are used to test the docstring, not the func
