RE: ML: embed a transformer

2015-09-14 Thread Saif.A.Ellafi
: Ellafi, Saif A. Cc: dev Subject: Re: ML: embed a transformer Where did you read that it should be public? The traits in ml.param.shared are meant to be used across internal spark.ml<http://spark.ml> transformer implementations. If your transformer could be included in spark.ml<http:/

Re: ML: embed a transformer

2015-09-14 Thread Feynman Liang
Where did you read that it should be public? The traits in ml.param.shared are meant to be used across internal spark.ml transformer implementations. If your transformer could be included in spark.ml, then I would recommend implementing it there so these package private traits can be reused. Other