Considering the references It seems *RedundantIfChecker *is okay then.
Could I try to add this one?
*RedundantIfChecker *(See
http://www.scalastyle.org/rules-dev.html#org_scalastyle_scalariform_RedundantIfChecker
)
It seems there are two usage of this. This simply checks if (cond) true
else false
Ah I see, good references. Perhaps it's really then a committer judgement
call on how many changes become "too many" for a single PR.
2016년 5월 15일 (일) 오후 11:16, Hyukjin Kwon 님이 작성:
> Thank you so much for detailed explanation and the history.
>
>
> I understood and it seems *ProcedureDeclarationCh
Thank you so much for detailed explanation and the history.
I understood and it seems *ProcedureDeclarationChecker* should not be
enabled.
However, it seems *RedundantIfChecker* okay because there are only two
errors for this across the code base.
I have seen some rules have been added time t
Relevant discussion from some time ago:
https://issues.apache.org/jira/browse/SPARK-3849?focusedCommentId=14168961&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14168961
In short, if enabling a new style rule requires sweeping changes throughout
the code base, then
Hi all,
Lately, I made a list of rules currently not applied on Spark from
http://www.scalastyle.org/rules-dev.html and then I tried to test them.
I found two rules that I think might be helpful but I am not too sure.
Could I ask both can be added?
*RedundantIfChecker *(See
http://www.scalastyl